💬 l0rinc commented on pull request "cluster mempool: control/optimize TxGraph memory usage":
(https://github.com/bitcoin/bitcoin/pull/33157#discussion_r2403456079)
for the record, the `SanityCheck` below doesn't seem to fail without this change (i.e. build without fuzz passed if I have reverted this line for commit d9dbbf41b6458b11d9225fb436fc749bd30f9588). Not sure that's expected, it surprised me.

💬 l0rinc commented on pull request "coins: use number of dirty cache entries in flush warnings/logs":
(https://github.com/bitcoin/bitcoin/pull/33512#discussion_r2409314955)
Thanks, added a fuzz test and allowed existing entries to be attempted in `EmplaceCoinInternalDANGER`

💬 l0rinc commented on pull request "coins: use number of dirty cache entries in flush warnings/logs":
(https://github.com/bitcoin/bitcoin/pull/33512#discussion_r2409318128)
The modified fuzz already covers that - what would be the advantage of adding a unit test for it as well?

💬 maflcko commented on pull request "validation: Improve warnings in case of chain corruption":
(https://github.com/bitcoin/bitcoin/pull/33553#discussion_r2409727403)
```suggestion
LogWarning("Found invalid chain at least ~6 blocks longer than our best chain. Chain state database corruption likely.");
```

nit: while touching this, could add the correct log severity?

💬 zsaiwj commented on issue "Release Schedule for 30.0":
(https://github.com/bitcoin/bitcoin/issues/32275#issuecomment-3375627230)
V30 倒计时 💛💙💚

💬 Dorex45 commented on issue "Release Schedule for 30.0":
(https://github.com/bitcoin/bitcoin/issues/32275#issuecomment-3375633908)
V30 😃

💬 janb84 commented on pull request "Clear out space on GHA jobs":
(https://github.com/bitcoin/bitcoin/pull/33514#issuecomment-3375647372)
> > A run applying to all jobs when using GHA can be seen here: https://github.com/willcl-ark/bitcoin/actions/runs/18274913987
>
> Looking there, it seems like the cleanup step can take up to 10 minutes to complete i.e. https://github.com/willcl-ark/bitcoin/actions/runs/18274913987/job/52024710440. Although I guess that is less of an issue if it's not running in this repo.

Ok I missed this in my review, I also have a slight preference to revert this to only apply to the CentOS job. I woul
...

📝 maflcko opened a pull request: "build: Bump clang minimum supported version to 17"
(https://github.com/bitcoin/bitcoin/pull/33555)

💬 Sjors commented on pull request "wallet: allow skipping script paths":
(https://github.com/bitcoin/bitcoin/pull/32857#issuecomment-3375694837)
@rkrux I'm not too worried about reviews just yet, let's focus on getting https://github.com/bitcoin/bitcoin/pull/29675 in.

👋 maflcko's pull request is ready for review: "build: Bump clang minimum supported version to 17"
(https://github.com/bitcoin/bitcoin/pull/33555)

💬 vasild commented on pull request "Split CConnman":
(https://github.com/bitcoin/bitcoin/pull/30988#issuecomment-3375748629)
`dd32dfaaf3...69c015b258`: fix windows compilation

👋 fanquake's pull request is ready for review: "[28.x] More backports"
(https://github.com/bitcoin/bitcoin/pull/33535)

💬 vasild commented on pull request "Broadcast own transactions only via short-lived Tor or I2P connections":
(https://github.com/bitcoin/bitcoin/pull/29415#issuecomment-3375858344)
`21efe8fa82...7d837fef28`: rebase due to conflicts; remove changes that were already merged via https://github.com/bitcoin/bitcoin/pull/33454

🚀 fanquake merged a pull request: "[28.x] More backports"
(https://github.com/bitcoin/bitcoin/pull/33535)

💬 BenWestgate commented on pull request "doc: update multisig tutorial to use multipath descriptors":
(https://github.com/bitcoin/bitcoin/pull/33286#issuecomment-3375898948)
> The checksum for a descriptor without one can be computed using the `getdescriptorinfo` RPC. The response has the `descriptor` field, which is the descriptor with the checksum added.

This is not true for multi-path descriptors, we have to take the `checksum` field and append it to our input, similar to a private descriptor.

Should we document this?

💬 vasild commented on pull request "net: make m_nodes_mutex non-recursive":
(https://github.com/bitcoin/bitcoin/pull/32394#issuecomment-3375909395)
`aaa75c1a41...492be23a18`: rebase due to conflicts

💬 vasild commented on pull request "i2p: make a time gap between creating transient sessions and using them":
(https://github.com/bitcoin/bitcoin/pull/32065#issuecomment-3375937098)
`fc1ba52a4d...539d8b474e`: rebase due to conflicts

💬 vasild commented on pull request "net: replace manual reference counting of CNode with shared_ptr":
(https://github.com/bitcoin/bitcoin/pull/32015#issuecomment-3376001564)
`d026d5475e...abc29c4d8b`: rebase due to conflicts

⚠️ fanquake opened an issue: "build: `libcapnp*.so` "warning: GCS is required by -z gcs, but this shared library lacks the necessary property note.""
(https://github.com/bitcoin/bitcoin/issues/33556)
Building master (919e6d01e93a57d991ed456bc67c43605583ada8) in a Ubuntu 25.10 container (on aarch64), I see:
```bash
[ 1%] Linking CXX executable mpgen
/usr/lib/aarch64-linux-gnu/libcapnp-rpc-1.1.0.so: warning: GCS is required by -z gcs, but this shared library lacks the necessary property note. The dynamic loader might not enable GCS or refuse to load the program unless all the shared library dependencies have the GCS marking.
/usr/lib/aarch64-linux-gnu/libcapnpc-1.1.0.so: warning: GCS is requi
...

💬 fanquake commented on issue "build: `libcapnp*.so` "warning: GCS is required by -z gcs, but this shared library lacks the necessary property note."":
(https://github.com/bitcoin/bitcoin/issues/33556#issuecomment-3376045494)
cc @Sjors @ryanofsky.