💬 davidgumberg commented on pull request "test: fix p2p_leak_tx.py":
(https://github.com/bitcoin/bitcoin/pull/33121#issuecomment-3366820377)
reACK https://github.com/bitcoin/bitcoin/commit/14ae71f323dd011c6d51470ea15cf00750970f65

🤔 marcofleon reviewed a pull request: "[30.x] Backports & rc3"
(https://github.com/bitcoin/bitcoin/pull/33473#pullrequestreview-3300410005)
lgtm ACK 4e869a67aa7415f9c756bf6463e3437ae0a3ec44

The diff looks fine and I did a (light) code review of every PR commit.

🤔 mzumsande reviewed a pull request: "Improve LastCommonAncestor performance + add tests"
(https://github.com/bitcoin/bitcoin/pull/33515#pullrequestreview-3300473697)
Code Review ACK 3635d62f5a935801e26a0d5fa2cb5e2dbbb42f9b
The added test is slightly faster with the changes.

> I expect this to be very rare in normal occurrences, but it seems nontrivial to reason about worst cases as it's accessible from several places in net_processing.

I think it would require really long forked chains for this to become relevant, so basically in consensus split scenarios?!

💬 mzumsande commented on pull request "Improve LastCommonAncestor performance + add tests":
(https://github.com/bitcoin/bitcoin/pull/33515#discussion_r2403037390)
If I understand it correctly, we don't have to worry about dereferencing a `nullptr` here, because `pskip` is only `nullptr` for genesis, and if one of the blocks was genesis, we couldn't get to this spot.

💬 andrewtoth commented on pull request "validation: fetch block inputs on parallel threads >10% faster IBD":
(https://github.com/bitcoin/bitcoin/pull/31132#discussion_r2403069813)
Removed the batch size 🎉

🚀 fanquake merged a pull request: "test: fix p2p_leak_tx.py"
(https://github.com/bitcoin/bitcoin/pull/33121)

🚀 fanquake merged a pull request: "test: addrman: check isTerrible when time is more than 10min in the future"
(https://github.com/bitcoin/bitcoin/pull/33533)

💬 ryanofsky commented on pull request "init: Fix Ctrl-C shutdown hangs during wait calls":
(https://github.com/bitcoin/bitcoin/pull/33511#issuecomment-3367170341)
<!-- begin push-3 -->
Updated 68cad90dace40f7a015ca4ff81b878fc8fdc1dd5 -> c25a5e670b27d3b6eb958ce437dbe89678bd1511 ([`pr/sigwait.2`](https://github.com/ryanofsky/bitcoin/commits/pr/sigwait.2) -> [`pr/sigwait.3`](https://github.com/ryanofsky/bitcoin/commits/pr/sigwait.3), [compare](https://github.com/ryanofsky/bitcoin/compare/pr/sigwait.2..pr/sigwait.3))<!-- end --> fixing regression in previous version that caused Qt shutdown to hang during wait calls from the GUI console

👋 ryanofsky's pull request is ready for review: "init: Fix Ctrl-C shutdown hangs during wait calls"
(https://github.com/bitcoin/bitcoin/pull/33511)

👍 ryanofsky approved a pull request: "multiprocess: Fix high overhead from message logging"
(https://github.com/bitcoin/bitcoin/pull/33517#pullrequestreview-3300929927)
Partial code review ACK d6167af132febba14bd0d86d7465aef490c58fea (just reviewed the Bitcoin code changes in last two commits, not the earlier libmultiprocess changes which will disappear when rebased), but this all looks good

💬 ryanofsky commented on pull request "multiprocess: Fix high overhead from message logging":
(https://github.com/bitcoin/bitcoin/pull/33517#discussion_r2403330641)
In commit "multiprocess: update multiprocess EventLoop construction to use options" (7c0015d543b4a6141520a02895342b4a316b60fe)

This is fine to keep if intentional, but could consider passing unnamed temporary like `mp::LogOptions{.log_fn = IpcLogFn}` to simply code and avoid need for std::move, and not keep an empty options object on the stack for the duration of the thread.

💬 blocktraveler commented on issue "Enable `importprivkey`, `addmultisigaddress` in descriptor wallets":
(https://github.com/bitcoin/bitcoin/issues/30175#issuecomment-3367229312)
ℹ️ I've released the [Core Wallet Migration Tools](https://github.com/blocktraveler/Core-Wallet-Migration-Tools) in Python for this purpose which could be implemented into Core with a simple light-weight wrapper over the existing RPCs `getdescriptorinfo` and `importdescriptors`, see [Proposal: Add importprivkeys RPC (helper for WIF → descriptor import)](https://gist.github.com/blocktraveler/3e6198c698a272bd8b13b16e0f13d390) for details (also shared with the mailing list with subject `Add importp
...

💬 fanquake commented on pull request "Clear out space on centos job":
(https://github.com/bitcoin/bitcoin/pull/33514#issuecomment-3367257294)
cc @m3dwards

💬 ryanofsky commented on pull request "Update libmultiprocess subtree to support reduced logging":
(https://github.com/bitcoin/bitcoin/pull/33518#issuecomment-3367277916)
Note: This PR (and also #33519) is blocked on https://github.com/bitcoin-core/libmultiprocess/pull/222 to fix CI errors here. If that PR is reviewed and merged, this PR can be updated to include it and taken out of draft state.

https://github.com/bitcoin-core/libmultiprocess/pull/224 would also be nice to include here as it fixes the LLM linter typos pointed out above.

🚀 fanquake merged a pull request: "test: set par=2 in default config for functional test framework"
(https://github.com/bitcoin/bitcoin/pull/33485)

🤔 danielabrozzoni reviewed a pull request: "p2p: Use network-dependent timers for inbound inv scheduling"
(https://github.com/bitcoin/bitcoin/pull/33464#pullrequestreview-3301194864)
reACK 0f7d4ee4e8

I'm not very familiar with this portion of the code, but using `g_msgproc_mutex` seems fine to me (and cleaner than having the atomic). The lock already needs to be held in `SendMessages`, which is the only function from where we call `NextInvToInbounds`.

🚀 fanquake merged a pull request: "p2p: Use network-dependent timers for inbound inv scheduling"
(https://github.com/bitcoin/bitcoin/pull/33464)

💬 andrewtoth commented on pull request "validation: fetch block inputs on parallel threads >10% faster IBD":
(https://github.com/bitcoin/bitcoin/pull/31132#discussion_r2403595535)
Done.

💬 achow101 commented on pull request "wallet: Be able to receive and spend inputs involving MuSig2 aggregate keys":
(https://github.com/bitcoin/bitcoin/pull/29675#discussion_r2403607077)
If I need to retouch.

💬 achow101 commented on pull request "wallet: Be able to receive and spend inputs involving MuSig2 aggregate keys":
(https://github.com/bitcoin/bitcoin/pull/29675#discussion_r2403607122)
If I need to retouch.