💬 zaidmstrr commented on pull request "rpc: Handle -named argument parsing where '=' character is used":
(https://github.com/bitcoin/bitcoin/pull/32821#discussion_r2375898072)
I think using namespace is better here, as it provides clear intent of both the functions and how they are related. Also I find more readability using this approach.

🚀 fanquake merged a pull request: "macdeploy: avoid use of `Bitcoin Core` in Linux cross build"
(https://github.com/bitcoin/bitcoin/pull/33158)

💬 ryanofsky commented on pull request "multiprocess: Add capnp wrapper for Chain interface":
(https://github.com/bitcoin/bitcoin/pull/29409#issuecomment-3328660664)
<!-- begin push-17 -->
Rebased b372063241fbd34d27d062f3e438a3e425a9dfc5 -> 7ba7ec9d08927f244da8d5c1a7a1d7ced3239465 ([`pr/ipc-chain.16`](https://github.com/ryanofsky/bitcoin/commits/pr/ipc-chain.16) -> [`pr/ipc-chain.17`](https://github.com/ryanofsky/bitcoin/commits/pr/ipc-chain.17), [compare](https://github.com/ryanofsky/bitcoin/compare/pr/ipc-chain.16-rebase..pr/ipc-chain.17))<!-- end --> due to conflicts with #33169 and #32345

✅ fanquake closed an issue: "RPC: getblock(header) returns the same target for every block"
(https://github.com/bitcoin/bitcoin/issues/33440)

💬 ajtowns commented on pull request "net/rpc: Report inv information for debugging":
(https://github.com/bitcoin/bitcoin/pull/33448#discussion_r2375935187)
It's not needed the way we use it (passing in a fresh Stats argument each call), but arguably both should be zeroed out in case a previously-used object were reused.

🚀 fanquake merged a pull request: "rpc: fix getblock(header) returns target for tip"
(https://github.com/bitcoin/bitcoin/pull/33446)

💬 maflcko commented on pull request "contrib: Add zsh completion scripts":
(https://github.com/bitcoin/bitcoin/pull/33402#issuecomment-3328705784)
Please squash your commits according to https://github.com/bitcoin/bitcoin/blob/master/CONTRIBUTING.md#squashing-commits

📝 fanquake opened a pull request: "[30.x] Backports & rc3"
(https://github.com/bitcoin/bitcoin/pull/33473)
Backports:
* #33446

💬 fanquake commented on pull request "rpc: fix getblock(header) returns target for tip":
(https://github.com/bitcoin/bitcoin/pull/33446#issuecomment-3328714993)
Backported to `30.x` in #33473.

💬 Sjors commented on pull request "guix: documented shasum gathering command":
(https://github.com/bitcoin/bitcoin/pull/33472#issuecomment-3328735722)
ACK d29ab9946f3c1916032f41e7a365dfcb26af2c46

💬 RandyMcMillan commented on pull request "Feature: Use different datadirs for different signets":
(https://github.com/bitcoin/bitcoin/pull/29838#issuecomment-3328754279)
note: i already tested

https://github.com/bitcoin-core/gui/pull/896/files

on top of this PR 🔥

🚀 fanquake merged a pull request: "Backport Cirrus runners to 29.x"
(https://github.com/bitcoin/bitcoin/pull/33403)

💬 ryanofsky commented on pull request "cli: Handle arguments that can be either JSON or string":
(https://github.com/bitcoin/bitcoin/pull/33230#issuecomment-3328865138)
Code review ACK df67bb6fd84c393eaf00f19074085ee080546bd3, just rebased since last review. I do still think it would be good to improve the test (https://github.com/bitcoin/bitcoin/pull/33230#discussion_r2369570345)

📝 fanquake opened a pull request: "[29.x] Backports"
(https://github.com/bitcoin/bitcoin/pull/33474)
Backports:
* #33446

💬 fanquake commented on pull request "rpc: fix getblock(header) returns target for tip":
(https://github.com/bitcoin/bitcoin/pull/33446#issuecomment-3328960336)
Backported to `29.x` in #33474.

👍 andrewtoth approved a pull request: "log: always print initial script verification state"
(https://github.com/bitcoin/bitcoin/pull/33336#pullrequestreview-3263072412)
Approach ACK.

The way this PR untangles the assumevalid conditions and explicitly logs them is great for readability and debugging. I'm not sure this should go into v30 though since it does touch a lot of consensus code.

The PR title understates quite a bit what this PR is doing. I assume since it has evolved since being initially proposed. I think it can be updated to better detail what this is doing.

💬 andrewtoth commented on pull request "log: always print initial script verification state":
(https://github.com/bitcoin/bitcoin/pull/33336#discussion_r2375948743)
nit: same, no need for "deterministically" here.

💬 andrewtoth commented on pull request "log: always print initial script verification state":
(https://github.com/bitcoin/bitcoin/pull/33336#discussion_r2375904163)
nit: I think we can remove "deterministically" here. It's implied.

💬 andrewtoth commented on pull request "log: always print initial script verification state":
(https://github.com/bitcoin/bitcoin/pull/33336#discussion_r2375961559)
Shouldn't this be `getblockcount() == 1`?

💬 andrewtoth commented on pull request "log: always print initial script verification state":
(https://github.com/bitcoin/bitcoin/pull/33336#discussion_r2376007280)
nit: for consistency "block not in assumevalid chain"