💬 fanquake commented on pull request "util/strencodings: guard SAFE_CHARS index and pre-reserve result":
(https://github.com/bitcoin/bitcoin/pull/33396#issuecomment-3297809297)
Thanks, however we can leave this code as-is.

✅ fanquake closed a pull request: "refactor: Fix typo and correct template parameter inconsistency"
(https://github.com/bitcoin/bitcoin/pull/33394)

💬 fanquake commented on pull request "refactor: Fix typo and correct template parameter inconsistency":
(https://github.com/bitcoin/bitcoin/pull/33394#issuecomment-3297824742)
Thanks, however I think this code can be left as-is for now.

💬 TheCharlatan commented on pull request "log: always print initial signature verification state":
(https://github.com/bitcoin/bitcoin/pull/33336#discussion_r2352051546)
Are the enums really only added for logging? That seems a bit heavy. How about moving this `if` block up and making it a lambda that gets called directly from your `if else` branches? afaict that could remove the need for them, which judged by the comments left here so far, seem to confuse people a bit with their communicated intent.

💬 TheCharlatan commented on pull request "log: always print initial signature verification state":
(https://github.com/bitcoin/bitcoin/pull/33336#discussion_r2351814133)
I'm a bit confused what the condition in this test is supposed to trigger if all we are testing are invalid args. What is the rationale here?

👍 hodlinator approved a pull request: "Remove unnecessary casts when calling socket operations"
(https://github.com/bitcoin/bitcoin/pull/33378#pullrequestreview-3229478311)
ACK 67f632b6deb8b4aa190c458b71d2bc8c793626d5

(PR description still ends with "Opening as a draft for now to test CI on supported platforms.")

📝 willcl-ark opened a pull request: "WIP: Backport Cirrus runners to 29.x"
(https://github.com/bitcoin/bitcoin/pull/33403)
Backports #32989 to the 29.x branch

💬 hodlinator commented on pull request "coins: warn on oversized `-dbcache`":
(https://github.com/bitcoin/bitcoin/pull/33333#discussion_r2352176441)
Yeah, now that you use `InitWarning()` adjacently, it's clearer why we would expect true.

👍 hodlinator approved a pull request: "coins: warn on oversized `-dbcache`"
(https://github.com/bitcoin/bitcoin/pull/33333#pullrequestreview-3229526417)
ACK 13fa0d0a433722f294854001b0561c079db12dbc

Very helpful to warn users against unintentionally making their system start swapping insanely.

💬 fanquake commented on issue "Default ASmap file path is not used unless -asmap is set":
(https://github.com/bitcoin/bitcoin/issues/33386#issuecomment-3298250998)
@fjahr

⚠️ mstampfer opened an issue: "Add zsh completion scripts for Bitcoin Core command-line tools"
(https://github.com/bitcoin/bitcoin/issues/33404)
### Please describe the feature you'd like to see added.

Bitcoin Core currently provides bash completion scripts for `bitcoin-cli`, `bitcoin-tx`, and `bitcoind` in `contrib/completions/bash/`, and similarly, fish completion scripts are available in `contrib/completions/fish/`, but there are no equivalent completion scripts for zsh users. Many developers and users have adopted zsh as their default shell (especially Mac OSX users and with tools like Oh My Zsh), and they cannot benefit from tab co
...

⚠️ deyvid61 opened an issue: "Gj"
(https://github.com/bitcoin/bitcoin/issues/33405)

../ test.rc1/ 28-Jul-2025 19:01 - test.rc2/ 28-Aug-2025 17:38 - SHA256SUMS 04-Sep-2025 17:36 2956 SHA256SUMS.asc 04-Sep-2025 17:36 9968 SHA256SUMS.ots 04-Sep-2025 17:37 422 bitcoin-29.1-aarch64-linux-gnu-debug.tar.gz 04-Sep-2025 17:36 464841495 bitcoin-29.1-aarch64-linux-gnu.tar.gz 04-Sep-2025 17:36 47955246 bitcoin-29.1-arm-linux-gnueabihf-debug.tar.gz 04-Sep-2025 17:36 467016379 bitcoin-29.1-arm-linux-gnueabihf.tar.gz 04-Sep-2025 17:36 44510860 bitcoin-29.1-arm64-apple-darwin-codesigning.tar.
...

💬 deyvid61 commented on issue "Gj":
(https://github.com/bitcoin/bitcoin/issues/33405#issuecomment-3298347665)
Deyvid61

✅ deyvid61 closed an issue: "Gj"
(https://github.com/bitcoin/bitcoin/issues/33405)

⚠️ deyvid61 reopened an issue: "Gj"
(https://github.com/bitcoin/bitcoin/issues/33405)

../ test.rc1/ 28-Jul-2025 19:01 - test.rc2/ 28-Aug-2025 17:38 - SHA256SUMS 04-Sep-2025 17:36 2956 SHA256SUMS.asc 04-Sep-2025 17:36 9968 SHA256SUMS.ots 04-Sep-2025 17:37 422 bitcoin-29.1-aarch64-linux-gnu-debug.tar.gz 04-Sep-2025 17:36 464841495 bitcoin-29.1-aarch64-linux-gnu.tar.gz 04-Sep-2025 17:36 47955246 bitcoin-29.1-arm-linux-gnueabihf-debug.tar.gz 04-Sep-2025 17:36 467016379 bitcoin-29.1-arm-linux-gnueabihf.tar.gz 04-Sep-2025 17:36 44510860 bitcoin-29.1-arm64-apple-darwin-codesigning.tar.
...

✅ pinheadmz closed an issue: "Gj"
(https://github.com/bitcoin/bitcoin/issues/33405)

💬 martinatime commented on issue "bitcoind 29.0 much slower than 28.0 on my system: cause found":
(https://github.com/bitcoin/bitcoin/issues/32455#issuecomment-3298613116)
Another update. I decided to run a test by using the same setup as I mentioned above but a new (yet slower) USB SSD connected to my RPi via a powered USB hub and I redid the IBD. This time it took approximately six days. The OS was run off of the initial USB SSD which was directly attached to the RPI. So maybe the issue is I/O contention either at the USB Bus level or within the OS (RaspOS/Debian Bookworm). At this time I'm going to stop looking into this. Cheers all!

💬 pinheadmz commented on pull request "Remove unnecessary casts when calling socket operations":
(https://github.com/bitcoin/bitcoin/pull/33378#issuecomment-3298628111)
Thanks for the edit @fanquake 🥰

👍 vasild approved a pull request: "Remove unnecessary casts when calling socket operations"
(https://github.com/bitcoin/bitcoin/pull/33378#pullrequestreview-3229896344)
ACK 67f632b6deb8b4aa190c458b71d2bc8c793626d5

📝 willcl-ark opened a pull request: "WIP: Backport Cirrus runners to 28.x"
(https://github.com/bitcoin/bitcoin/pull/33406)
Backports https://github.com/bitcoin/bitcoin/pull/32989 to the 28.x branch