💬 wangtao19911111 commented on issue "configure: error: cannot figure out how to use std::filesystem":
(https://github.com/bitcoin/bitcoin/issues/27148#issuecomment-1569745093)
> > This is the relevant chunk from config.log:
>
> Installing `libstdc++-8-dev` will solve the problem.

how to install this lib？

👋 TheCharlatan's pull request is ready for review: "kernel: Remove shutdown from kernel library"
(https://github.com/bitcoin/bitcoin/pull/27711)

🚀 fanquake merged a pull request: "ci: Prune dangling images on RESTART_CI_DOCKER_BEFORE_RUN"
(https://github.com/bitcoin/bitcoin/pull/27777)

💬 fanquake commented on pull request "ci, iwyu: Update mappings":
(https://github.com/bitcoin/bitcoin/pull/27710#issuecomment-1569792756)
> Addressed @fanquake's https://github.com/bitcoin/bitcoin/pull/27710#discussion_r1210341923.

I don't see how this is addressed, looks like it's now just producing include suggestions that are incorrect/we don't want for the test code.

✅ fanquake closed an issue: "rpc_getblockfrompeer.py intermittent failure: assert_equal(pruneheight, 248); not(249 == 248)"
(https://github.com/bitcoin/bitcoin/issues/27749)

🚀 fanquake merged a pull request: "test: fix intermittent error in getblockfrompeer.py"
(https://github.com/bitcoin/bitcoin/pull/27784)

💬 hebasto commented on pull request "ci, iwyu: Update mappings":
(https://github.com/bitcoin/bitcoin/pull/27710#issuecomment-1569886912)
@fanquake
> ... looks like it's now just producing include suggestions that are incorrect/we don't want for the test code.

Can you point out these suggestions please? Asking because I've just skimmed suggestions for `test/*_tests.cpp` files again and I can see none of them in comparison to the master branch.

👍 dergoegge approved a pull request: "fuzz: Avoid timeout in utxo_total_supply"
(https://github.com/bitcoin/bitcoin/pull/27780#pullrequestreview-1452773063)
ACK fafb4da121b19ba1b7bd173e25651c64d1982fb4

Verified that the target still finds the CVE with the patch applied.

🚀 fanquake merged a pull request: "fuzz: fix wallet notifications.cpp"
(https://github.com/bitcoin/bitcoin/pull/27786)

👍 dergoegge approved a pull request: "doc: Remove unused NO_BLOOM_VERSION constant"
(https://github.com/bitcoin/bitcoin/pull/27657#pullrequestreview-1452792101)
ACK facbcd3742313625137907276628267ad90eee01

💬 willcl-ark commented on issue "bitcoind hangs waiting for `g_requests.empty()`":
(https://github.com/bitcoin/bitcoin/issues/27722#issuecomment-1569922589)
> @willcl-ark can you find what libevent version you're using?

I am using libevent 2.1.12 (like TheStack)

🚀 fanquake merged a pull request: "fuzz: Avoid timeout in utxo_total_supply"
(https://github.com/bitcoin/bitcoin/pull/27780)

💬 alexanderwiederin commented on pull request "assumeutxo (2)":
(https://github.com/bitcoin/bitcoin/pull/27596#discussion_r1211504043)
@jamesob line 1 (`#!/usr/bin/env bash`) sets the interpreter to Bash regardless of what the system default is.

@MarcoFalke you were right! macOS comes with an outdated version of bash (`3.2.57`). I have updated to `5.2.15`. Script runs like a charm now.

Thanks for the help!

🚀 fanquake merged a pull request: "doc: Remove unused NO_BLOOM_VERSION constant"
(https://github.com/bitcoin/bitcoin/pull/27657)

📝 stickies-v opened a pull request: "ci: label docker images and prune dangling images selectively"
(https://github.com/bitcoin/bitcoin/pull/27793)
Follow-up from https://github.com/bitcoin/bitcoin/pull/27777#discussion_r1210209382.

Labeling the docker images produced by the CI allows us/the user to apply batch operations to all images (including dangling ones) produced by the ci without affecting other, non-bitcoin-ci images. With labeling, we can safely always prune dangling bitcoin-ci-test images without checking for `RESTART_CI_DOCKER_BEFORE_RUN`, which we enable on our persistent runners.

💬 stickies-v commented on pull request "ci: Prune dangling images on RESTART_CI_DOCKER_BEFORE_RUN":
(https://github.com/bitcoin/bitcoin/pull/27777#discussion_r1211510058)
Done in https://github.com/bitcoin/bitcoin/pull/27793

💬 MarcoFalke commented on issue "configure: error: cannot figure out how to use std::filesystem":
(https://github.com/bitcoin/bitcoin/issues/27148#issuecomment-1569969718)
@wangtao19911111 The minimum required version is installed by default with `g++`, if you use the latest LTS release of your operating system.

⚠️ torkelrogstad opened an issue: "Indicate RBF replaceability, also after transactions have been confirmed "
(https://github.com/bitcoin/bitcoin/issues/27794)
### Please describe the feature you'd like to see added.

Wallet transactions retrieved with RPC should indicate RBF replaceability, also after they are confirmed.

### Is your feature related to a problem, if so please describe it.

Currently, RBF replaceability is set to a hard 'no' if the transaction has any confirmations:

https://github.com/bitcoin/bitcoin/blob/30d6c7d8c0441956fac37252921c795569002d07/src/wallet/rpc/transactions.cpp#L46-L55

This makes it hard to figure out if this tra
...

🤔 jonatack reviewed a pull request: "rpc: remove deprecated "warning" field from {create,load,restore,unload}wallet"
(https://github.com/bitcoin/bitcoin/pull/27757#pullrequestreview-1452883500)
Approach ACK. Did this a few weeks back in https://github.com/bitcoin/bitcoin/compare/master...jonatack:bitcoin:2023-05-remove-deprecated-warning-fields and the diff is the same except as where noted below. Feel free to pull in 39f14968b6f6dd6151f4fbb05c8fe385cff9a15e in that branch if you think it's worthwhile.

💬 jonatack commented on pull request "rpc: remove deprecated "warning" field from {create,load,restore,unload}wallet":
(https://github.com/bitcoin/bitcoin/pull/27757#discussion_r1211528780)
Suggestions/fixups

- s/can be accessed/is provided/

- missing comma before "which"

- perhaps mention when the "warnings" field was added

```suggestion
accessed with the "warnings" field added in v25.0, which returns a JSON array of strings.
```

s/single string field/"warning" string field/ seems clearer