💬 Eunovo commented on pull request "Silent Payments: Receiving":
(https://github.com/bitcoin/bitcoin/pull/32966#discussion_r2281690340)
Done

💬 Eunovo commented on pull request "Silent Payments: Receiving":
(https://github.com/bitcoin/bitcoin/pull/32966#discussion_r2281694874)
Done

💬 Eunovo commented on pull request "Silent Payments: Receiving":
(https://github.com/bitcoin/bitcoin/pull/32966#discussion_r2281695254)
Done

💬 hebasto commented on pull request "cmake: Introduce translate.cmake script for translate target":
(https://github.com/bitcoin/bitcoin/pull/33200#discussion_r2281712264)
> Define Everywhere?

This project codebase.

💬 hebasto commented on pull request "cmake: Introduce translate.cmake script for translate target":
(https://github.com/bitcoin/bitcoin/pull/33200#discussion_r2281715450)
I'm not arguing which style is better, but asking for the sake of consistency.

🤔 janb84 reviewed a pull request: "docs: clarify RPC credentials security boundary"
(https://github.com/bitcoin/bitcoin/pull/33196#pullrequestreview-3127467726)
ACK 433954b6a5bd7480f7e05e58eafeac1dc6dfae7c

This PR adds information about security considerations when using RPC clients. Although bitcoin-core has done everything to minimise the risks of using RPC, it's good to inform the user of the risks and the extra security precautions the user can take.

Informing the public about security risks and methods to mitigate them demonstrates responsible stewardship; therefore, I support this pull request.

💬 fanquake commented on pull request "guix: update time-machine to 5cb84f2013c5b1e48a7d0e617032266f1e6059e2":
(https://github.com/bitcoin/bitcoin/pull/33185#discussion_r2281850167)
Added.

💬 maflcko commented on issue "Internal bug detected: FinalizeAndExtractPSBT(psbtx_copy, mtx)":
(https://github.com/bitcoin/bitcoin/issues/32849#issuecomment-3196073403)
Found a smaller reproducer: `descriptorprocesspsbt cHNidP8BADwAAAAAAXNjcmlwdG9ycHJvCQkJCQkJCQkJESd0fWF3DQ0FcjBwdGlvbgAAAAEIATABAAB5ACkAADEjCmwAAQcBAAAA '["raw(14)"]'`

Or the `rpc` fuzz target reproducer:

```
echo 'ZGVzY3JpcHRvcnByb2Nlc3Nwc2J0XFRwc2J0/wEAPAAAAAABc2NyaXB0b3Jwcm8JCQkJCQkJCQkR
J3R9YXcNDQVyMHB0aW9uAAAAAQgBMAEAAHkAKQAAMSMKbAABBwEAAABc/HJhdygxNCkAJ3R9YXcN
DQVyMA==' | base64 --decode > /tmp/fuzz.crash

FUZZ=rpc ./bld-cmake/bin/fuzz /tmp/fuzz.crash

💬 Galoretka commented on pull request "doc: add Linux GUI runtime instructions to doc/README.md":
(https://github.com/bitcoin/bitcoin/pull/33197#issuecomment-3196109913)
> Please squash your commits according to https://github.com/bitcoin/bitcoin/blob/master/CONTRIBUTING.md#squashing-commits

squashed

💬 Galoretka commented on pull request "doc: add Linux GUI runtime instructions to doc/README.md":
(https://github.com/bitcoin/bitcoin/pull/33197#discussion_r2282011086)
> the minimum required is 6.2? Why is this duplicated here at all?

really, removed copying

💬 hebasto commented on something "":
(https://github.com/bitcoin/bitcoin/commit/d5054beca50f992dc63dc596f0aff457eb9d217f#commitcomment-164149256)
Suggesting a few cahnages:
```diff
--- a/share/qt/translate.cmake
+++ b/share/qt/translate.cmake
@@ -9,7 +9,6 @@ set(input_variables
COPYRIGHT_HOLDERS
LCONVERT_EXECUTABLE
LUPDATE_EXECUTABLE
- PYTHON_EXECUTABLE
XGETTEXT_EXECUTABLE
)

@@ -29,28 +28,24 @@ function(extract_strings output)
--from-code=utf-8
--keyword=_
${ARGN}
- OUTPUT_VARIABLE text
COMMAND_ERROR_IS_FATAL ANY
)

- set(messages)
- set(msgid)
+ set(messages "")
+
...

💬 maflcko commented on pull request "doc: add Linux GUI runtime instructions to doc/README.md":
(https://github.com/bitcoin/bitcoin/pull/33197#discussion_r2282036850)
is the goal of this change to fix the issue?

💬 maflcko commented on pull request "cmake: Do not require Python to build GUI":
(https://github.com/bitcoin/bitcoin/pull/33156#issuecomment-3196146326)
> Add to the 30.0 milestone?

This one or https://github.com/bitcoin/bitcoin/pull/33200?

👍 hebasto approved a pull request: "cmake: Introduce translate.cmake script for translate target"
(https://github.com/bitcoin/bitcoin/pull/33200#pullrequestreview-3127870644)
ACK 05255d5d1ec1852d8d8d7683ccbf28351f57b89e.

🚀 hebasto merged a pull request: "cmake: Introduce translate.cmake script for translate target"
(https://github.com/bitcoin/bitcoin/pull/33200)

💬 fanquake commented on pull request "cmake: Introduce translate.cmake script for translate target":
(https://github.com/bitcoin/bitcoin/pull/33200#issuecomment-3196172145)
Would have been good to update the PR description before merge? It says "As a follow up, the dependency on sed may be removed ..." but it looks like that was done here?

💬 hebasto commented on pull request "cmake: Do not require Python to build GUI":
(https://github.com/bitcoin/bitcoin/pull/33156#issuecomment-3196203274)
> > Add to the 30.0 milestone?
>
> This one or #33200?

#33200 doesn't solve the issue. But @purpleKarrot has a working branch on top of it that replaces Python code with pure CMake code.

📝 purpleKarrot opened a pull request: "cmake: Drop python dependency for translate"
(https://github.com/bitcoin/bitcoin/pull/33209)
Translate the `share/qt/extract_strings_qt.py` script to CMake. This removes the python dependency from the `translate` target.

💬 purpleKarrot commented on pull request "cmake: Do not require Python to build GUI":
(https://github.com/bitcoin/bitcoin/pull/33156#issuecomment-3196219744)
This removes the Python dependency: https://github.com/bitcoin/bitcoin/pull/33209

👋 hebasto's pull request is ready for review: "Release: Prepare "Translation string freeze" step"
(https://github.com/bitcoin/bitcoin/pull/33193)