💬 maflcko commented on pull request "ci: remove `ninja-build` from MSAN jobs":
(https://github.com/bitcoin/bitcoin/pull/33100#issuecomment-3136606083)
review ACK cab6736b701f203d6e823e1b5d619368d8d4c5e0 🕸

<details><summary>Show signature</summary>

Signature:

```
untrusted comment: signature from minisign secret key on empty file; verify via: minisign -Vm "${path_to_any_empty_file}" -P RWTRmVTMeKV5noAMqVlsMugDDCyyTSbA3Re5AkUrhvLVln0tSaFWglOw -x "${path_to_this_whole_four_line_signature_blob}"
RUTRmVTMeKV5npGrKx1nqXCw5zeVHdtdYURB/KlyA/LMFgpNCs+SkW9a8N95d+U4AP1RJMi+krxU1A3Yux4bpwZNLvVBKy0wLgM=
trusted comment: review ACK cab6736b701f
...

💬 glozow commented on pull request "truc: optimize the in package relation calculation":
(https://github.com/bitcoin/bitcoin/pull/33062#discussion_r2242902876)
fwiw I don't think this needs to be direct parents, it's just implemented this way because the limit is 2.

As a more general note - thanks for working on this and I don't want to be discouraging, but I'm not sure that a marginal improvement to this small function is worth this much effort. I see you have some other PRs that might be more impactful, so maybe focus on those? Maybe we can come back to this in the future if it helps with other things.

💬 fanquake commented on pull request "ci: allow for any libc++ intrumentation & use it for TSAN":
(https://github.com/bitcoin/bitcoin/pull/33099#discussion_r2242908387)
Fixed the space and `export`.

🚀 fanquake merged a pull request: "[28.x] Backports"
(https://github.com/bitcoin/bitcoin/pull/33076)

💬 HowHsu commented on pull request "truc: optimize the in package relation calculation":
(https://github.com/bitcoin/bitcoin/pull/33062#discussion_r2242962745)
> fwiw I don't think this needs to be direct parents, it's just implemented this way because the limit is 2.
>
> As a more general note - thanks for working on this and I don't want to be discouraging, but I'm not sure that a marginal improvement to this small function is worth this much effort. I see you have some other PRs that might be more impactful, so maybe focus on those? Maybe we can come back to this in the future if it helps with other things.

Sure, thanks.

💬 fanquake commented on issue "ci: failure in wallet_migration.py":
(https://github.com/bitcoin/bitcoin/issues/33096#issuecomment-3136793717)
https://cirrus-ci.com/task/5410514727075840?logs=ci#L1549

💬 willcl-ark commented on issue "ci: failure in wallet_migration.py":
(https://github.com/bitcoin/bitcoin/issues/33096#issuecomment-3136797995)
Should the PR be reverted while being fixed? It's causing a lot of intermittent failures...

💬 fanquake commented on pull request "ci: remove `ninja-build` from MSAN jobs":
(https://github.com/bitcoin/bitcoin/pull/33100#issuecomment-3136823569)
CI failure here is #33096.

🚀 fanquake merged a pull request: "ci: remove `ninja-build` from MSAN jobs"
(https://github.com/bitcoin/bitcoin/pull/33100)

📝 Christewart opened a pull request: "2025 07 30 Add release note for `dumptxoutset` breaking change"
(https://github.com/bitcoin/bitcoin/pull/33103)
See discussion here: https://github.com/bitcoin/bitcoin/pull/30808#issuecomment-3134394012

💬 fanquake commented on pull request "2025 07 30 Add release note for `dumptxoutset` breaking change":
(https://github.com/bitcoin/bitcoin/pull/33103#issuecomment-3136883422)
Thanks. Given this was missed in the 29.0 release notes, it seems like it should be added to the 29.1 release notes. In that case, I'll roll this into #33074.

🤔 LarryRuane reviewed a pull request: "test: revive test verifying that `GetCoinsCacheSizeState` switches from OK→LARGE→CRITICAL"
(https://github.com/bitcoin/bitcoin/pull/33021#pullrequestreview-3072248406)
ACK 554befd8738ea993b3b555e7366558a9c32c915c

✅ fanquake closed a pull request: "2025 07 30 Add release note for `dumptxoutset` breaking change"
(https://github.com/bitcoin/bitcoin/pull/33103)

💬 fanquake commented on pull request "2025 07 30 Add release note for `dumptxoutset` breaking change":
(https://github.com/bitcoin/bitcoin/pull/33103#issuecomment-3136909792)
See https://github.com/bitcoin/bitcoin/pull/33074/commits/264418f80cea7fd5ae818a2a2887fab62de2b0a2 in #33074.

💬 fanquake commented on pull request "cmake: Proactively avoid use of `SECP256K1_DISABLE_SHARED`":
(https://github.com/bitcoin/bitcoin/pull/33101#issuecomment-3136918668)
cc @theuni @purpleKarrot

👋 ishaanam's pull request is ready for review: "wallet, rpc: add v3 transaction creation and wallet support"
(https://github.com/bitcoin/bitcoin/pull/32896)

💬 ishaanam commented on pull request "wallet, rpc: add v3 transaction creation and wallet support":
(https://github.com/bitcoin/bitcoin/pull/32896#issuecomment-3136976112)
I have added more tests and this PR is ready for review.

👍 willcl-ark approved a pull request: "ci: Only pass documented env vars"
(https://github.com/bitcoin/bitcoin/pull/33002#pullrequestreview-3072361931)
ACK 3333d3f75f8917cf8c183984e9b81e2d7a447ca5

Seems reasonable to only export documented vars into the container.

I tried to think if there was a "cleaner" way to do this without creating a new file, but couldn't think of anything so maintainable as this simple python.

💬 maflcko commented on pull request "ci: allow for any libc++ intrumentation & use it for TSAN":
(https://github.com/bitcoin/bitcoin/pull/33099#issuecomment-3137022944)
Looks like the flags are correctly picked up: https://cirrus-ci.com/task/6536414633918464?logs=ci#L4866

`[10:46:11.059] C++ compiler flags .................... -fsanitize=thread -nostdinc++ -nostdlib++ -isystem /cxx_build/include/c++/v1 -L/cxx_build/lib -Wl,-rpath,/cxx_build/lib -lc++ -lc++abi -lpthread -Wno-unused-command-line-argument -O2 -g -std=c++20 -fPIC -fdebug-prefix-map=/ci_container_base/src=. -fmacro-prefix-map=/ci_container_base/src=. -U_FORTIFY_SOURCE -D_FORTIFY_SOURCE=3 -Wstack-
...

💬 achow101 commented on issue "ci: failure in wallet_migration.py":
(https://github.com/bitcoin/bitcoin/issues/33096#issuecomment-3137168459)
I should have a fix in a few minutes.