Bitcoin Core Github
44 subscribers
121K links
Download Telegram
πŸ’¬ 1440000bytes commented on pull request "Reduce minrelaytxfee to 100 sats/kvB":
(https://github.com/bitcoin/bitcoin/pull/32959#issuecomment-3132966314)
> Since similar arguments keep coming up: The sole purpose of the minimum relay fee should be DoS protection. Trying to fix the security budget by imposing administered prices on block space seems misguidedβ€”market forces will likely circumvent such price controls and make things worse in the process.

This does make it easier for an attacker to use bitcoin p2p as messaging layer. Malwares already use [DNS TXT records](https://dti.domaintools.com/malware-in-dns/) for it although bitcoin p2p wou
...
πŸ’¬ TheCharlatan commented on pull request "kernel: create monolithic kernel static library":
(https://github.com/bitcoin/bitcoin/pull/33077#issuecomment-3132971911)
> But if we want to make sure that 3rd parties use a deterministically built kernel, we either need to force them to use a dynamic library or to build their application inside the same deterministic build environment.

I don't think we should force anything. If we try to, people will find worse ways to get around this limitation, e.g. by manually picking source files out of the repository and creating the library that way (which they did for libbitcoinconsensus). That said, releasing a shared
...
πŸ’¬ ryanofsky commented on pull request "kernel: create monolithic kernel static library":
(https://github.com/bitcoin/bitcoin/pull/33077#issuecomment-3132978479)
> **We cannot provide packages that contain static libraries and/or `.pc` files.**

Oh, that makes sense to me. I thought you might have been objecting to having code in the build system that generates .pc files. But I agree distributing .pc files with precompiled static libraries does not seem like it would be very useful, and I assume most developers would just compile from source. Would be interested to know more if this is incorrect and anyone is asking for static binaries or would find th
...
⚠️ mraassina34 opened an issue: "PROFESSIONAL BITCOIN RECOVERY EXPERT META TECH RECOVERY PRO"
(https://github.com/bitcoin/bitcoin/issues/33089)
### Please describe the feature you'd like to see added.

I am Mel Raassina, an Australian citizen. I am recounting my ordeal in the hopes of preventing others from becoming victims of crypto investment fraud. A few months ago, I was ensnared by a deceptive crypto investment scheme connected to a brokerage firm. I had made a substantial investment when Bitcoin prices were appreciating, believing it to be a sound venture. Regrettably, I was defrauded of AUD 420,000, and the broker subsequently bl
...
πŸ’¬ fanquake commented on pull request "ci: limit max stack size to 512 KiB":
(https://github.com/bitcoin/bitcoin/pull/33079#discussion_r2240182138)
Given it's in miniscript tests, I'm assuming it was "fixed" in the same refactor as msan. Will check in any case.
βœ… fanquake closed an issue: "PROFESSIONAL BITCOIN RECOVERY EXPERT META TECH RECOVERY PRO"
(https://github.com/bitcoin/bitcoin/issues/33089)
πŸ’¬ sipa commented on pull request "Reduce minrelaytxfee to 100 sats/kvB":
(https://github.com/bitcoin/bitcoin/pull/32959#issuecomment-3132991908)
Concept ACK.
πŸ’¬ fanquake commented on pull request "doc: move `cmake -B build -LH` up in Unix build docs":
(https://github.com/bitcoin/bitcoin/pull/33088#issuecomment-3132995620)
@stickies-v might follow up with any Windows doc changes.
πŸš€ fanquake merged a pull request: "doc: move `cmake -B build -LH` up in Unix build docs"
(https://github.com/bitcoin/bitcoin/pull/33088)
βœ… fanquake closed an issue: "ci: Lower and unify default stack size"
(https://github.com/bitcoin/bitcoin/issues/29840)
πŸš€ fanquake merged a pull request: "ci: limit max stack size to 512 KiB"
(https://github.com/bitcoin/bitcoin/pull/33079)
πŸ‘ fanquake approved a pull request: "guix: warn SOURCE_DATE_EPOCH set in guix-codesign"
(https://github.com/bitcoin/bitcoin/pull/33073#pullrequestreview-3068095587)
ACK 1bed0f734b3f2dd876193b5cad303bfab1d250d5
πŸ’¬ willcl-ark commented on pull request "Migrate CI to hosted Cirrus Runners":
(https://github.com/bitcoin/bitcoin/pull/32989#issuecomment-3133043442)
> This means the code was [953c90d](https://github.com/bitcoin/bitcoin/commit/953c90d7649c076e6e43418f50c33b3ae5f82608) vs [3219847](https://github.com/bitcoin/bitcoin/commit/321984705dbcc5982013c8cfb52389cf3f2e75f6)

Dang, I must have rebased on upstream/master (out of habit) to drop that top commit. Thanks for catching.
πŸš€ fanquake merged a pull request: "guix: warn SOURCE_DATE_EPOCH set in guix-codesign"
(https://github.com/bitcoin/bitcoin/pull/33073)
πŸ’¬ fanquake commented on pull request "guix: warn SOURCE_DATE_EPOCH set in guix-codesign":
(https://github.com/bitcoin/bitcoin/pull/33073#issuecomment-3133068173)
Backported to `29.x` in #33074.
πŸ’¬ furszy commented on pull request "index: initial sync speedup, parallelize process":
(https://github.com/bitcoin/bitcoin/pull/26966#discussion_r2240255267)
> [b360102](https://github.com/bitcoin/bitcoin/commit/b36010261921adc74e61bdcbc91ba6b7778bad9a)
>
> Wonder if it should be specified that threadpool is **shared** among all indexers (that support multithreading)

Done as suggested.
πŸ’¬ fanquake commented on pull request "guix: warn SOURCE_DATE_EPOCH set in guix-codesign":
(https://github.com/bitcoin/bitcoin/pull/33073#issuecomment-3133128929)
Backported to `28.x` in #33076.
πŸ€” glozow reviewed a pull request: "wallet, rpc: add anti-fee-sniping to `send` and `sendall`"
(https://github.com/bitcoin/bitcoin/pull/28944#pullrequestreview-3068216620)
ACK aac0b6dd79b0db1e9d42a6f466709a61cfd1f69f
πŸ’¬ darosior commented on pull request "Reduce minrelaytxfee to 100 sats/kvB":
(https://github.com/bitcoin/bitcoin/pull/32959#issuecomment-3133154267)
@delta1 i would suggest picking up https://github.com/bitcoin/bitcoin/pull/13990 and https://github.com/bitcoin/bitcoin/pull/13922. In this order, or make a good argument why it would be fine to lower the settings without first making the fee estimation work be compatible.

Feel free to ping me for review, i think this is important it makes it into the next release. I'm managing expectations however since, as it's been pointed out multiple times already, this is a lot less trivial than some pe
...
πŸš€ glozow merged a pull request: "wallet, rpc: add anti-fee-sniping to `send` and `sendall`"
(https://github.com/bitcoin/bitcoin/pull/28944)