💬 instagibbs commented on pull request "cluster mempool: add TxGraph work controls":
(https://github.com/bitcoin/bitcoin/pull/32263#discussion_r2198606359)
comment below says

"// Make the graph linearize all clusters acceptably."

I'm guessing these chains are trivial to linearize, so this was likely already achieved with 10k iterations?

💬 instagibbs commented on pull request "cluster mempool: add TxGraph work controls":
(https://github.com/bitcoin/bitcoin/pull/32263#discussion_r2198615257)
```Suggestion
* steps will be performed per cluster before it is considered to be of acceptable quality. */
```

💬 instagibbs commented on pull request "cluster mempool: add TxGraph work controls":
(https://github.com/bitcoin/bitcoin/pull/32263#discussion_r2198669205)
double-checking: NEEDS_RELINEARIZE, ACCEPTABLE and OPTIMAL are the only possible cases here, right?

💬 instagibbs commented on pull request "p2p: improve TxOrphanage denial of service bounds":
(https://github.com/bitcoin/bitcoin/pull/31829#discussion_r2198682795)
in case this seems more straight forward to understand
```suggestion
// are wtxid which were already reconsiderable for some peer due to a previous AddChildrenToWorkSet().
```

🤔 w0xlt reviewed a pull request: "rest/rpc: use more util::Join"
(https://github.com/bitcoin/bitcoin/pull/32942#pullrequestreview-3007283767)
Code Review ACK https://github.com/bitcoin/bitcoin/pull/32942/commits/e68a4ba976af59dfd15e3aa432e1ce80e7d21083

🤔 w0xlt reviewed a pull request: "fuzz: Add missing calls to `SetMockTime` for determinism"
(https://github.com/bitcoin/bitcoin/pull/32927#pullrequestreview-3007292861)
ACK https://github.com/bitcoin/bitcoin/pull/32927/commits/fa8862723c14cdd471bbffc7a4897ece2e6d8a7f

💬 achow101 commented on issue "guix: Zip file non-determinism when building in WSL":
(https://github.com/bitcoin/bitcoin/issues/32931#issuecomment-3059133385)
Switching to a non-ntfs drive works I guess. But it would be preferable if the build was filesystem agnostic.

💬 instagibbs commented on pull request "[WIP] Cluster mempool implementation":
(https://github.com/bitcoin/bitcoin/pull/28676#issuecomment-3059151670)
Follow-up from a while back: let's just explicitly say which layer of txgraph we're querying: https://github.com/instagibbs/bitcoin/commit/bb48f6c4736c227bcee6c4dda8e95b0b0287cfef

💬 achow101 commented on pull request "wallet: remove dead code in legacy wallet migration":
(https://github.com/bitcoin/bitcoin/pull/32758#issuecomment-3059157165)
ACK 150b5c99ca11885ef15d04139d919d734e2c211a

🚀 achow101 merged a pull request: "wallet: remove dead code in legacy wallet migration"
(https://github.com/bitcoin/bitcoin/pull/32758)

💬 achow101 commented on pull request "test: less ambiguous error if bitcoind is missing":
(https://github.com/bitcoin/bitcoin/pull/32921#issuecomment-3059204041)
ACK 83bb41455715a9e05320ba791987204031626c10

🚀 achow101 merged a pull request: "test: less ambiguous error if bitcoind is missing"
(https://github.com/bitcoin/bitcoin/pull/32921)

💬 theuni commented on pull request "depends: Force `CMAKE_EXPORT_NO_PACKAGE_REGISTRY=TRUE`":
(https://github.com/bitcoin/bitcoin/pull/32943#issuecomment-3059223967)
Yikes. Concept ACK.

> - The [export(PACKAGE)](https://cmake.org/cmake/help/latest/command/export.html#package) command does not populate the user package registry when [CMP0090](https://cmake.org/cmake/help/latest/policy/CMP0090.html#policy:CMP0090) is set to NEW unless the [CMAKE_EXPORT_PACKAGE_REGISTRY](https://cmake.org/cmake/help/latest/variable/CMAKE_EXPORT_PACKAGE_REGISTRY.html#variable:CMAKE_EXPORT_PACKAGE_REGISTRY) variable explicitly enables it. When [CMP0090](https://cmake.org/cmak
...

📝 w0xlt opened a pull request: "wallet: Remove `upgradewallet` RPC"
(https://github.com/bitcoin/bitcoin/pull/32944)
Based on discussions in https://github.com/bitcoin/bitcoin/pull/32803, this PR proposes removing the ` upgradewallet` RPC.

🤔 w0xlt reviewed a pull request: "refactor: Convert GenTxid to `std::variant`"
(https://github.com/bitcoin/bitcoin/pull/32631#pullrequestreview-3007546189)
ACK https://github.com/bitcoin/bitcoin/pull/32631/commits/a60f863d3e276534444571282f432b913d3967db

💬 1BitcoinBoWP1FZ4xwTNkq6XksKidmgYYw commented on pull request "New SVG, Icons, PNGs and X PixMaps":
(https://github.com/bitcoin-core/gui/pull/879#issuecomment-3059330260)
> Why?

Padding (not margin) has been removed because it is unnecessary and visually disruptive. Padding serves no purpose and only worsens the layout.

> Bitcoin Core has its own logo for years. I don't see your reference as a justification for this change.

I discussed this PR with @jonasschnelli on IRC a few days ago. As the creator of the original logo files, he understands the rationale behind replacing them.

> I believe this constitutes a misuse of the Bitcoin Core codebase.

This assumpt
...

💬 yancyribbens commented on pull request "FUZZ: Test that BnB finds best solution":
(https://github.com/bitcoin/bitcoin/pull/32894#issuecomment-3059542310)
I'll take a closer look at this, although some quick feedback since I've implemented something similar.

> This fuzz test compares a brute force search with the BnB result to ensure that BnB succeeds.

I recently removed a similar automated test that used brute force. The issue with using a brute solution I had was a) brute force is slow b) only works on a limited pool size of say 20 UTXOs (see a). Instead of using brute force, I adopted a strategy where I generate two random UTXO sets. T
...

🤔 pablomartin4btc reviewed a pull request: "wallet: Remove `upgradewallet` RPC"
(https://github.com/bitcoin/bitcoin/pull/32944#pullrequestreview-3008114956)
ACK 85eb29605ef4051ba23cd32e54a3d5a3ee203f6c

💬 pablomartin4btc commented on pull request "rpc, test: Fix JSON parsing errors in unloadwallet and getdescriptoractivity RPCs":
(https://github.com/bitcoin/bitcoin/pull/32845#discussion_r2199344214)
Done! Thanks!

💬 pablomartin4btc commented on pull request "rpc, test: Fix JSON parsing errors in unloadwallet and getdescriptoractivity RPCs":
(https://github.com/bitcoin/bitcoin/pull/32845#discussion_r2199345678)
Applied a very tiny tweak to it. Thanks!