📝 Mhwd9-9 opened a pull request: "Create main.yml"
(https://github.com/bitcoin/bitcoin/pull/32926)
<!--
*** Please remove the following help text before submitting: ***

Pull requests without a rationale and clear improvement may be closed
immediately.

GUI-related pull requests should be opened against
https://github.com/bitcoin-core/gui
first. See CONTRIBUTING.md
-->

<!--
Please provide clear motivation for your patch and explain how it improves
Bitcoin Core user experience or Bitcoin Core developer experience
significantly:

* Any test improvements or new tests that improv
...

💬 Mhwd9-9 commented on pull request "Create main.yml":
(https://github.com/bitcoin/bitcoin/pull/32926#issuecomment-3050994860)
از ccefe54ccd79f690192cb918ad28359b8ed574f6 دوشنبه ۱۷ سپتامبر ۲۰۰۱ ساعت ۰۰:۰۰:۰۰
از: Mhwd9-9 <152965735+Mhwd9-9@users.noreply.github.com>
تاریخ: چهارشنبه، ۹ ژوئیه ۲۰۲۵ ۰۷:۰۳:۲۱ +۰۳۳۰
موضوع: [PATCH] ایجاد main.yml

---
‎.github/workflows/main.yml | ۱ +
۱ فایل تغییر کرد، ۱ درج انجام شد(+)
ایجاد حالت ۱۰۰۶۴۴ .github/workflows/main.yml

diff --git a/.github/workflows/main.yml b/.github/workflows/main.yml
حالت فایل جدید ۱۰۰۶۴۴
فهرست ۰۰۰۰۰۰۰۰۰۰۰۰۰..۹۷۵fbec۸۲۵۶d۳
--- /dev/null
++b/.gith
...

💬 Mhwd9-9 commented on pull request "Create main.yml":
(https://github.com/bitcoin/bitcoin/pull/32926#issuecomment-3050995207)
diff --git a/.github/workflows/main.yml b/.github/workflows/main.yml
حالت فایل جدید ۱۰۰۶۴۴
فهرست ۰۰۰۰۰۰۰۰۰۰۰۰۰..۹۷۵fbec۸۲۵۶d۳
--- /dev/null
++b/.github/workflows/main.yml
@@ -0,0 +1 @@
+ی

💬 luke-jr commented on pull request "RPC/txoutproof: Support including (and verifying) proofs of wtxid":
(https://github.com/bitcoin/bitcoin/pull/32844#discussion_r2193944030)
Renamed to `gentx` (the coinbase is the input only)

👋 luke-jr's pull request is ready for review: "RPC/txoutproof: Support including (and verifying) proofs of wtxid"
(https://github.com/bitcoin/bitcoin/pull/32844)

💬 luke-jr commented on pull request "RPC/txoutproof: Support including (and verifying) proofs of wtxid":
(https://github.com/bitcoin/bitcoin/pull/32844#issuecomment-3051020524)
Reworked this to cover @SomberNight 's requirements and address feedback. Test is now passing.

💬 Mhwd9-9 commented on pull request "Create main.yml":
(https://github.com/bitcoin/bitcoin/pull/32926#issuecomment-3051026881)
من

On چهارشنبه ۹ ژوئیه ۲۰۲۵، ۷:۰۴ DrahtBot ***@***.***> wrote:

> *DrahtBot* left a comment (bitcoin/bitcoin#32926)
> <https://github.com/bitcoin/bitcoin/pull/32926#issuecomment-3050994217>
>
> The following sections might be updated with supplementary metadata
> relevant to reviewers and maintainers.
> Code Coverage & Benchmarks
>
> For details see: https://corecheck.dev/bitcoin/bitcoin/pulls/32926.
> Reviews
>
> See the guideline
> <https://github.com/bitcoin/bitcoin/blob/maste
...

✅ maflcko closed a pull request: "feature:automatically include the elapsed time in logging"
(https://github.com/bitcoin/bitcoin/pull/32925)

💬 maflcko commented on pull request "rpc, test: Fix JSON parsing errors in unloadwallet and getdescriptoractivity RPCs":
(https://github.com/bitcoin/bitcoin/pull/32845#issuecomment-3051281022)
review ACK 529d2ce24570aae426ce19e87cb22f124dd09470 🌦

<details><summary>Show signature</summary>

Signature:

```
untrusted comment: signature from minisign secret key on empty file; verify via: minisign -Vm "${path_to_any_empty_file}" -P RWTRmVTMeKV5noAMqVlsMugDDCyyTSbA3Re5AkUrhvLVln0tSaFWglOw -x "${path_to_this_whole_four_line_signature_blob}"
RUTRmVTMeKV5npGrKx1nqXCw5zeVHdtdYURB/KlyA/LMFgpNCs+SkW9a8N95d+U4AP1RJMi+krxU1A3Yux4bpwZNLvVBKy0wLgM=
trusted comment: review ACK 529d2ce24570
...

💬 maflcko commented on pull request "wallet, rpc: add v3 transaction creation and wallet support":
(https://github.com/bitcoin/bitcoin/pull/32896#discussion_r2194156945)
there's also `test/functional/feature_taproot.py:TX_MAX_STANDARD_VERSION = 3`

💬 maflcko commented on pull request "wallet, rpc: add v3 transaction creation and wallet support":
(https://github.com/bitcoin/bitcoin/pull/32896#discussion_r2194159096)
could use strprintf for shorter code? Also missing `{}` around body of the `if`?

✅ Sjors closed a pull request: "rpc: use anti-fee-sniping in send, sendall and walletcreatefundedpsbt"
(https://github.com/bitcoin/bitcoin/pull/32892)

💬 Sjors commented on pull request "rpc: use anti-fee-sniping in send, sendall and walletcreatefundedpsbt":
(https://github.com/bitcoin/bitcoin/pull/32892#issuecomment-3051457537)
Ok, so #28944 uses a completely different approach. It already has a lot of review, so I'll add mine there.

💬 Sjors commented on pull request "wallet, rpc: add anti-fee-sniping to `send` and `sendall`":
(https://github.com/bitcoin/bitcoin/pull/28944#issuecomment-3051460115)
Concept ACK. Discovered this after I tried to implement it myself in #32892 :-)

💬 Evoneem commented on pull request "rpc: use anti-fee-sniping in send, sendall and walletcreatefundedpsbt":
(https://github.com/bitcoin/bitcoin/pull/32892#discussion_r2194341665)
Anti free sniping on future merging please

🤔 Evoneem reviewed a pull request: "rpc: use anti-fee-sniping in send, sendall and walletcreatefundedpsbt"
(https://github.com/bitcoin/bitcoin/pull/32892#pullrequestreview-3000475960)
Anti free sniping on merges

💬 fanquake commented on pull request "depends: fix libevent `_WIN32_WINNT` usage":
(https://github.com/bitcoin/bitcoin/pull/32837#issuecomment-3051653595)
Guix Build:
```bash
1057d4ff8082f78c85f283799c8ccd35096aa69600b5b655746b0c61b5511266 guix-build-2f51b7c5d61d/output/aarch64-linux-gnu/SHA256SUMS.part
17365752cefaec8fa2b46d8065d458d8c15bebd16dea79240ba082d837c1af04 guix-build-2f51b7c5d61d/output/aarch64-linux-gnu/bitcoin-2f51b7c5d61d-aarch64-linux-gnu-debug.tar.gz
762a75e7c752855a2e099a662e5d8cfdebebeacb35f1ab86a831e3310082f761 guix-build-2f51b7c5d61d/output/aarch64-linux-gnu/bitcoin-2f51b7c5d61d-aarch64-linux-gnu.tar.gz
51cfb4cc939d2530
...

💬 fanquake commented on pull request "cmake: Use `AUTHOR_WARNING` for warnings":
(https://github.com/bitcoin/bitcoin/pull/32865#issuecomment-3051783625)
@ryanofsky Yea, it's a shame CMake doesn't have something built in to do this. I think this change, while not perfect, is better than the current state of having our own warning handling (where warnings are still easily missed (#31476), we have no option to turn them into errors, and someone still needs to pass `-Wdev` to get CMake warnings turned into errors). As well as the alternatives of, just adding even more options to the build system (#31669) which doesn't actually fix the issue generica
...

💬 maflcko commented on pull request "cmake: Use `AUTHOR_WARNING` for warnings":
(https://github.com/bitcoin/bitcoin/pull/32865#discussion_r2194479995)
> Reintroducing this block + your patch will only do something if we also reintroduce the custom warning handling (`configure_warnings`

Yes, that was my suggestion: Replace the commit with a trivial one-line patch.

💬 purpleKarrot commented on pull request "cmake: Use `AUTHOR_WARNING` for warnings":
(https://github.com/bitcoin/bitcoin/pull/32865#issuecomment-3051831634)
@fanquake, what exactly would fix the issue upstream? A generic `-Werror` option (without the `=` part) that simply turns all warnings into errors?