👍 vasild approved a pull request: "rpc: use CScheduler for HTTPRPCTimer"
(https://github.com/bitcoin/bitcoin/pull/32796#pullrequestreview-2956960446)
ACK e70c2087b00f6cfe1a95e9d82e8cb7e01b7f7675

Would be nice to take https://github.com/bitcoin/bitcoin/pull/32796#discussion_r2165986820

🤔 janb84 reviewed a pull request: "rpc: Distinguish between vsize and sigop adjusted mempool vsize"
(https://github.com/bitcoin/bitcoin/pull/32800#pullrequestreview-2956925945)
A few comments / NITs on the documentation side of this PR.

💬 janb84 commented on pull request "rpc: Distinguish between vsize and sigop adjusted mempool vsize":
(https://github.com/bitcoin/bitcoin/pull/32800#discussion_r2165976679)
Shouldn't this file also be referenced in the README.md located in this directory ?
```
This documentation is not an exhaustive list of all policy rules.

- [Mempool Limits](mempool-limits.md)
- [Mempool Replacements](mempool-replacements.md)
- [Packages](packages.md)
```

💬 janb84 commented on pull request "rpc: Distinguish between vsize and sigop adjusted mempool vsize":
(https://github.com/bitcoin/bitcoin/pull/32800#discussion_r2165967954)
This feels to me more as a PR comment than something that belongs in this documentation.

👍 l0rinc approved a pull request: "miniscript refactor: Remove unique_ptr-indirection (#30866 follow-up)"
(https://github.com/bitcoin/bitcoin/pull/31713#pullrequestreview-2956921144)
Code review ACK f22f4f75e252e4f2171af34e4f92f3e6a396f227

Someone else with more experience should also review it, I have only lightly tested it locally.

💬 l0rinc commented on pull request "miniscript refactor: Remove unique_ptr-indirection (#30866 follow-up)":
(https://github.com/bitcoin/bitcoin/pull/31713#discussion_r2165968443)
```suggestion
for (uint32_t i{0}; i < 1'000'000; ++i) {
```
(locally `100'000` is enough for me to reproduce the failure with incorrect destructor and clone - this test may be too heavy otherwise)

💬 l0rinc commented on pull request "miniscript refactor: Remove unique_ptr-indirection (#30866 follow-up)":
(https://github.com/bitcoin/bitcoin/pull/31713#discussion_r2165966175)
+1 for the example in the commit message (if you touch again consider reducing the indentation)
we could even lightly validate the clone here by comparing the two depths for good measure

💬 l0rinc commented on pull request "miniscript refactor: Remove unique_ptr-indirection (#30866 follow-up)":
(https://github.com/bitcoin/bitcoin/pull/31713#discussion_r2165970378)
when do you use a `Get` prefix and when just a capitalized field name?

💬 l0rinc commented on pull request "miniscript refactor: Remove unique_ptr-indirection (#30866 follow-up)":
(https://github.com/bitcoin/bitcoin/pull/31713#discussion_r2165984170)
nit: unless there's a good reason, I'd unify the `Get`/`Is` prefixes (I actually prefer without anything here) and consider `noexcept` for these as well

💬 l0rinc commented on pull request "miniscript refactor: Remove unique_ptr-indirection (#30866 follow-up)":
(https://github.com/bitcoin/bitcoin/pull/31713#discussion_r2165970650)
👍

💬 l0rinc commented on pull request "miniscript refactor: Remove unique_ptr-indirection (#30866 follow-up)":
(https://github.com/bitcoin/bitcoin/pull/31713#discussion_r2165997765)
👍 - if you touch again, consider adding a `TODO` prefix to make sure we get a warning from the linters or the IDE if we accidentally leave them there

💬 l0rinc commented on pull request "miniscript refactor: Remove unique_ptr-indirection (#30866 follow-up)":
(https://github.com/bitcoin/bitcoin/pull/31713#discussion_r2165989320)
nit: I'm repeating myself a bit, but not sure why some getters have prefixes

💬 l0rinc commented on pull request "miniscript refactor: Remove unique_ptr-indirection (#30866 follow-up)":
(https://github.com/bitcoin/bitcoin/pull/31713#discussion_r2165978531)
Nice, I like the new one a lot more (moving the whole subs vector instead of one-by-one)!
One small nit: I think I'd prefer the flattening metaphor rather than the stripping one

💬 l0rinc commented on pull request "miniscript refactor: Remove unique_ptr-indirection (#30866 follow-up)":
(https://github.com/bitcoin/bitcoin/pull/31713#discussion_r2165991247)
do we need to return vectors here? Seems overly specific, I think spans should also suffice here

💬 maflcko commented on pull request "ipc: Handle unclean shutdowns better":
(https://github.com/bitcoin/bitcoin/pull/32345#issuecomment-3003863654)
the CI failure is real, can manifest itself via segfault, timeout, abort, assertion failure, ...

💬 Sjors commented on pull request "ipc: Handle unclean shutdowns better":
(https://github.com/bitcoin/bitcoin/pull/32345#issuecomment-3003879879)
I've been seeing segfaults etc too in https://github.com/Sjors/bitcoin/pull/90. I'm running it again now with the most recent versions of this and https://github.com/bitcoin-core/libmultiprocess/pull/184.

💬 maflcko commented on pull request "docs: add guidance on initialism capitalisation in PascalCase identifiers.":
(https://github.com/bitcoin/bitcoin/pull/32720#issuecomment-3003915877)
Seems fine. No strong opinion, but at least the two lines of docs shouldn't add several typos, see https://github.com/bitcoin/bitcoin/pull/32720#issuecomment-2960249863

💬 Sjors commented on issue "IPC via TCP Sockets":
(https://github.com/bitcoin/bitcoin/issues/32802#issuecomment-3003950873)
Good point about the lack of authentication.

One use case I have in mind is (something like) a BitAxe that connects directly to your node to fetch templates to solo mine on. Currently this involves running a Stratum (v1) solo mining pool, which just adds useless complexity.

That said, as soon as you have more than one device you're going to need pool software to divide the work between them. At that point it makes more sense to run a sidecar application on the same machine as the node, and hav
...

⚠️ alexandre-leng opened an issue: "Improve Bitcoin Transaction Speed for Retail Payments (In-Store Usage)"
(https://github.com/bitcoin/bitcoin/issues/32808)
### Please describe the feature you'd like to see added.

Hello,

I would like to suggest a feature or improvement that could significantly contribute to the adoption of Bitcoin as a common payment method, especially in physical stores.

Currently, transaction confirmation times can be too slow for real-time, in-person payments. This delay is a major obstacle to using Bitcoin as a day-to-day currency for retail purchases.

Proposal:
Explore protocol-level optimizations or layer 1 improvements th
...

⚠️ alexandre-leng opened an issue: "Reduce Bitcoin Network Energy Consumption for Environmental Sustainability"
(https://github.com/bitcoin/bitcoin/issues/32809)
### Please describe the feature you'd like to see added.

Hello,

I would like to open a feature request or initiate a discussion around the possibility of reducing the overall energy consumption of the Bitcoin network.

While Bitcoin has proven its resilience and decentralization through proof-of-work (PoW), the current energy requirements to secure the network are significant. This has raised growing concerns regarding its environmental impact, especially in the context of global efforts to re
...