💬 achow101 commented on pull request "descriptors: MuSig2":
(https://github.com/bitcoin/bitcoin/pull/31244#discussion_r2164821963)
Non-ranged participants generally won't be rederived every time because of the `read_cache`.

🤔 hodlinator reviewed a pull request: "miniscript refactor: Remove unique_ptr-indirection (#30866 follow-up)"
(https://github.com/bitcoin/bitcoin/pull/31713#pullrequestreview-2955202681)
Pushed clang-tidy fix for <https://cirrus-ci.com/task/6094677570486272?logs=ci#L2068>:
```
[15:19:19.395] [ 29/669][11.0s] clang-tidy-20 -p=/ci_container_base/ci/scratch/build-x86_64-pc-linux-gnu -quiet -load=/tidy-build/libbitcoin-tidy.so /ci_container_base/src/test/fuzz/miniscript.cpp
[15:19:19.395] /ci_container_base/src/util/vector.h:23:49: error: function 'Vector<std::vector<miniscript::Node<(anonymous namespace)::ScriptParserContext::Key>>>' is within a recursive call chain [misc-no-rec
...

💬 real-or-random commented on pull request "test: disable secp256 tests by default":
(https://github.com/bitcoin/bitcoin/pull/32782#issuecomment-3001804058)
cc @sipa @jonasnick

💬 achow101 commented on pull request "descriptors: MuSig2":
(https://github.com/bitcoin/bitcoin/pull/31244#discussion_r2164866941)
Fixed

💬 achow101 commented on pull request "descriptors: MuSig2":
(https://github.com/bitcoin/bitcoin/pull/31244#discussion_r2164868678)
Since this `if` uses `ParsePubkey` recursively, I prefer to have it be in `ParsePubkey` than adding a circular dependency between `ParsePubkey` and a `ParseMusig`.

💬 achow101 commented on pull request "descriptors: MuSig2":
(https://github.com/bitcoin/bitcoin/pull/31244#discussion_r2164868920)
Ended up dropping this funciton

💬 achow101 commented on pull request "descriptors: MuSig2":
(https://github.com/bitcoin/bitcoin/pull/31244#discussion_r2164869706)
Ended up extracting this entire derive type parsing into a separate function.

💬 achow101 commented on pull request "descriptors: MuSig2":
(https://github.com/bitcoin/bitcoin/pull/31244#discussion_r2164870116)
Renamed

💬 achow101 commented on pull request "descriptors: MuSig2":
(https://github.com/bitcoin/bitcoin/pull/31244#discussion_r2164870481)
Added a `has_hardened` output parameter.

💬 achow101 commented on pull request "descriptors: MuSig2":
(https://github.com/bitcoin/bitcoin/pull/31244#discussion_r2164871481)
I've changed it to an `Assume`. I don't really like having `assert`s in modules like descriptors.

💬 achow101 commented on pull request "descriptors: MuSig2":
(https://github.com/bitcoin/bitcoin/pull/31244#discussion_r2164871650)
Done, mostly

💬 achow101 commented on pull request "descriptors: MuSig2":
(https://github.com/bitcoin/bitcoin/pull/31244#discussion_r2164871808)
Done, mostly

💬 achow101 commented on pull request "descriptors: MuSig2":
(https://github.com/bitcoin/bitcoin/pull/31244#discussion_r2164872003)
Done

💬 achow101 commented on pull request "descriptors: MuSig2":
(https://github.com/bitcoin/bitcoin/pull/31244#discussion_r2164872311)
Done

📝 solveforceapp opened a pull request: "~"
(https://github.com/bitcoin/bitcoin/pull/32806)
<!--
*** Please remove the following help text before submitting: ***

Pull requests without a rationale and clear improvement may be closed
immediately.

GUI-related pull requests should be opened against
https://github.com/bitcoin-core/gui
first. See CONTRIBUTING.md
-->

<!--
Please provide clear motivation for your patch and explain how it improves
Bitcoin Core user experience or Bitcoin Core developer experience
significantly:

* Any test improvements or new tests that improv
...

✅ fanquake closed a pull request: "~"
(https://github.com/bitcoin/bitcoin/pull/32806)

💬 real-or-random commented on pull request "test: disable secp256 tests by default":
(https://github.com/bitcoin/bitcoin/pull/32782#issuecomment-3001843254)
> Alternatively, libsecp256k1 tests could be run with a lower value for the `SECP256K1_TEST_ITERS` environment variable: say, 8.

We reduced the default count to 16 last year. It would be interesting to know how long CI takes for a count of 8 or 4. And if that's not quite satisfying, we could disable some of the static (= not randomized) tests at low iteration counts. (We already do this for the most expensive ones.)

We test many many compile configurations (platform, compiler version, lib
...

🤔 ryanofsky reviewed a pull request: "bitcoin-cli: Add -ipcconnect option"
(https://github.com/bitcoin/bitcoin/pull/32297#pullrequestreview-2955388404)
Updated ad0144022c2bbed6799bafa3ac8b80ac81dd7178 -> 9ffe57f81b2a6abd161ae010f07916b05e57191d ([`pr/ipc-cli.7`](https://github.com/ryanofsky/bitcoin/commits/pr/ipc-cli.7) -> [`pr/ipc-cli.8`](https://github.com/ryanofsky/bitcoin/commits/pr/ipc-cli.8), [compare](https://github.com/ryanofsky/bitcoin/compare/pr/ipc-cli.7..pr/ipc-cli.8)) with suggested `bitcoin-node` fix and documentation update.

---

re: https://github.com/bitcoin/bitcoin/pull/32297#pullrequestreview-2932651216

> Although wai
...

💬 ryanofsky commented on pull request "bitcoin-cli: Add -ipcconnect option":
(https://github.com/bitcoin/bitcoin/pull/32297#discussion_r2164936628)
re: https://github.com/bitcoin/bitcoin/pull/32297#discussion_r2150327388

> Could use a mention in src/interfaces/README.md

Thanks! Added

💬 ryanofsky commented on pull request "bitcoin-cli: Add -ipcconnect option":
(https://github.com/bitcoin/bitcoin/pull/32297#discussion_r2164936316)
re: https://github.com/bitcoin/bitcoin/pull/32297#discussion_r2150571456

> unused?

IIUC, `std::string` does seem to be used in the Ipc::connectAddress and Ipc::listenAddress declarations below so keeping for now