π hebasto opened a pull request: "cmake: Use `HINTS` instead of `PATHS` in `find_*` commands"
(https://github.com/bitcoin/bitcoin/pull/32805)
According to the CMake documentation, `HINTS` "should be paths computed by system introspection, such as a hint provided by the location of another item already found", which is precisely the case in the `FindQRencode` module.
Entries in `HINTS` are searched before those in `PATHS`. On macOS, Homebrewβs `libqrencode` will therefore be located at its real path rather than via the symlink in the default prefix.
A backport to 29.x is required for https://github.com/bitcoin/bitcoin/pull/32804,
...
(https://github.com/bitcoin/bitcoin/pull/32805)
According to the CMake documentation, `HINTS` "should be paths computed by system introspection, such as a hint provided by the location of another item already found", which is precisely the case in the `FindQRencode` module.
Entries in `HINTS` are searched before those in `PATHS`. On macOS, Homebrewβs `libqrencode` will therefore be located at its real path rather than via the symlink in the default prefix.
A backport to 29.x is required for https://github.com/bitcoin/bitcoin/pull/32804,
...
π¬ hebasto commented on pull request "Fix build on macOS when `qt@6` is installed":
(https://github.com/bitcoin/bitcoin/pull/32804#issuecomment-3001718898)
Please review https://github.com/bitcoin/bitcoin/pull/32805 first.
(https://github.com/bitcoin/bitcoin/pull/32804#issuecomment-3001718898)
Please review https://github.com/bitcoin/bitcoin/pull/32805 first.
π¬ achow101 commented on pull request "descriptors: MuSig2":
(https://github.com/bitcoin/bitcoin/pull/31244#discussion_r2164821963)
Non-ranged participants generally won't be rederived every time because of the `read_cache`.
(https://github.com/bitcoin/bitcoin/pull/31244#discussion_r2164821963)
Non-ranged participants generally won't be rederived every time because of the `read_cache`.
π€ hodlinator reviewed a pull request: "miniscript refactor: Remove unique_ptr-indirection (#30866 follow-up)"
(https://github.com/bitcoin/bitcoin/pull/31713#pullrequestreview-2955202681)
Pushed clang-tidy fix for <https://cirrus-ci.com/task/6094677570486272?logs=ci#L2068>:
```
[15:19:19.395] [ 29/669][11.0s] clang-tidy-20 -p=/ci_container_base/ci/scratch/build-x86_64-pc-linux-gnu -quiet -load=/tidy-build/libbitcoin-tidy.so /ci_container_base/src/test/fuzz/miniscript.cpp
[15:19:19.395] /ci_container_base/src/util/vector.h:23:49: error: function 'Vector<std::vector<miniscript::Node<(anonymous namespace)::ScriptParserContext::Key>>>' is within a recursive call chain [misc-no-rec
...
(https://github.com/bitcoin/bitcoin/pull/31713#pullrequestreview-2955202681)
Pushed clang-tidy fix for <https://cirrus-ci.com/task/6094677570486272?logs=ci#L2068>:
```
[15:19:19.395] [ 29/669][11.0s] clang-tidy-20 -p=/ci_container_base/ci/scratch/build-x86_64-pc-linux-gnu -quiet -load=/tidy-build/libbitcoin-tidy.so /ci_container_base/src/test/fuzz/miniscript.cpp
[15:19:19.395] /ci_container_base/src/util/vector.h:23:49: error: function 'Vector<std::vector<miniscript::Node<(anonymous namespace)::ScriptParserContext::Key>>>' is within a recursive call chain [misc-no-rec
...
π¬ real-or-random commented on pull request "test: disable secp256 tests by default":
(https://github.com/bitcoin/bitcoin/pull/32782#issuecomment-3001804058)
cc @sipa @jonasnick
(https://github.com/bitcoin/bitcoin/pull/32782#issuecomment-3001804058)
cc @sipa @jonasnick
π¬ achow101 commented on pull request "descriptors: MuSig2":
(https://github.com/bitcoin/bitcoin/pull/31244#discussion_r2164866941)
Fixed
(https://github.com/bitcoin/bitcoin/pull/31244#discussion_r2164866941)
Fixed
π¬ achow101 commented on pull request "descriptors: MuSig2":
(https://github.com/bitcoin/bitcoin/pull/31244#discussion_r2164868678)
Since this `if` uses `ParsePubkey` recursively, I prefer to have it be in `ParsePubkey` than adding a circular dependency between `ParsePubkey` and a `ParseMusig`.
(https://github.com/bitcoin/bitcoin/pull/31244#discussion_r2164868678)
Since this `if` uses `ParsePubkey` recursively, I prefer to have it be in `ParsePubkey` than adding a circular dependency between `ParsePubkey` and a `ParseMusig`.
π¬ achow101 commented on pull request "descriptors: MuSig2":
(https://github.com/bitcoin/bitcoin/pull/31244#discussion_r2164868920)
Ended up dropping this funciton
(https://github.com/bitcoin/bitcoin/pull/31244#discussion_r2164868920)
Ended up dropping this funciton
π¬ achow101 commented on pull request "descriptors: MuSig2":
(https://github.com/bitcoin/bitcoin/pull/31244#discussion_r2164869706)
Ended up extracting this entire derive type parsing into a separate function.
(https://github.com/bitcoin/bitcoin/pull/31244#discussion_r2164869706)
Ended up extracting this entire derive type parsing into a separate function.
π¬ achow101 commented on pull request "descriptors: MuSig2":
(https://github.com/bitcoin/bitcoin/pull/31244#discussion_r2164870116)
Renamed
(https://github.com/bitcoin/bitcoin/pull/31244#discussion_r2164870116)
Renamed
π¬ achow101 commented on pull request "descriptors: MuSig2":
(https://github.com/bitcoin/bitcoin/pull/31244#discussion_r2164870481)
Added a `has_hardened` output parameter.
(https://github.com/bitcoin/bitcoin/pull/31244#discussion_r2164870481)
Added a `has_hardened` output parameter.
π¬ achow101 commented on pull request "descriptors: MuSig2":
(https://github.com/bitcoin/bitcoin/pull/31244#discussion_r2164871481)
I've changed it to an `Assume`. I don't really like having `assert`s in modules like descriptors.
(https://github.com/bitcoin/bitcoin/pull/31244#discussion_r2164871481)
I've changed it to an `Assume`. I don't really like having `assert`s in modules like descriptors.
π¬ achow101 commented on pull request "descriptors: MuSig2":
(https://github.com/bitcoin/bitcoin/pull/31244#discussion_r2164871650)
Done, mostly
(https://github.com/bitcoin/bitcoin/pull/31244#discussion_r2164871650)
Done, mostly
π¬ achow101 commented on pull request "descriptors: MuSig2":
(https://github.com/bitcoin/bitcoin/pull/31244#discussion_r2164871808)
Done, mostly
(https://github.com/bitcoin/bitcoin/pull/31244#discussion_r2164871808)
Done, mostly
π¬ achow101 commented on pull request "descriptors: MuSig2":
(https://github.com/bitcoin/bitcoin/pull/31244#discussion_r2164872003)
Done
(https://github.com/bitcoin/bitcoin/pull/31244#discussion_r2164872003)
Done
π¬ achow101 commented on pull request "descriptors: MuSig2":
(https://github.com/bitcoin/bitcoin/pull/31244#discussion_r2164872311)
Done
(https://github.com/bitcoin/bitcoin/pull/31244#discussion_r2164872311)
Done
π solveforceapp opened a pull request: "~"
(https://github.com/bitcoin/bitcoin/pull/32806)
<!--
*** Please remove the following help text before submitting: ***
Pull requests without a rationale and clear improvement may be closed
immediately.
GUI-related pull requests should be opened against
https://github.com/bitcoin-core/gui
first. See CONTRIBUTING.md
-->
<!--
Please provide clear motivation for your patch and explain how it improves
Bitcoin Core user experience or Bitcoin Core developer experience
significantly:
* Any test improvements or new tests that improv
...
(https://github.com/bitcoin/bitcoin/pull/32806)
<!--
*** Please remove the following help text before submitting: ***
Pull requests without a rationale and clear improvement may be closed
immediately.
GUI-related pull requests should be opened against
https://github.com/bitcoin-core/gui
first. See CONTRIBUTING.md
-->
<!--
Please provide clear motivation for your patch and explain how it improves
Bitcoin Core user experience or Bitcoin Core developer experience
significantly:
* Any test improvements or new tests that improv
...
β
fanquake closed a pull request: "~"
(https://github.com/bitcoin/bitcoin/pull/32806)
(https://github.com/bitcoin/bitcoin/pull/32806)
π¬ real-or-random commented on pull request "test: disable secp256 tests by default":
(https://github.com/bitcoin/bitcoin/pull/32782#issuecomment-3001843254)
> Alternatively, libsecp256k1 tests could be run with a lower value for the `SECP256K1_TEST_ITERS` environment variable: say, 8.
We reduced the default count to 16 last year. It would be interesting to know how long CI takes for a count of 8 or 4. And if that's not quite satisfying, we could disable some of the static (= not randomized) tests at low iteration counts. (We already do this for the most expensive ones.)
We test many many compile configurations (platform, compiler version, lib
...
(https://github.com/bitcoin/bitcoin/pull/32782#issuecomment-3001843254)
> Alternatively, libsecp256k1 tests could be run with a lower value for the `SECP256K1_TEST_ITERS` environment variable: say, 8.
We reduced the default count to 16 last year. It would be interesting to know how long CI takes for a count of 8 or 4. And if that's not quite satisfying, we could disable some of the static (= not randomized) tests at low iteration counts. (We already do this for the most expensive ones.)
We test many many compile configurations (platform, compiler version, lib
...
π€ ryanofsky reviewed a pull request: "bitcoin-cli: Add -ipcconnect option"
(https://github.com/bitcoin/bitcoin/pull/32297#pullrequestreview-2955388404)
Updated ad0144022c2bbed6799bafa3ac8b80ac81dd7178 -> 9ffe57f81b2a6abd161ae010f07916b05e57191d ([`pr/ipc-cli.7`](https://github.com/ryanofsky/bitcoin/commits/pr/ipc-cli.7) -> [`pr/ipc-cli.8`](https://github.com/ryanofsky/bitcoin/commits/pr/ipc-cli.8), [compare](https://github.com/ryanofsky/bitcoin/compare/pr/ipc-cli.7..pr/ipc-cli.8)) with suggested `bitcoin-node` fix and documentation update.
---
re: https://github.com/bitcoin/bitcoin/pull/32297#pullrequestreview-2932651216
> Although wai
...
(https://github.com/bitcoin/bitcoin/pull/32297#pullrequestreview-2955388404)
Updated ad0144022c2bbed6799bafa3ac8b80ac81dd7178 -> 9ffe57f81b2a6abd161ae010f07916b05e57191d ([`pr/ipc-cli.7`](https://github.com/ryanofsky/bitcoin/commits/pr/ipc-cli.7) -> [`pr/ipc-cli.8`](https://github.com/ryanofsky/bitcoin/commits/pr/ipc-cli.8), [compare](https://github.com/ryanofsky/bitcoin/compare/pr/ipc-cli.7..pr/ipc-cli.8)) with suggested `bitcoin-node` fix and documentation update.
---
re: https://github.com/bitcoin/bitcoin/pull/32297#pullrequestreview-2932651216
> Although wai
...