💬 dergoegge commented on pull request "Add simulation-based `CCoinsViewCache` fuzzer":
(https://github.com/bitcoin/bitcoin/pull/27011#issuecomment-1427833942)
Code review ACK 561848aaf2d67791e92754f3d11813bc53959a8f

💬 hebasto commented on pull request "Convert ArgsManager::GetDataDir to a read-only function":
(https://github.com/bitcoin/bitcoin/pull/27073#discussion_r1104384205)
1. Should we care about possible exceptions here?
2. What is the point to run this code when `net_specific == false`?

💬 hebasto commented on pull request "Convert ArgsManager::GetDataDir to a read-only function":
(https://github.com/bitcoin/bitcoin/pull/27073#discussion_r1104386865)
Maybe introduce two functions: one for `net_specific == true` and the other for `net_specific == true`?

It will make code cleaner on the caller sites.

💬 MarcoFalke commented on pull request "Minor edits - punctuation, spelling to make the contributing instructions more readable for all.":
(https://github.com/bitcoin/bitcoin/pull/27082#issuecomment-1427850629)
Closing for now due to controversy.

In the future, please make sure to read the contribution guideline and make sure the tests pass (including the lint CI task).

✅ MarcoFalke closed a pull request: "Minor edits - punctuation, spelling to make the contributing instructions more readable for all."
(https://github.com/bitcoin/bitcoin/pull/27082)

💬 MarcoFalke commented on pull request "Minor edits - punctuation, spelling to make the contributing instructions more readable for all.":
(https://github.com/bitcoin/bitcoin/pull/27082#issuecomment-1427851006)
## Getting started to contribute to Bitcoin Core

### Setting up your development environment

New developers are very welcome and needed. There are a lot of open issues of any difficulty waiting to be fixed. However, before you start contributing, familiarize yourself with the Bitcoin Core build system and tests. Refer to the documentation in the repository on how to build Bitcoin Core and how to run the unit and functional tests. Once that is done, you are all set.

If you need more help
...

💬 glozow commented on pull request "mempool / miner: regularly flush below-minrelayfeerate entries, mine everything in the mempool":
(https://github.com/bitcoin/bitcoin/pull/27018#discussion_r1104415004)
> What's the problem with building a low-feerate block template?

So I think the argument for banning literal 0-fee packages is there is no gain from mining it, but it costs resources to include in the block. So it's probably not controversial to remove everything =0 fee, regardless of how many there are (?).

Beyond that (>0 but <minrelay), I don't have an argument other than the fact that a miner might expect `-blockmintxfee` to guarantee that the feerate of their block won't be lower tha
...

👍 furszy approved a pull request: "refactor, wallet: Avoid variable shadowing"
(https://github.com/bitcoin/bitcoin/pull/27087)

💬 petertodd commented on pull request "[WIP] p2p: Add random txn's from mempool to GETBLOCKTXN":
(https://github.com/bitcoin/bitcoin/pull/27086#issuecomment-1427913555)
> * Just empirically, compact block relay works very well

Note that it's very easy for an adversary to change that by simply broadcasting simultaneous double-spends with the same fee. Indeed, n-way double spends broadcast to n different nodes is easy to do. So I don't think the observation that it works well right now is relevant to the adversarial case.

⚠️ rex4539 opened an issue: "feature_index_prune.py failed on macOS"
(https://github.com/bitcoin/bitcoin/issues/27091)
Latest master
macOS 13.2

```
2/262 - feature_index_prune.py failed, Duration: 203 s

stdout:
2023-02-13T12:45:50.370000Z TestFramework (INFO): Initializing test directory /var/folders/pn/rswd5k6175d02hbt25tvl47r0000gn/T/test_runner_₿_🏃_20230213_144546/feature_index_prune_259
2023-02-13T12:45:54.845000Z TestFramework (INFO): check if we can access blockfilters and coinstats when pruning is enabled but no blocks are actually pruned
2023-
...

⚠️ rex4539 opened an issue: "feature_pruning.py failed on macOS"
(https://github.com/bitcoin/bitcoin/issues/27092)
Latest master
macOS 13.2

```
39/262 - feature_pruning.py failed, Duration: 1365 s

stdout:
2023-02-13T12:45:50.370000Z TestFramework (INFO): Initializing test directory /var/folders/pn/rswd5k6175d02hbt25tvl47r0000gn/T/test_runner_₿_🏃_20230213_144546/feature_pruning_261
2023-02-13T12:45:55.313000Z TestFramework (INFO): Warning! This test requires 4GB of disk space
2023-02-13T12:45:55.313000Z TestFramework (INFO): Mining a big blockchain of 995 blocks
2023-02-13T12:56:41.112000Z TestFr
...

💬 fanquake commented on issue "feature_index_prune.py failed on macOS":
(https://github.com/bitcoin/bitcoin/issues/27091#issuecomment-1427935434)
Thanks. However these are more than likely due to resource contention, or issues on your local machine. I assume the same failure doesn't happen if you run the test directly?

💬 fanquake commented on issue "feature_pruning.py failed on macOS":
(https://github.com/bitcoin/bitcoin/issues/27092#issuecomment-1427935704)
Thanks. However these are more than likely due to resource contention, or issues on your local machine. I assume the same failure doesn't happen if you run the test directly?

💬 MarcoFalke commented on issue "feature_index_prune.py failed on macOS":
(https://github.com/bitcoin/bitcoin/issues/27091#issuecomment-1427951662)
Maybe the default timeout can be increased for this one?

💬 MarcoFalke commented on issue "feature_pruning.py failed on macOS":
(https://github.com/bitcoin/bitcoin/issues/27092#issuecomment-1427952667)
Let's discuss in #27092

✅ MarcoFalke closed an issue: "feature_pruning.py failed on macOS"
(https://github.com/bitcoin/bitcoin/issues/27092)

💬 hebasto commented on pull request "refactor: wallet, remove global 'ArgsManager' dependency":
(https://github.com/bitcoin/bitcoin/pull/26889#issuecomment-1427954058)
Concept ACK.

💬 fanquake commented on pull request "refactor, wallet: Avoid variable shadowing":
(https://github.com/bitcoin/bitcoin/pull/27087#issuecomment-1427955686)
There are currently multiple instances of `-Wshadow` warnings emmited when compiling the codebase. Is there some reason this one specifically needs fixing? Otherwise this just introduces a pointless merge conflict to a number of very recently-rebased PRs.

💬 fanquake commented on issue "Check usages of `#if defined(...)`":
(https://github.com/bitcoin/bitcoin/issues/16419#issuecomment-1427966591)
> It is. See https://github.com/bitcoin/bitcoin/pull/16547.

It isn't. See #25302.

💬 fanquake commented on pull request "build: Check usages of #if defined(...)":
(https://github.com/bitcoin/bitcoin/pull/25302#issuecomment-1427967375)
@brokenprogrammer sorry for not following up. Changes should always be squashed. I will get to reviewing this shortly.