💬 maflcko commented on pull request "[WIP] rpc: add `clearmempool` command for regtest mode":
(https://github.com/bitcoin/bitcoin/pull/32418#discussion_r2128677281)
this is the wrong order

💬 maflcko commented on pull request "[WIP] rpc: add `clearmempool` command for regtest mode":
(https://github.com/bitcoin/bitcoin/pull/32418#discussion_r2128677493)
node0 stderr Assertion failed: detected inconsistent lock order for '::cs_main' in rpc/mempool.cpp:1150 (in thread 'httpworker.3'), details in debug log.

💬 maflcko commented on pull request "wallet, rpc: Change `OutputType` items from `string` into compile-time constants `string_view`":
(https://github.com/bitcoin/bitcoin/pull/32432#issuecomment-2943998197)
> > Not sure what you mean by "won't work". What is the exact diff to reproduce the compile failure or error?
>
> If you try to concatenate the RPC description with any of the output type string variables, you will get an empty output type string. The reason seems to be that they are not yet initialized when this operation occurs.

Again, it would be good to have the exact code to reproduce. I guess you are talking about SIOF: https://en.cppreference.com/w/cpp/language/siof.html, which has
...

💬 maflcko commented on pull request "uint256 cxx-20 constexpr patch":
(https://github.com/bitcoin/bitcoin/pull/32663#issuecomment-2944018762)
see https://github.com/bitcoin/bitcoin/blob/ae024137bda9fe189f4e7ccf26dbaffd44cbbeb6/.github/workflows/ci.yml#L121-L128

💬 Sjors commented on pull request "wallet: Always set descriptor cache upgraded flag for new wallets":
(https://github.com/bitcoin/bitcoin/pull/32597#issuecomment-2944074815)
ACK 47237cd1938058b29fdec242c3a37611e255fda0

👍 theStack approved a pull request: "test: wallet: cover wallet passphrase with a null char"
(https://github.com/bitcoin/bitcoin/pull/32675#pullrequestreview-2900231176)
ACK 7cfbb8575e1ffbad5c48e2c461b45dd6ac63d064

💬 theStack commented on pull request "test: wallet: cover wallet passphrase with a null char":
(https://github.com/bitcoin/bitcoin/pull/32675#discussion_r2128796675)
nit: as there is already a null character inside the string, so could just append a regular character at the end to cause a mismatch with this error message
```suggestion
assert_raises_rpc_error(-14, "wallet passphrase entered is incorrect. It contains a null character (ie - a zero byte)", self.nodes[0].walletpassphrase, passphrase_with_nulls + "x", 10)
brunoerg marked this conversation as resolved.
assert_raises_rpc_error(-14, "The old wallet passphrase entered is incorrect. It cont
...

⚠️ Fuzion24 opened an issue: "Internal bug detected: Fee needed > fee paid"
(https://github.com/bitcoin/bitcoin/issues/32683)
### Is there an existing issue for this?

- [x] I have searched the existing issues

### Current behaviour

walletcreatefundedpsbt errors out

```
walletcreatefundedpsbt "[]" '{"<readacted_addr>":0.01}'
error code: -4
error message:
Internal bug detected: Fee needed > fee paid
./wallet/spend.cpp:1320 (CreateTransactionInternal)
Bitcoin Core v29.0.0
Please report this issue here: https://github.com/bitcoin/bitcoin/issues
```

### Expected behaviour

walletcreatefundedpsbt should not error out.


...

💬 rkrux commented on pull request "descriptors: MuSig2":
(https://github.com/bitcoin/bitcoin/pull/31244#discussion_r2128825473)
I raised a PR for it here: https://github.com/bitcoin/bips/pull/1866

🤔 theStack reviewed a pull request: "wallet: Be able to receive and spend inputs involving MuSig2 aggregate keys"
(https://github.com/bitcoin/bitcoin/pull/29675#pullrequestreview-2900301627)
Concept ACK

💬 theStack commented on pull request "wallet: Be able to receive and spend inputs involving MuSig2 aggregate keys":
(https://github.com/bitcoin/bitcoin/pull/29675#discussion_r2128836472)
in commit 5e90a3c747ac2d44f9f52a3eeffbbe391f837bd8: seems like this change should be part of the earlier commit 01f639835783aa10d4c4b63da477c0300bc8495f, which currently doesn't compile
```
...
In file included from /home/thestack/bitcoin_prrev/pr29675/src/musig.cpp:5:
/home/thestack/bitcoin_prrev/pr29675/src/musig.h:44:5: error: no template named 'secure_unique_ptr'
secure_unique_ptr<secp256k1_musig_secnonce> m_nonce;

/home/thestack/bitcoin_prrev/pr29675/src/musig.cpp:74:36: error:
...

💬 Muniru0 commented on issue "doc: references to unshipped documentation":
(https://github.com/bitcoin/bitcoin/issues/32565#issuecomment-2944333990)
@Zeegaths I think you can wait for 24hrs if still no response from @fanquake you can go ahead and start a draft PR. I can help you review it when you finalize it.

💬 Muniru0 commented on issue "doc: references to unshipped documentation":
(https://github.com/bitcoin/bitcoin/issues/32565#issuecomment-2944359326)
I wanted to do it but I am currently trying to review a very interesting PR 😊.

💬 liamperfil commented on pull request "gui: Add a menu action to restore then migrate a legacy wallet":
(https://github.com/bitcoin-core/gui/pull/877#issuecomment-2944369692)
I support the proposal, but I also consider that this extra click is a bad experience for the user. The ideal would be to directly integrate this functionality to automatically detect if it is a legacy wallet and offer the migration option in the same flow. If you need someone on your team I am available.

🚀 fanquake merged a pull request: "[28.x] Backport #31407"
(https://github.com/bitcoin/bitcoin/pull/32563)

💬 Sjors commented on pull request "wallet: Be able to receive and spend inputs involving MuSig2 aggregate keys":
(https://github.com/bitcoin/bitcoin/pull/29675#discussion_r2128878830)
@theStack it only runs the most recent N (6?) commits.

📝 fanquake opened a pull request: "[28.x] 28.2rc2"
(https://github.com/bitcoin/bitcoin/pull/32684)
Backports #32568.
Bumps to `rc2`.
Also includes #32563 & #32639 since `rc1`.

💬 fanquake commented on pull request "depends: use "mkdir -p" when installing xproto":
(https://github.com/bitcoin/bitcoin/pull/32568#issuecomment-2944484421)
Backported to `28.x` in #32684.

💬 John-zhan commented on issue "windows: depends config fails":
(https://github.com/bitcoin/bitcoin/issues/32578#issuecomment-2944494245)
I have do as https://github.com/microsoft/vcpkg/issues/45814 and now cmake successfully config, and build bitcoin success.

✅ John-zhan closed an issue: "windows: depends config fails"
(https://github.com/bitcoin/bitcoin/issues/32578)