📝 RandyMcMillan opened a pull request: "uint256 cxx-20 constexpr patch"
(https://github.com/bitcoin/bitcoin/pull/32663)
(https://github.com/bitcoin/bitcoin/pull/32663)
💬 mabu44 commented on pull request "policy: make pathological transactions packed with legacy sigops non-standard":
(https://github.com/bitcoin/bitcoin/pull/32521#discussion_r2121610418)
nHeight is indeed an int. Am I missing something?
(https://github.com/bitcoin/bitcoin/pull/32521#discussion_r2121610418)
nHeight is indeed an int. Am I missing something?
👍 ryanofsky approved a pull request: "depends: hard-code necessary c(xx)flags rather than setting them per-host"
(https://github.com/bitcoin/bitcoin/pull/32584#pullrequestreview-2889108835)
Code review ACK 51f6aa8ac47b7b5412553af2e7152d250a858d0d. This seems like a good change that deduplicates host definitions, and removes nonsensical inclusion of `-std` in host options rather than package options, since c/c++ standard versions should not vary by host.
---
IIUC, this change is mostly just a refactoring. For example, it rearranges the libevent flags shown by `make print-libevent_cflags` from:
```sh
libevent_cflags=-pipe -std=c11 -O2 -fdebug-prefix-map=...
```
to:
`
...
(https://github.com/bitcoin/bitcoin/pull/32584#pullrequestreview-2889108835)
Code review ACK 51f6aa8ac47b7b5412553af2e7152d250a858d0d. This seems like a good change that deduplicates host definitions, and removes nonsensical inclusion of `-std` in host options rather than package options, since c/c++ standard versions should not vary by host.
---
IIUC, this change is mostly just a refactoring. For example, it rearranges the libevent flags shown by `make print-libevent_cflags` from:
```sh
libevent_cflags=-pipe -std=c11 -O2 -fdebug-prefix-map=...
```
to:
`
...
💬 benthecarman commented on pull request "rpc: Note in fundrawtransaction doc, fee rate is for package":
(https://github.com/bitcoin/bitcoin/pull/32607#issuecomment-2931455300)
impl'd @achow101's suggestions, also added missing `\n` at end of the doc
(https://github.com/bitcoin/bitcoin/pull/32607#issuecomment-2931455300)
impl'd @achow101's suggestions, also added missing `\n` at end of the doc
📝 RandyMcMillan converted_to_draft a pull request: "uint256 cxx-20 constexpr patch"
(https://github.com/bitcoin/bitcoin/pull/32663)
(https://github.com/bitcoin/bitcoin/pull/32663)
👋 RandyMcMillan's pull request is ready for review: "uint256 cxx-20 constexpr patch"
(https://github.com/bitcoin/bitcoin/pull/32663)
(https://github.com/bitcoin/bitcoin/pull/32663)
🤔 glozow reviewed a pull request: "p2p: improve TxOrphanage denial of service bounds"
(https://github.com/bitcoin/bitcoin/pull/31829#pullrequestreview-2888547849)
Thanks for the review! Just addressed most comments, still have a few more to get to
(https://github.com/bitcoin/bitcoin/pull/31829#pullrequestreview-2888547849)
Thanks for the review! Just addressed most comments, still have a few more to get to
💬 glozow commented on pull request "p2p: improve TxOrphanage denial of service bounds":
(https://github.com/bitcoin/bitcoin/pull/31829#discussion_r2121349624)
have consolidated the two
(https://github.com/bitcoin/bitcoin/pull/31829#discussion_r2121349624)
have consolidated the two
💬 glozow commented on pull request "p2p: improve TxOrphanage denial of service bounds":
(https://github.com/bitcoin/bitcoin/pull/31829#discussion_r2121656293)
added
(https://github.com/bitcoin/bitcoin/pull/31829#discussion_r2121656293)
added
💬 glozow commented on pull request "p2p: improve TxOrphanage denial of service bounds":
(https://github.com/bitcoin/bitcoin/pull/31829#discussion_r2121240683)
removed
(https://github.com/bitcoin/bitcoin/pull/31829#discussion_r2121240683)
removed
💬 glozow commented on pull request "p2p: improve TxOrphanage denial of service bounds":
(https://github.com/bitcoin/bitcoin/pull/31829#discussion_r2121656398)
added
(https://github.com/bitcoin/bitcoin/pull/31829#discussion_r2121656398)
added
💬 glozow commented on pull request "p2p: improve TxOrphanage denial of service bounds":
(https://github.com/bitcoin/bitcoin/pull/31829#discussion_r2121336985)
removed
(https://github.com/bitcoin/bitcoin/pull/31829#discussion_r2121336985)
removed
💬 glozow commented on pull request "p2p: improve TxOrphanage denial of service bounds":
(https://github.com/bitcoin/bitcoin/pull/31829#discussion_r2121334653)
done
(https://github.com/bitcoin/bitcoin/pull/31829#discussion_r2121334653)
done
💬 glozow commented on pull request "p2p: improve TxOrphanage denial of service bounds":
(https://github.com/bitcoin/bitcoin/pull/31829#discussion_r2121650357)
done
(https://github.com/bitcoin/bitcoin/pull/31829#discussion_r2121650357)
done
💬 glozow commented on pull request "p2p: improve TxOrphanage denial of service bounds":
(https://github.com/bitcoin/bitcoin/pull/31829#discussion_r2121336441)
added
(https://github.com/bitcoin/bitcoin/pull/31829#discussion_r2121336441)
added
💬 glozow commented on pull request "p2p: improve TxOrphanage denial of service bounds":
(https://github.com/bitcoin/bitcoin/pull/31829#discussion_r2121375791)
removed
(https://github.com/bitcoin/bitcoin/pull/31829#discussion_r2121375791)
removed
💬 fanquake commented on pull request "ci, iwyu: Treat warnings as errors for specific directories":
(https://github.com/bitcoin/bitcoin/pull/31308#discussion_r2121666498)
> to avoid issues
What issues? Do I understand correctly, that if we land the patch in the subtree, this will just break again?
(https://github.com/bitcoin/bitcoin/pull/31308#discussion_r2121666498)
> to avoid issues
What issues? Do I understand correctly, that if we land the patch in the subtree, this will just break again?
💬 hebasto commented on pull request "ci, iwyu: Treat warnings as errors for specific directories":
(https://github.com/bitcoin/bitcoin/pull/31308#discussion_r2121670336)
The following `git diff` prints this patch even IWYU did not apply any modifications.
(https://github.com/bitcoin/bitcoin/pull/31308#discussion_r2121670336)
The following `git diff` prints this patch even IWYU did not apply any modifications.
💬 darosior commented on pull request "policy: make pathological transactions packed with legacy sigops non-standard":
(https://github.com/bitcoin/bitcoin/pull/32521#discussion_r2121670967)
Wow my bad.
(https://github.com/bitcoin/bitcoin/pull/32521#discussion_r2121670967)
Wow my bad.
💬 fanquake commented on pull request "ci, iwyu: Treat warnings as errors for specific directories":
(https://github.com/bitcoin/bitcoin/pull/31308#discussion_r2121672661)
?
(https://github.com/bitcoin/bitcoin/pull/31308#discussion_r2121672661)
?