💬 maflcko commented on issue "Add config option to set external P2P port to facilitate incoming connections":
(https://github.com/bitcoin/bitcoin/issues/32657#issuecomment-2929801124)
I guess the docs could be updated for the setting in `init.cpp`, to clarify this.

💬 Sjors commented on pull request "wallet: `addhdkey` RPC to add just keys to wallets via new `unused(KEY)` descriptor":
(https://github.com/bitcoin/bitcoin/pull/29136#issuecomment-2929810137)
There might be a silent conflict with #32514.

💬 Sjors commented on pull request "wallet: `addhdkey` RPC to add just keys to wallets via new `unused(KEY)` descriptor":
(https://github.com/bitcoin/bitcoin/pull/29136#discussion_r2120666028)
First `\n` needs to be dropped.

💬 maflcko commented on pull request "wallet: `addhdkey` RPC to add just keys to wallets via new `unused(KEY)` descriptor":
(https://github.com/bitcoin/bitcoin/pull/29136#discussion_r2120693164)
> cc @maflcko is there no test that calls `help` on every method?

There should be one. However, I don't think it can catch this right now, because the `help` command will internally iterate over the individual help calls and ignore the type of the exception (the help is returned via an exception).


See:

```cpp
catch (const std::exception& e)
{
// Help text is returned in an exception
std::string strHelp = std::string(e.what());
```

It wou
...

💬 maflcko commented on pull request "wallet: `addhdkey` RPC to add just keys to wallets via new `unused(KEY)` descriptor":
(https://github.com/bitcoin/bitcoin/pull/29136#discussion_r2120696631)
https://github.com/bitcoin/bitcoin/pull/32588 may also help to catch it, but the code should probably still be made more type-safe.

💬 m3dwards commented on pull request "ci: remove 3rd party js from windows dll gha job":
(https://github.com/bitcoin/bitcoin/pull/32513#discussion_r2120700485)
Should be addressed

💬 m3dwards commented on pull request "ci: remove 3rd party js from windows dll gha job":
(https://github.com/bitcoin/bitcoin/pull/32513#issuecomment-2929886599)
> While touching this code, it seems reasonable to also address the other @davidgumberg's [comment](https://github.com/bitcoin/bitcoin/pull/32634#issuecomment-2918081325):

Added

💬 fanquake commented on pull request "depends: don't install & then delete sqlite pkgconf":
(https://github.com/bitcoin/bitcoin/pull/32656#issuecomment-2929895945)
Guix Build:
```bash
545db2ab3bf28143eda2307089bb7266ae64802ea4a15371bacccf4574ee2c67 guix-build-72a5aa9b791e/output/aarch64-linux-gnu/SHA256SUMS.part
660030fb8c70d09e11f35e2ccdde4187f6bd90009bc1da2826be1cf8a73e6f4b guix-build-72a5aa9b791e/output/aarch64-linux-gnu/bitcoin-72a5aa9b791e-aarch64-linux-gnu-debug.tar.gz
e4a702b1d4f589cd9a1d6a0534eee7ddab725a9aa753b5a276510ee9b956ed94 guix-build-72a5aa9b791e/output/aarch64-linux-gnu/bitcoin-72a5aa9b791e-aarch64-linux-gnu.tar.gz
932b1525b03ed1ad
...

💬 hebasto commented on issue "cmake: Replace f`ile(GLOB ...)` command with an explicit list of `*.ts` files":
(https://github.com/bitcoin/bitcoin/issues/32653#issuecomment-2929957366)
> What's the actual blocker to just making this change?

There are no blockers.

However, [`bitcoin-maintainer-tools/update-translations.py`](https://github.com/bitcoin-core/bitcoin-maintainer-tools/blob/main/update-translations.py) should be updated first.

💬 mabu44 commented on pull request "policy: make pathological transactions packed with legacy sigops non-standard":
(https://github.com/bitcoin/bitcoin/pull/32521#discussion_r2120739704)
Moving these lines directly before the check on sigops (e.g. to line 228) can improve performances because we avoid performing the calculation when a "return false" is executed for another reason in the block between lines 206 and 227.

💬 mabu44 commented on pull request "policy: make pathological transactions packed with legacy sigops non-standard":
(https://github.com/bitcoin/bitcoin/pull/32521#discussion_r2120745163)
Moving these lines directly before the check on sigops (e.g. to line 228) can improve performances because we avoid performing the calculation when a "return false" is executed for another reason in the block between lines 206 and 227.

💬 hebasto commented on issue "windows: depends config fails":
(https://github.com/bitcoin/bitcoin/issues/32578#issuecomment-2929989264)
> Oh, no. I'm so sorry. I modify my ci.yml as this:

What CI are you using? Is the `VCPKG_INSTALLATION_ROOT` environment variable defined there?

👍 stickies-v approved a pull request: "depends: don't install & then delete sqlite pkgconf"
(https://github.com/bitcoin/bitcoin/pull/32656#pullrequestreview-2887874268)
ACK 72a5aa9b791e80a6204990c27c8165ce8aa81dd7

https://github.com/bitcoin/bitcoin/pull/31276/commits/319a4e82614283afb3dbc5d38ff3b9d17fb911b3 already removed the pkgconfig data (and as per my understanding, could have just removed the `install-pkgconfigDATA` target as an equivalent approach). Since the postprocess_cmds are executed right after the stage_cmds, my understanding is that nothing was done with the pkgconfig data, so simply not installing it makes sense.

Tested with depends build
...

💬 laanwj commented on pull request "cmake: Replace deprecated `qt6_add_translation` with `qt6_add_lrelease`":
(https://github.com/bitcoin/bitcoin/pull/32651#issuecomment-2930085376)
From the documentation i understand that it's not `qt_add_translations` itself that was deprecated, but the specific syntax of using it. Starting with Qt 6.7, it uses a different format, but it won't be removed? It's slightly ambigious to me, tbh.

💬 hebasto commented on pull request "cmake: Replace deprecated `qt6_add_translation` with `qt6_add_lrelease`":
(https://github.com/bitcoin/bitcoin/pull/32651#issuecomment-2930095789)
> From the documentation i understand that it's not `qt_add_translations` itself that was deprecated, but the specific syntax of using it. Starting with Qt 6.7, it uses a different format, but it won't be removed? It's slightly ambigious to me, tbh.

`qt_add_translation` (singular) is deprecated. `qt_add_translations` (plural) is a new Qt 6 command that combines `lupdate` and `lrelease` invocations.

💬 laanwj commented on issue "cmake: Replace f`ile(GLOB ...)` command with an explicit list of `*.ts` files":
(https://github.com/bitcoin/bitcoin/issues/32653#issuecomment-2930104903)
Concept ACK. Using a glob is kind of fragile here, harder to ensure the build matches git when there's loose `.ts` files around.

💬 laanwj commented on pull request "cmake: Replace deprecated `qt6_add_translation` with `qt6_add_lrelease`":
(https://github.com/bitcoin/bitcoin/pull/32651#issuecomment-2930112960)
> qt_add_translation (singular) is deprecated. qt_add_translations (plural) is a new Qt 6 command that combines the lupdate and lrelease invocations.

Right, and we only need `lrealease` here. Okay, concept ACK.

💬 hebasto commented on issue "cmake: Replace f`ile(GLOB ...)` command with an explicit list of `*.ts` files":
(https://github.com/bitcoin/bitcoin/issues/32653#issuecomment-2930114468)
> Using a glob is kind of fragile here, harder to ensure the build matches git when there's loose `.ts` files around.

True. Please see https://github.com/bitcoin/bitcoin/issues/32653.

🤔 hebasto reviewed a pull request: "depends: don't install & then delete sqlite pkgconf"
(https://github.com/bitcoin/bitcoin/pull/32656#pullrequestreview-2887975315)
My Guix build:
```
aarch64
545db2ab3bf28143eda2307089bb7266ae64802ea4a15371bacccf4574ee2c67 guix-build-72a5aa9b791e/output/aarch64-linux-gnu/SHA256SUMS.part
660030fb8c70d09e11f35e2ccdde4187f6bd90009bc1da2826be1cf8a73e6f4b guix-build-72a5aa9b791e/output/aarch64-linux-gnu/bitcoin-72a5aa9b791e-aarch64-linux-gnu-debug.tar.gz
e4a702b1d4f589cd9a1d6a0534eee7ddab725a9aa753b5a276510ee9b956ed94 guix-build-72a5aa9b791e/output/aarch64-linux-gnu/bitcoin-72a5aa9b791e-aarch64-linux-gnu.tar.gz
932b1525
...

👍 hebasto approved a pull request: "depends: don't install & then delete sqlite pkgconf"
(https://github.com/bitcoin/bitcoin/pull/32656#pullrequestreview-2887977405)
ACK 72a5aa9b791e80a6204990c27c8165ce8aa81dd7.