💬 ismaelsadeeq commented on pull request "init: deprecate `-blockmaxweight` startup option":
(https://github.com/bitcoin/bitcoin/pull/32654#discussion_r2118920258)
yes that correct.

💬 glozow commented on pull request "p2p: improve TxOrphanage denial of service bounds":
(https://github.com/bitcoin/bitcoin/pull/31829#discussion_r2119024575)
Oof yes! Should be replaced with an "IsUnique" type of thing.

📝 fanquake opened a pull request: "depends: sqlite 3.50.0; switch to autosetup"
(https://github.com/bitcoin/bitcoin/pull/32655)
We currently use SQLite `3.46.1` in depends. Migrating to any version after `3.49.0` (with our use of the amalgamation tarball), requires migrating to to building SQLite with [`autosetup`](https://msteveb.github.io/autosetup/), which is a replacement for Autoconf. This is what that will look like.

📝 fanquake opened a pull request: "depends: don't install & then delete sqlite pkgconf"
(https://github.com/bitcoin/bitcoin/pull/32656)

👋 fanquake's pull request is ready for review: "build: add -Wthread-safety-pointer"
(https://github.com/bitcoin/bitcoin/pull/32647)

💬 fanquake commented on pull request "wallet: add `seeds` argument to `importdescriptors`":
(https://github.com/bitcoin/bitcoin/pull/27351#issuecomment-2927097331)
PIcked up in ##32652.

💬 romanz commented on pull request "rest: fetch spent transaction outputs by blockhash":
(https://github.com/bitcoin/bitcoin/pull/32540#discussion_r2119135815)
In https://github.com/bitcoin/bitcoin/pull/32540/commits/62e68bd46726dc17b657c4c334b06351fc761868, I have added `/blockundo/` REST endpoint (which is using `ReadBlockRawUndo` and **client-side** deserilalization).

I have used https://github.com/romanz/bench-rest/commit/084e07764fdb76d4bc25d2090769c0ef3f0a44c5 to benchmark it against `/spenttxouts/` REST endpoint (which is using `ReadBlockUndo` and **server-side** deserialization) by reading 10k blocks from height=800000.

In addition, I hav
...

💬 romanz commented on pull request "rest: fetch spent transaction outputs by blockhash":
(https://github.com/bitcoin/bitcoin/pull/32540#discussion_r2119137893)
Would it be OK to switch this PR back to use `/spenttxouts/` (i.e. removing 62e68bd467 and keeping 1e2b26e4f8)?

🤔 theStack reviewed a pull request: "descriptors: MuSig2"
(https://github.com/bitcoin/bitcoin/pull/31244#pullrequestreview-2885837240)
According to BIP 390 [_"Repeated participant public keys are not allowed."_](https://github.com/bitcoin/bips/blob/72af87fc72999e3f0a26a06e6e0a7f3134236337/bip-0390.mediawiki?plain=1#L36), but it seems there is currently no check preventing that? Example test case that passes but shouldn't (IIUC): https://github.com/theStack/bitcoin/commit/f260c7ec06e8bbb7148877a9a9b7e96707c41fa1

💬 RandyMcMillan commented on something "":
(https://github.com/bitcoin/bitcoin/commit/2b1f6f9ccf36f1e0a2c9d99154e1642f796d7c2b#r158827732)
👀

💬 RandyMcMillan commented on something "":
(https://github.com/bitcoin/bitcoin/commit/2b1f6f9ccf36f1e0a2c9d99154e1642f796d7c2b#r158827735)
👀

💬 pinheadmz commented on something "":
(https://github.com/bitcoin/bitcoin/commit/2b1f6f9ccf36f1e0a2c9d99154e1642f796d7c2b#r158844306)
Did you mean to comment on an 8 year old segwit commit?

⚠️ rleed opened an issue: "Add config option to set external P2P port to facilitate incoming connections"
(https://github.com/bitcoin/bitcoin/issues/32657)
### Please describe the feature you'd like to see added.

Add config option to set external P2P port to facilitate incoming connections, complementary to the `externalip` option.

### Is your feature related to a problem, if so please describe it.

Without being able to specify the external port, it is impossible to receive incoming connections when the node is behind a port-forwarding system unless the same port number is used both externally and internally, which may not always be an option o
...

💬 sipa commented on issue "Add config option to set external P2P port to facilitate incoming connections":
(https://github.com/bitcoin/bitcoin/issues/32657#issuecomment-2928051271)
Does `-port` not work for this?

💬 pinheadmz commented on pull request "[28.x] Backport #31407":
(https://github.com/bitcoin/bitcoin/pull/32563#discussion_r2119694409)
This is the issue maybe? Is https://github.com/bitcoin/bitcoin/pull/31161 merged into 28.x at this point? There isn't a `bin/` directory `codesigning.tar.gz` archive, just a `dist/`

💬 rleed commented on issue "Add config option to set external P2P port to facilitate incoming connections":
(https://github.com/bitcoin/bitcoin/issues/32657#issuecomment-2928101091)
> Does `-port` not work for this?

As I understand it, the value specified by `-port` is currently advertised along with that of `-externalip` to allow incoming connections to a non-default port, but in a port-forwarding situation, this only works when the external forwarded port is identical to the local listening port. However, there are situations where this is not practical. Being able to specify the external port independently would provide a general solution.

💬 ajtowns commented on pull request "init: deprecate `-blockmaxweight` startup option":
(https://github.com/bitcoin/bitcoin/pull/32654#issuecomment-2928112394)
> The reservedweight isn’t just for the coinbase it also applies to the block header and transaction count. It seems reasonable to use the blockreservedweight option to lower the block weight to the desired magnitude.

Well, you can't pad the block header or transaction count encoding? :)

I think it makes sense to combine the two values into one internal option that controls the maximum cumulative tx weight, but I think the options both individually make sense from a user's point of view. (
...

💬 pinheadmz commented on pull request "[28.x] Backport #31407":
(https://github.com/bitcoin/bitcoin/pull/32563#discussion_r2119730809)
By contrast, the 29.0 codesigning tar had `./bitcoin-29.0/bin/`

💬 sipa commented on issue "Add config option to set external P2P port to facilitate incoming connections":
(https://github.com/bitcoin/bitcoin/issues/32657#issuecomment-2928207022)
I see. I believe this already works, you can add a port number to the `externalip=` argument.

💬 John-zhan commented on issue "windows: depends config fails":
(https://github.com/bitcoin/bitcoin/issues/32578#issuecomment-2928225261)
> [@John-zhan](https://github.com/John-zhan)
>
> You could use the same workaround as we use in the CI. See [#32184](https://github.com/bitcoin/bitcoin/pull/32184).



> [@John-zhan](https://github.com/John-zhan) does that work for you?
Oh, no. I'm so sorry. I just execute `rd /s /q build && del /f /q CMakeCache.txt && rd /s /q CMakeFiles`。
Then `cmake -B build --preset vs2022-static` and now the same error log in the output.

build\vcpkg_installed\vcpkg\blds\libevent\config-x64-windows-static-
...