✅ achow101 closed an issue: "."
(https://github.com/bitcoin/bitcoin/issues/32637)

💬 Sjors commented on pull request "build: Add resource file and manifest to `bitcoin.exe`":
(https://github.com/bitcoin/bitcoin/pull/32634#issuecomment-2918500203)
Concept ACK, seems consistent with the other binaries. I made a note to test a guix build on Windows later.

💬 Sjors commented on pull request "ipc: add bitcoin-mine test program":
(https://github.com/bitcoin/bitcoin/pull/30437#issuecomment-2918504989)
When rebasing, you may also need to add a resource file like in #32634. Although we don't ship this binary for Windows builds yet, so maybe that can wait.

💬 Sjors commented on pull request "ipc: add bitcoin-mine test program":
(https://github.com/bitcoin/bitcoin/pull/30437#discussion_r2113347751)
IIRC we decided to not include spawning support just yet to keep it simple, so the comment may be outdated.

💬 Sjors commented on pull request "wallet: `addhdkey` RPC to add just keys to wallets via new `unused(KEY)` descriptor":
(https://github.com/bitcoin/bitcoin/pull/29136#issuecomment-2918537868)
re-utACK b4ef67a3971f19c939135aeec59f11c6250f5368

Changes seem to be due to #32475.

💬 strmfos commented on pull request "Replace dead gnome link notificator.cpp":
(https://github.com/bitcoin/bitcoin/pull/32629#discussion_r2113433282)
@hebasto

🤔 hebasto reviewed a pull request: "deps: Bump lief to 0.16.5"
(https://github.com/bitcoin/bitcoin/pull/32431#pullrequestreview-2877492771)
Tested b65a25d3d1b0e9b08c7cc102cafc0528b4eb7247:

```
Checking binary security...
Traceback (most recent call last):
File "/distsrc-base/distsrc-38d7664dc1a0-powerpc64-linux-gnu/contrib/guix/security-check.py", line 285, in <module>
for (name, func) in CHECKS[etype][arch]:
KeyError: ARCHITECTURES.UNKNOWN
```

👍 TheCharlatan approved a pull request: "test: add MAX_DISCONNECTED_TX_POOL_BYTES, chainlimits coverage"
(https://github.com/bitcoin/bitcoin/pull/32516#pullrequestreview-2877551270)
Thanks for entertaining my suggestion :)

ACK 84aa484d45e2fb3c1149941ef23779e4adb983d9

⚠️ fanquake reopened an issue: "seeds: seed.bitcoin.jonasschnelli.ch not returning results"
(https://github.com/bitcoin/bitcoin/issues/32590)
Also shown by [check-dnsseeds.py](https://github.com/bitcoin-core/bitcoin-maintainer-tools/blob/main/check-dnsseeds.py):
```bash
./check-dnsseeds.py
* mainnet
OK seed.bitcoin.sipa.be (39 results)
OK dnsseed.bluematt.me (31 results)
OK dnsseed.bitcoin.dashjr-list-of-p2p-nodes.us (35 results)
OK seed.bitcoinstats.com (24 results)
FAIL seed.bitcoin.jonasschnelli.ch
OK seed.btc.petertodd.net (37 results)
OK seed.bitcoin.sprovoost.nl (36 results)
OK dnsseed.emzy.de (40 results)
OK see
...

💬 fanquake commented on issue "seeds: seed.bitcoin.jonasschnelli.ch not returning results":
(https://github.com/bitcoin/bitcoin/issues/32590#issuecomment-2918785885)
I am seeing this again.

💬 polespinasa commented on pull request "rpc: generateblock to allow multiple outputs":
(https://github.com/bitcoin/bitcoin/pull/32468#discussion_r2113587244)
Is that possible without adding a new argument for single strings?

💬 fanquake commented on pull request "build: Add resource file and manifest to `bitcoin.exe`":
(https://github.com/bitcoin/bitcoin/pull/32634#issuecomment-2918864171)
Guix Build:
```bash
0762b5cbe6135d2e83b80f96248be668bb5ac514511b07f59fbd1df5094d9eee guix-build-dbb2d4c3d547/output/aarch64-linux-gnu/SHA256SUMS.part
c65f1e1fe6feb729acd0b987066d7131e5e7220c1e45c6731f9e46e1b2dca187 guix-build-dbb2d4c3d547/output/aarch64-linux-gnu/bitcoin-dbb2d4c3d547-aarch64-linux-gnu-debug.tar.gz
05e4220765d4c85c5bfe89392e264b0c0cd6bd093fed2eb025f33cd9180f220c guix-build-dbb2d4c3d547/output/aarch64-linux-gnu/bitcoin-dbb2d4c3d547-aarch64-linux-gnu.tar.gz
e0bb9020320a12ca
...

🚀 fanquake merged a pull request: "build: Add resource file and manifest to `bitcoin.exe`"
(https://github.com/bitcoin/bitcoin/pull/32634)

📝 l0rinc opened a pull request: "blocks: force hash validations of blocks read from disk explicit"
(https://github.com/bitcoin/bitcoin/pull/32638)
A follow-up to https://github.com/bitcoin/bitcoin/pull/32487#discussion_r2094072165, after which validating the hash of a read block from disk doesn't incur the cost of calculating its hash anymore.

### Summary

This PR adds explicit checks that the read block header's hash matches the one we were expecting.

### Context

After the previous PR, validating a block's hash during read operations became essentially free. This PR leverages that by requiring callers to provide a block's expec
...

🚀 fanquake merged a pull request: "test: add MAX_DISCONNECTED_TX_POOL_BYTES, chainlimits coverage"
(https://github.com/bitcoin/bitcoin/pull/32516)

🤔 dergoegge reviewed a pull request: "refactor: Convert GenTxid to `std::variant`"
(https://github.com/bitcoin/bitcoin/pull/32631#pullrequestreview-2875707019)
Concept ACK

I'm not sure if the intermediate commits make things better here. Looking at the final diff seems simple enough.

💬 dergoegge commented on pull request "refactor: Convert GenTxid to `std::variant`":
(https://github.com/bitcoin/bitcoin/pull/32631#discussion_r2112292253)
```suggestion
Assume(peer->m_wtxid_relay == std::holds_alternative<Wtxid>(hash));
CInv inv(peer->m_wtxid_relay ? MSG_WTX : MSG_TX, hash.ToUint256());
```

💬 dergoegge commented on pull request "refactor: Convert GenTxid to `std::variant`":
(https://github.com/bitcoin/bitcoin/pull/32631#discussion_r2112303886)
not that it really matters but could do

```suggestion
std::optional<Txid> rejected_parent_reconsiderable;
```

🚀 fanquake merged a pull request: "log: Additional compact block logging"
(https://github.com/bitcoin/bitcoin/pull/32582)

💬 l0rinc commented on pull request "blocks: avoid recomputing block header hash in `ReadBlock`":
(https://github.com/bitcoin/bitcoin/pull/32487#issuecomment-2918910127)
Thanks for the reviews and the suggestions - added https://github.com/bitcoin/bitcoin/pull/32638 as a follow-up which enforces most remaining usages of `ReadBlock` to validate their hash.