Bitcoin Core Github
44 subscribers
121K links
Download Telegram
🚀 achow101 merged a pull request: "rpc: Round verificationprogress to 1 for a recent tip"
(https://github.com/bitcoin/bitcoin/pull/32528)
💬 adyshimony commented on pull request "walletdb: Log additional exception error messages for corrupted wallets":
(https://github.com/bitcoin/bitcoin/pull/32598#discussion_r2110617435)
nit: const std::runtime_error& e
💬 ajtowns commented on issue "Remove Ambiguity of Script ASM Hex and Decimal Integer Representations":
(https://github.com/bitcoin/bitcoin/issues/27795#issuecomment-2914564531)
I've had a go at implementing the above approach; code is at https://github.com/ajtowns/bitcoin/commits/202505-asmdecode/

For testing purposes I've changed the decodescript rpc to accept assembly as input, since that's now a superset of hex encoding. I've also done the round-trip fuzzing in the script -> assembly -> script direction; it seems to work so far.

Examples:

```sh
$ bitcoin-cli -regtest decodescript '51204af12dcd91328acf048740f90666e4f4a88d809f0882ad6f2b4440ddae78cb43' | jq -r .asm

...
💬 ajtowns commented on pull request "Fix ASM ambiguity":
(https://github.com/bitcoin/bitcoin/pull/28824#issuecomment-2914569029)
for anyone following this pr but not the issue, https://github.com/bitcoin/bitcoin/issues/27795#issuecomment-2914564531
💬 davidgumberg commented on pull request "p2p: Drop unsolicited CMPCTBLOCK from non-HB peer":
(https://github.com/bitcoin/bitcoin/pull/32606#issuecomment-2914621423)
Rebased to address @ajtowns and @mzumsande feedback.
💬 adyshimony commented on pull request "walletdb: Log additional exception error messages for corrupted wallets":
(https://github.com/bitcoin/bitcoin/pull/32598#discussion_r2110720147)
nit: pwallet->WalletLogPrintf("Error loading wallet - runtime error: %s\n", e.what());
💬 davidgumberg commented on pull request "deps: Bump lief to 0.16.5":
(https://github.com/bitcoin/bitcoin/pull/32431#discussion_r2110727815)
Good catch, I've removed this.
💬 davidgumberg commented on pull request "deps: Bump lief to 0.16.5":
(https://github.com/bitcoin/bitcoin/pull/32431#discussion_r2110727951)
Thanks, fixed.
💬 davidgumberg commented on pull request "deps: Bump lief to 0.16.5":
(https://github.com/bitcoin/bitcoin/pull/32431#issuecomment-2914679651)
Thanks for the suggested fix @hebasto, bumping the guix time machine to [a786cd333c738dacdf156752b428f572b31382b0](https://codeberg.org/guix/guix/commit/a786cd333c738dacdf156752b428f572b31382b0) seems to fix building lief 0.16.5. But, it introduces other, unrelated issues with the guix build, so I've rebased on the time machine change, but leaving this as draft for now while investigating.

<details> <summary> Error in riscv64 build </summary>

```
- /tmp/guix-build-glibc-cross-riscv64-lin
...
💬 sipa commented on pull request "cluster mempool: add TxGraph reorg functionality":
(https://github.com/bitcoin/bitcoin/pull/31553#discussion_r2110817020)
Done.
💬 sipa commented on pull request "cluster mempool: add TxGraph reorg functionality":
(https://github.com/bitcoin/bitcoin/pull/31553#discussion_r2110822058)
Added a commit with a test like this, with some changes. LMK what you think.
💬 sipa commented on pull request "cluster mempool: add TxGraph reorg functionality":
(https://github.com/bitcoin/bitcoin/pull/31553#discussion_r2110821680)
Done. Also organized the fields of `struct TrimTxData` a bit more logically, into "Populated by Cluster::AppendTxData" and "Only used internally in TxGraphImpl::Trim" sections.
💬 sipa commented on pull request "cluster mempool: add TxGraph reorg functionality":
(https://github.com/bitcoin/bitcoin/pull/31553#discussion_r2110821096)
Done.
💬 sipa commented on pull request "cluster mempool: add TxGraph reorg functionality":
(https://github.com/bitcoin/bitcoin/pull/31553#discussion_r2110821027)
Done.
💬 sipa commented on pull request "cluster mempool: add TxGraph reorg functionality":
(https://github.com/bitcoin/bitcoin/pull/31553#discussion_r2110820886)
Done.
💬 sipa commented on pull request "cluster mempool: add TxGraph reorg functionality":
(https://github.com/bitcoin/bitcoin/pull/31553#discussion_r2110820614)
Forgot to take this. Will leave open for now.
💬 sipa commented on pull request "cluster mempool: add TxGraph reorg functionality":
(https://github.com/bitcoin/bitcoin/pull/31553#discussion_r2110820827)
Done.
💬 sipa commented on pull request "cluster mempool: add TxGraph reorg functionality":
(https://github.com/bitcoin/bitcoin/pull/31553#discussion_r2110819198)
Done.
💬 sipa commented on pull request "cluster mempool: add TxGraph reorg functionality":
(https://github.com/bitcoin/bitcoin/pull/31553#discussion_r2110820744)
Done.
💬 sipa commented on pull request "cluster mempool: add TxGraph reorg functionality":
(https://github.com/bitcoin/bitcoin/pull/31553#discussion_r2110820382)
I've written a test based on this, which randomly adds dependencies but in a "directed" sense that never introduces cycles (rather than just has 2 specific scenarios).