🤔 mzumsande reviewed a pull request: "p2p: Drop unsolicited CMPCTBLOCK from non-HB peer"
(https://github.com/bitcoin/bitcoin/pull/32606#pullrequestreview-2872405952)
Concept ACK
In the commit message:
"making it only possible for peers selected as high bandwidth to discover a node's
mempool" is a bit too strong, since mempools are discoverable, just not transactions that were added to them after the last inv to the peer.
(https://github.com/bitcoin/bitcoin/pull/32606#pullrequestreview-2872405952)
Concept ACK
In the commit message:
"making it only possible for peers selected as high bandwidth to discover a node's
mempool" is a bit too strong, since mempools are discoverable, just not transactions that were added to them after the last inv to the peer.
🚀 achow101 merged a pull request: "blocks: avoid recomputing block header hash in `ReadBlock`"
(https://github.com/bitcoin/bitcoin/pull/32487)
(https://github.com/bitcoin/bitcoin/pull/32487)
💬 enirox001 commented on pull request "kernel: Separate UTXO set access from validation functions":
(https://github.com/bitcoin/bitcoin/pull/32317#issuecomment-2913994757)
Concept ACK. I'll be conducting a detailed commit-by-commit code review shortly.
(https://github.com/bitcoin/bitcoin/pull/32317#issuecomment-2913994757)
Concept ACK. I'll be conducting a detailed commit-by-commit code review shortly.
🤔 janb84 reviewed a pull request: "wallet, rpc: Return normalized descriptor in parent_descs"
(https://github.com/bitcoin/bitcoin/pull/32594#pullrequestreview-2872621106)
re ACK fdabfc7b01ec2cff5f2356e1b13b5537d30dbaf8
Changes since last ACK:
- removal of erroneous / double comment
- rename of variable to explicit make clear it's a dummy
(https://github.com/bitcoin/bitcoin/pull/32594#pullrequestreview-2872621106)
re ACK fdabfc7b01ec2cff5f2356e1b13b5537d30dbaf8
Changes since last ACK:
- removal of erroneous / double comment
- rename of variable to explicit make clear it's a dummy
💬 instagibbs commented on pull request "test: add MAX_DISCONNECTED_TX_POOL_BYTES, chainlimits coverage":
(https://github.com/bitcoin/bitcoin/pull/32516#discussion_r2110266152)
done
(https://github.com/bitcoin/bitcoin/pull/32516#discussion_r2110266152)
done
💬 instagibbs commented on pull request "test: add MAX_DISCONNECTED_TX_POOL_BYTES, chainlimits coverage":
(https://github.com/bitcoin/bitcoin/pull/32516#discussion_r2110266257)
done
(https://github.com/bitcoin/bitcoin/pull/32516#discussion_r2110266257)
done
💬 instagibbs commented on pull request "test: add MAX_DISCONNECTED_TX_POOL_BYTES, chainlimits coverage":
(https://github.com/bitcoin/bitcoin/pull/32516#discussion_r2110266338)
deleted
(https://github.com/bitcoin/bitcoin/pull/32516#discussion_r2110266338)
deleted
💬 instagibbs commented on pull request "test: add MAX_DISCONNECTED_TX_POOL_BYTES, chainlimits coverage":
(https://github.com/bitcoin/bitcoin/pull/32516#discussion_r2110266413)
done
(https://github.com/bitcoin/bitcoin/pull/32516#discussion_r2110266413)
done
💬 instagibbs commented on pull request "test: add MAX_DISCONNECTED_TX_POOL_BYTES, chainlimits coverage":
(https://github.com/bitcoin/bitcoin/pull/32516#discussion_r2110266477)
done
(https://github.com/bitcoin/bitcoin/pull/32516#discussion_r2110266477)
done
💬 instagibbs commented on pull request "test: add MAX_DISCONNECTED_TX_POOL_BYTES, chainlimits coverage":
(https://github.com/bitcoin/bitcoin/pull/32516#discussion_r2110266583)
did a proper reorg using blocktools to prep the fork.
(https://github.com/bitcoin/bitcoin/pull/32516#discussion_r2110266583)
did a proper reorg using blocktools to prep the fork.
💬 achow101 commented on pull request "log: print reason when writing chainstate":
(https://github.com/bitcoin/bitcoin/pull/32404#issuecomment-2914091081)
ACK 53e9b71b2fd59c18b75e45e3a24c39182c20a59e
(https://github.com/bitcoin/bitcoin/pull/32404#issuecomment-2914091081)
ACK 53e9b71b2fd59c18b75e45e3a24c39182c20a59e
🚀 achow101 merged a pull request: "log: print reason when writing chainstate"
(https://github.com/bitcoin/bitcoin/pull/32404)
(https://github.com/bitcoin/bitcoin/pull/32404)
💬 maflcko commented on pull request "test: add MAX_DISCONNECTED_TX_POOL_BYTES, chainlimits coverage":
(https://github.com/bitcoin/bitcoin/pull/32516#discussion_r2110310294)
style nit: either `to kick` or `kicks`
(feel free to ignore)
(https://github.com/bitcoin/bitcoin/pull/32516#discussion_r2110310294)
style nit: either `to kick` or `kicks`
(feel free to ignore)
💬 adyshimony commented on pull request "wallet, rpc, gui: List legacy wallets with a message about migration":
(https://github.com/bitcoin/bitcoin/pull/32619#issuecomment-2914132965)
Test ACK [f3a444c](https://github.com/bitcoin/bitcoin/pull/32619/commits/f3a444c45fb4bf4e51d53ebf1cf4c2631ded481c)
listwalletdir:
```
bitcoin-cli listwalletdir
{
"wallets": [
{
"name": "legacy_0.15_ver",
"warnings": [
"This wallet is a legacy wallet and will need to be migrated with migratewallet before it can be loaded"
]
},
{
"name": "test_32597_wallet",
"warnings": [
]
}
]
}
```
QT "Open Wallet" me
...
(https://github.com/bitcoin/bitcoin/pull/32619#issuecomment-2914132965)
Test ACK [f3a444c](https://github.com/bitcoin/bitcoin/pull/32619/commits/f3a444c45fb4bf4e51d53ebf1cf4c2631ded481c)
listwalletdir:
```
bitcoin-cli listwalletdir
{
"wallets": [
{
"name": "legacy_0.15_ver",
"warnings": [
"This wallet is a legacy wallet and will need to be migrated with migratewallet before it can be loaded"
]
},
{
"name": "test_32597_wallet",
"warnings": [
]
}
]
}
```
QT "Open Wallet" me
...
💬 achow101 commented on pull request "qa: feature_framework_startup_failures.py fixes & improvements (#30660 follow-up)":
(https://github.com/bitcoin/bitcoin/pull/32509#issuecomment-2914136270)
ACK bf950c4544d3a8478b46faf0b93c0dc647274c9b
(https://github.com/bitcoin/bitcoin/pull/32509#issuecomment-2914136270)
ACK bf950c4544d3a8478b46faf0b93c0dc647274c9b
✅ achow101 closed an issue: "test: feature_framework_startup_failures.py fails with `--timeout-factor=0`"
(https://github.com/bitcoin/bitcoin/issues/32506)
(https://github.com/bitcoin/bitcoin/issues/32506)
🚀 achow101 merged a pull request: "qa: feature_framework_startup_failures.py fixes & improvements (#30660 follow-up)"
(https://github.com/bitcoin/bitcoin/pull/32509)
(https://github.com/bitcoin/bitcoin/pull/32509)
💬 achow101 commented on pull request "refactor: validation: mark CheckBlockIndex as const":
(https://github.com/bitcoin/bitcoin/pull/32364#issuecomment-2914316033)
ACK 3e6ac5bf772751c66cdcd015dcb7e6ce4ea2cc77
(https://github.com/bitcoin/bitcoin/pull/32364#issuecomment-2914316033)
ACK 3e6ac5bf772751c66cdcd015dcb7e6ce4ea2cc77
🤔 w0xlt reviewed a pull request: "wallet, rpc, gui: List legacy wallets with a message about migration"
(https://github.com/bitcoin/bitcoin/pull/32619#pullrequestreview-2872880040)
Code Review ACK https://github.com/bitcoin/bitcoin/pull/32619/commits/f3a444c45fb4bf4e51d53ebf1cf4c2631ded481c
(https://github.com/bitcoin/bitcoin/pull/32619#pullrequestreview-2872880040)
Code Review ACK https://github.com/bitcoin/bitcoin/pull/32619/commits/f3a444c45fb4bf4e51d53ebf1cf4c2631ded481c
🤔 w0xlt reviewed a pull request: "fuzz: wallet: add target for `MigrateToDescriptor`"
(https://github.com/bitcoin/bitcoin/pull/32624#pullrequestreview-2872882290)
Approach ACK
(https://github.com/bitcoin/bitcoin/pull/32624#pullrequestreview-2872882290)
Approach ACK