👍 hodlinator approved a pull request: "policy: uncap datacarrier by default"
(https://github.com/bitcoin/bitcoin/pull/32406#pullrequestreview-2870311100)
ACK 35bcd8eed38130445aef5ebe217ab42248fa6f18

### Concept

I understand node runners feeling like their agency would be restricted by deprecating and later removing this limit. However, I have not encountered any strong technical or incentive compatible argument in favor of keeping it. Deprecating and giving a little bit more opportunity for such an argument to appear before removal seems like a diplomatically acceptable solution.

I don't feel strongly enough about this to have kicked thi
...

💬 hodlinator commented on pull request "policy: uncap datacarrier by default":
(https://github.com/bitcoin/bitcoin/pull/32406#discussion_r2108669091)
nit: `MAX_STANDARD_TX_WEIGHT` (400000) is in vbytes AFAIK, but since you divide by `WITNESS_SCALE_FACTOR` the comment should say the unit is bytes (not vbytes), right?

💬 fanquake commented on pull request "guix: accomodate migration to codeberg":
(https://github.com/bitcoin/bitcoin/pull/32439#issuecomment-2911944384)
Guix Build:
```bash
2d907a08701bbfa9a165581f69a997f5be0b3e0c7ee92f1bd5094df729430485 guix-build-ca9bb622af68/output/aarch64-linux-gnu/SHA256SUMS.part
f603a29e4eadeec26a7e82c882837d5369a35d65b3f283e50d72dd2fc7f9ba9d guix-build-ca9bb622af68/output/aarch64-linux-gnu/bitcoin-ca9bb622af68-aarch64-linux-gnu-debug.tar.gz
558bd5cc61134adb2c2a4120629288ffcd53162ffb1f787e95e56762340efce1 guix-build-ca9bb622af68/output/aarch64-linux-gnu/bitcoin-ca9bb622af68-aarch64-linux-gnu.tar.gz
23b3e836a56c8212
...

💬 maflcko commented on pull request "rpc: Round verificationprogress to 1 for a recent tip":
(https://github.com/bitcoin/bitcoin/pull/32528#issuecomment-2911998654)
If you reviewed the code by a commit hash, and you want to express your review, see [the guideline](https://github.com/bitcoin/bitcoin/blob/master/CONTRIBUTING.md#code-review) for information on the review process. (You'll have to include the commit hash in your review)

I'll leave the regtest stuff to a follow-up, so that it can be evaluated independently.

🤔 maflcko reviewed a pull request: "guix: accomodate migration to codeberg"
(https://github.com/bitcoin/bitcoin/pull/32439#pullrequestreview-2870539601)
review ACK ca9bb622af68f0b89b1e5c8bc5726b60dec823a3

💬 maflcko commented on pull request "guix: accomodate migration to codeberg":
(https://github.com/bitcoin/bitcoin/pull/32439#discussion_r2108829918)
```suggestion
- A commit to skip this test is included since Guix 1.4.0:
```

💬 fanquake commented on pull request "guix: accomodate migration to codeberg":
(https://github.com/bitcoin/bitcoin/pull/32439#discussion_r2108834816)
Thanks, added

💬 maflcko commented on pull request "contrib: add xor-blocks tool to obfuscate blocks directory":
(https://github.com/bitcoin/bitcoin/pull/32451#issuecomment-2912031083)
> > I wonder if -reindex could be taught to do this instead.
>
> @maflcko That would be convenient, but a reindex is a much longer task than this tool. So I don't think "instead", but rather "also".

Maybe just from a code-review/maintenance perspective this is preferable, given that the feature implemented here is quite tricky to get right for all edge cases by (re-)implementing the C++ logic.

💬 maflcko commented on pull request "guix: accomodate migration to codeberg":
(https://github.com/bitcoin/bitcoin/pull/32439#issuecomment-2912033007)
lgtm ACK c8d9baae942c94d64ce47ae8f67d3710e6a296bd

👍 TheCharlatan approved a pull request: "test: Add missing ipc subtree to lint"
(https://github.com/bitcoin/bitcoin/pull/32623#pullrequestreview-2870565681)
ACK fa2bf6bdb7e5f8940fe4bce1aaab29bf2e063b49

👍 TheCharlatan approved a pull request: "test: fix pushdata scripts"
(https://github.com/bitcoin/bitcoin/pull/32270#pullrequestreview-2870576815)
Re-ACK f66b14d2ecb0db991d255be49d6ff6ec361569b5

💬 hebasto commented on pull request "guix: accomodate migration to codeberg":
(https://github.com/bitcoin/bitcoin/pull/32439#discussion_r2108867196)
While this is correct, the mailing list [refers](https://lists.gnu.org/archive/html/info-guix/2025-05/msg00002.html) to `https://git.guix.gnu.org/guix.git` as the canonical URL. Should we use that instead?

👍 TheCharlatan approved a pull request: "test: fix and augment block tests of invalid_txs"
(https://github.com/bitcoin/bitcoin/pull/32591#pullrequestreview-2870607751)
ACK 8fcd6845052354fad80ae7e5feda3f6a2e441e12

🚀 fanquake merged a pull request: "test: fix pushdata scripts"
(https://github.com/bitcoin/bitcoin/pull/32270)

💬 fanquake commented on pull request "guix: accomodate migration to codeberg":
(https://github.com/bitcoin/bitcoin/pull/32439#discussion_r2108890579)
Given that's just redirecting to `https://codeberg.org/guix/guix.git`, and the frequent issues/downtime we've seen lately, I'd rather not add a hop via `savannah.gnu.org`.

👍 hebasto approved a pull request: "guix: accomodate migration to codeberg"
(https://github.com/bitcoin/bitcoin/pull/32439#pullrequestreview-2870641995)
ACK c8d9baae942c94d64ce47ae8f67d3710e6a296bd.

My Guix build is coming.

💬 fanquake commented on issue "windows: depends config fails":
(https://github.com/bitcoin/bitcoin/issues/32578#issuecomment-2912140913)
@John-zhan does that work for you?

📝 brunoerg opened a pull request: "fuzz: wallet: add target for `MigrateToDescriptor`"
(https://github.com/bitcoin/bitcoin/pull/32624)
This PR adds fuzz coverage for the scriptpubkeyman migration (`MigrateToDescriptor`). Note that it's a test for the migration of the scriptpubkey manager, not for the whole migration process as tried in #29694, because:
1) The wallet migration deals with DBs which is expensive for fuzzing (was getting around 3 exec/s);
2) Mocking would require lots of refactors.

This target loads keys, HDChain (even inactive ones), watch only and might add tons of different scripts, then calls `MigrateToDes
...

💬 brunoerg commented on pull request "fuzz: wallet: add target for spkm migration":
(https://github.com/bitcoin/bitcoin/pull/29694#issuecomment-2912181133)
Closing in favor of #32624.

✅ brunoerg closed a pull request: "fuzz: wallet: add target for spkm migration"
(https://github.com/bitcoin/bitcoin/pull/29694)