💬 fjahr commented on pull request "threading: remove ancient CRITICAL_SECTION macros":
(https://github.com/bitcoin/bitcoin/pull/32592#issuecomment-2909347965)
Concept ACK

🤔 BrandonOdiwuor reviewed a pull request: "test: fix and augment block tests of invalid_txs"
(https://github.com/bitcoin/bitcoin/pull/32591#pullrequestreview-2868092029)
Code Review ACK 8fcd6845052354fad80ae7e5feda3f6a2e441e12

💬 polespinasa commented on pull request "rpc: generateblock to allow multiple outputs":
(https://github.com/bitcoin/bitcoin/pull/32468#discussion_r2107133216)
done!

💬 polespinasa commented on pull request "rpc: generateblock to allow multiple outputs":
(https://github.com/bitcoin/bitcoin/pull/32468#issuecomment-2909407379)
- OP_RETURN fallback if no address or descriptor set is provided.
- A few tests added to test new functionalities

💬 polespinasa commented on pull request "rpc: generateblock to allow multiple outputs":
(https://github.com/bitcoin/bitcoin/pull/32468#discussion_r2107136482)
I've set "output" as optional but still I have to provide at least an empty list. I'm unable to see how to make it fully optional.
```
$ ./bitcoin-cli -rpcport=18443 generateblock
error code: -3
error message:
JSON value of type null is not of expected type array
```

```
$ ./bitcoin-cli -rpcport=18443 generateblock []
{
"hash": "25987bbfbce2be6c61393ed95340729ff2cc25c2b26db422b6e43c8a8f4558a0"
}
```

💬 1440000bytes commented on pull request "[Draft/POC] Add secp256k1-based HPKE (Hybrid Public Key Encryption) For Payjoin v2":
(https://github.com/bitcoin/bitcoin/pull/32617#issuecomment-2909433769)
If [`rust-payjoin`](https://github.com/payjoin/rust-payjoin/tree/master/payjoin-cli) already works with bitcoin core wallet, why do we need to add anything in bitcoin core for payjoin?

💬 dergoegge commented on pull request "log: Mitigate disk filling attacks by rate limiting LogPrintf, LogInfo, LogWarning, LogError":
(https://github.com/bitcoin/bitcoin/pull/32604#issuecomment-2909514124)
Concept ACK

Thanks for picking this up!

💬 maflcko commented on pull request "rpc: generateblock to allow multiple outputs":
(https://github.com/bitcoin/bitcoin/pull/32468#discussion_r2107200827)
`get_array` is a check function to ensure the type is array. (The type null is not the type array, so the check fails)

The fix would be to not call `get_array` when the type is null.

💬 polespinasa commented on pull request "rpc: generateblock to allow multiple outputs":
(https://github.com/bitcoin/bitcoin/pull/32468#discussion_r2107340130)
oh you're right, solved :)

🤔 janb84 reviewed a pull request: "log: Mitigate disk filling attacks by rate limiting LogPrintf, LogInfo, LogWarning, LogError"
(https://github.com/bitcoin/bitcoin/pull/32604#pullrequestreview-2868443828)
ACK 0bc6ed61cfab6d97e74103efd41c46faf5941ff6

Ratelimits loging to disk if loggin exceeds 1 MiB in 1 hour (WINDOW_MAX_BYTES const & WINDOW_SIZE const)

- code review
- build & tested

💬 janb84 commented on pull request "log: Mitigate disk filling attacks by rate limiting LogPrintf, LogInfo, LogWarning, LogError":
(https://github.com/bitcoin/bitcoin/pull/32604#discussion_r2107350361)
nit: would be nice to align the other initializations to the new C++ 11 {} style in a follow up PR, to keep the code base consistent.

🤔 furszy reviewed a pull request: "Including exception what() in Runaway dialog box"
(https://github.com/bitcoin-core/gui/pull/876#pullrequestreview-2868183402)
> If an exception happens, including e.what() in the text passed to the dialog
box, so that the user can see it. This is in addition to any text from
getWarnings() that might already be present, separated by newlines if so.

Have you verified that we won't output the same error message twice?

💬 furszy commented on pull request "Including exception what() in Runaway dialog box":
(https://github.com/bitcoin-core/gui/pull/876#discussion_r2107175788)
const std::string&

💬 furszy commented on pull request "Including exception what() in Runaway dialog box":
(https://github.com/bitcoin-core/gui/pull/876#discussion_r2107175290)
`const std::string&`

💬 i-am-yuvi commented on pull request "p2p: protect addnode peers during IBD":
(https://github.com/bitcoin/bitcoin/pull/32051#issuecomment-2909841408)
Concept ACK

💬 janb84 commented on pull request "doc: Remove stale sections in dev notes":
(https://github.com/bitcoin/bitcoin/pull/32572#discussion_r2107410288)
I was under the impression that forking the bitcoin repository automatically setup GHA and enabled it. That was not correct, thanks for the clarification.

🤔 furszy reviewed a pull request: "threading: remove ancient CRITICAL_SECTION macros"
(https://github.com/bitcoin/bitcoin/pull/32592#pullrequestreview-2868540710)
Code review ACK ee98ad2e9d2be9a72c15c5c1ef93bfd3d5ed015c

🤔 rkrux reviewed a pull request: "wallet: Remove watchonly behavior and isminetypes"
(https://github.com/bitcoin/bitcoin/pull/32523#pullrequestreview-2866249442)
I'm sensing that, if feasible, maybe the first 4 commits can be a separate PR that removes the watch only stuff separately. Otherwise this is a bit too much to unpack in one shot - from data consistency POV.
The e6fd00372951bdc06462b74a9d078c33a5f75e78 commit contains few comment formatting related changes as well that are slightly distracting.

💬 rkrux commented on pull request "wallet: Remove watchonly behavior and isminetypes":
(https://github.com/bitcoin/bitcoin/pull/32523#discussion_r2105777713)
No filter passed now.

💬 rkrux commented on pull request "wallet: Remove watchonly behavior and isminetypes":
(https://github.com/bitcoin/bitcoin/pull/32523#discussion_r2105777223)
There is no filter passed anymore.