⚠️ Ciornenichii opened an issue: "Bitcoin"
(https://github.com/bitcoin/bitcoin/issues/32613)
(https://github.com/bitcoin/bitcoin/issues/32613)
✅ fanquake closed an issue: "Bitcoin"
(https://github.com/bitcoin/bitcoin/issues/32613)
(https://github.com/bitcoin/bitcoin/issues/32613)
💬 maflcko commented on pull request "rpc: generateblock to allow multiple outputs":
(https://github.com/bitcoin/bitcoin/pull/32468#discussion_r2106232962)
all those `raw(` can probably just be omitted and use the OP_RETURN fallback
(https://github.com/bitcoin/bitcoin/pull/32468#discussion_r2106232962)
all those `raw(` can probably just be omitted and use the OP_RETURN fallback
💬 andrewtoth commented on pull request "contrib: add xor-blocks tool to obfuscate blocks directory":
(https://github.com/bitcoin/bitcoin/pull/32451#discussion_r2106257312)
Done.
(https://github.com/bitcoin/bitcoin/pull/32451#discussion_r2106257312)
Done.
💬 andrewtoth commented on pull request "Broadcast own transactions only via short-lived Tor or I2P connections":
(https://github.com/bitcoin/bitcoin/pull/29415#issuecomment-2907963606)
re-ACK cedbc2cd99754c099e92f074e1d5566da265bf26
Changes from previously ACK'd 1c16944a4aff71e6560703916b11b2a544ea71ca - `git range-diff 99a4ddf5ab...1c16944a4a 7763e86afa...cedbc2cd99`
- CSempahoreGrant -> CountingSemaphoreGrant in c3ff0b2e46be289f7c8e4aa2ea72b18f853dc100
- CSemaphoreGrant::post -> CountingSempahoreGrant::release in c3ff0b2e46be289f7c8e4aa2ea72b18f853dc100
- CSempahore -> std::counting_sempahore in c3ff0b2e46be289f7c8e4aa2ea72b18f853dc100
- Removed some changes to `CWa
...
(https://github.com/bitcoin/bitcoin/pull/29415#issuecomment-2907963606)
re-ACK cedbc2cd99754c099e92f074e1d5566da265bf26
Changes from previously ACK'd 1c16944a4aff71e6560703916b11b2a544ea71ca - `git range-diff 99a4ddf5ab...1c16944a4a 7763e86afa...cedbc2cd99`
- CSempahoreGrant -> CountingSemaphoreGrant in c3ff0b2e46be289f7c8e4aa2ea72b18f853dc100
- CSemaphoreGrant::post -> CountingSempahoreGrant::release in c3ff0b2e46be289f7c8e4aa2ea72b18f853dc100
- CSempahore -> std::counting_sempahore in c3ff0b2e46be289f7c8e4aa2ea72b18f853dc100
- Removed some changes to `CWa
...
👍 andrewtoth approved a pull request: "log: print reason when writing chainstate"
(https://github.com/bitcoin/bitcoin/pull/32404#pullrequestreview-2866929261)
utACK 53e9b71b2fd59c18b75e45e3a24c39182c20a59e
(https://github.com/bitcoin/bitcoin/pull/32404#pullrequestreview-2866929261)
utACK 53e9b71b2fd59c18b75e45e3a24c39182c20a59e
📝 tnndbtc opened a pull request: "fee estimate test: fix #31944 by handling a legitimate scenario that …"
(https://github.com/bitcoin/bitcoin/pull/32615)
Fix a legitimate scenario that feerate is not always available, due to the execution path that current percentage is smaller than success break point, in TxConfirmStats::EstimateMedianVal (in src/policy/fees.cpp)
To reproduce/validate the issue, run the test with a specific randomseed: 2986529890161488286
build/test/functional/test_runner.py test/functional/feature_fee_estimation.py --randomseed=2986529890161488286 --tmpdir /tmp
More details can be found in discussion of https://github.
...
(https://github.com/bitcoin/bitcoin/pull/32615)
Fix a legitimate scenario that feerate is not always available, due to the execution path that current percentage is smaller than success break point, in TxConfirmStats::EstimateMedianVal (in src/policy/fees.cpp)
To reproduce/validate the issue, run the test with a specific randomseed: 2986529890161488286
build/test/functional/test_runner.py test/functional/feature_fee_estimation.py --randomseed=2986529890161488286 --tmpdir /tmp
More details can be found in discussion of https://github.
...
💬 tnndbtc commented on issue "Intermittent failure in feature_fee_estimation.py in check_raw_estimates feerate = float(e["feerate"]) KeyError: 'feerate'":
(https://github.com/bitcoin/bitcoin/issues/31944#issuecomment-2908043928)
Include @Empact who originally worked on this test to review PR# 32615
(https://github.com/bitcoin/bitcoin/issues/31944#issuecomment-2908043928)
Include @Empact who originally worked on this test to review PR# 32615
⚠️ lilliananderson600 opened an issue: "SOLUTIONS FOR QUICK CRYPTOCURRENCY RECOVERY HIRE FUNDS RECLAIMER COMPANY"
(https://github.com/bitcoin/bitcoin/issues/32616)
### Motivation
Last November, I fell victim to an elaborate romance scam one so deceptive that even my background working with the IRS didn’t shield me from its machinations. Despite my usual vigilance in financial matters, I was blindsided by a sophisticated crypto fraud, a trap that preyed on trust and exploited my willingness to believe. It began innocuously. I connected with someone on a dating app, and over weeks of seemingly genuine conversations, they ingratiated themselves into my life
...
(https://github.com/bitcoin/bitcoin/issues/32616)
### Motivation
Last November, I fell victim to an elaborate romance scam one so deceptive that even my background working with the IRS didn’t shield me from its machinations. Despite my usual vigilance in financial matters, I was blindsided by a sophisticated crypto fraud, a trap that preyed on trust and exploited my willingness to believe. It began innocuously. I connected with someone on a dating app, and over weeks of seemingly genuine conversations, they ingratiated themselves into my life
...
✅ pinheadmz closed an issue: "SOLUTIONS FOR QUICK CRYPTOCURRENCY RECOVERY HIRE FUNDS RECLAIMER COMPANY"
(https://github.com/bitcoin/bitcoin/issues/32616)
(https://github.com/bitcoin/bitcoin/issues/32616)
🤔 maflcko reviewed a pull request: "rest: fetch spent transaction outputs by blockhash"
(https://github.com/bitcoin/bitcoin/pull/32540#pullrequestreview-2867384351)
Please squash your commits according to https://github.com/bitcoin/bitcoin/blob/master/CONTRIBUTING.md#squashing-commits
lgtm ACK 9d7e23e2f505ce6cbe830fc607cf203b1a48ba0d
(https://github.com/bitcoin/bitcoin/pull/32540#pullrequestreview-2867384351)
Please squash your commits according to https://github.com/bitcoin/bitcoin/blob/master/CONTRIBUTING.md#squashing-commits
lgtm ACK 9d7e23e2f505ce6cbe830fc607cf203b1a48ba0d
💬 maflcko commented on pull request "rest: fetch spent transaction outputs by blockhash":
(https://github.com/bitcoin/bitcoin/pull/32540#discussion_r2106631113)
nit: clang-format new code?
(https://github.com/bitcoin/bitcoin/pull/32540#discussion_r2106631113)
nit: clang-format new code?
💬 romanz commented on pull request "rest: fetch spent transaction outputs by blockhash":
(https://github.com/bitcoin/bitcoin/pull/32540#discussion_r2106654018)
Thanks! Fixed in 1e2b26e4f8.
(https://github.com/bitcoin/bitcoin/pull/32540#discussion_r2106654018)
Thanks! Fixed in 1e2b26e4f8.
💬 maflcko commented on pull request "rest: fetch spent transaction outputs by blockhash":
(https://github.com/bitcoin/bitcoin/pull/32540#issuecomment-2908773615)
review ACK 1e2b26e4f8498a08072104b12759d91ef8b410db 👤
<details><summary>Show signature</summary>
Signature:
```
untrusted comment: signature from minisign secret key on empty file; verify via: minisign -Vm "${path_to_any_empty_file}" -P RWTRmVTMeKV5noAMqVlsMugDDCyyTSbA3Re5AkUrhvLVln0tSaFWglOw -x "${path_to_this_whole_four_line_signature_blob}"
RUTRmVTMeKV5npGrKx1nqXCw5zeVHdtdYURB/KlyA/LMFgpNCs+SkW9a8N95d+U4AP1RJMi+krxU1A3Yux4bpwZNLvVBKy0wLgM=
trusted comment: review ACK 1e2b26e4f849
...
(https://github.com/bitcoin/bitcoin/pull/32540#issuecomment-2908773615)
review ACK 1e2b26e4f8498a08072104b12759d91ef8b410db 👤
<details><summary>Show signature</summary>
Signature:
```
untrusted comment: signature from minisign secret key on empty file; verify via: minisign -Vm "${path_to_any_empty_file}" -P RWTRmVTMeKV5noAMqVlsMugDDCyyTSbA3Re5AkUrhvLVln0tSaFWglOw -x "${path_to_this_whole_four_line_signature_blob}"
RUTRmVTMeKV5npGrKx1nqXCw5zeVHdtdYURB/KlyA/LMFgpNCs+SkW9a8N95d+U4AP1RJMi+krxU1A3Yux4bpwZNLvVBKy0wLgM=
trusted comment: review ACK 1e2b26e4f849
...
💬 maflcko commented on pull request "blocks: avoid recomputing block header hash in `ReadBlock`":
(https://github.com/bitcoin/bitcoin/pull/32487#discussion_r2106734127)
nit: Can drop the 100 blocks and just use `TestingSetup`.
(https://github.com/bitcoin/bitcoin/pull/32487#discussion_r2106734127)
nit: Can drop the 100 blocks and just use `TestingSetup`.
💬 maflcko commented on pull request "blocks: avoid recomputing block header hash in `ReadBlock`":
(https://github.com/bitcoin/bitcoin/pull/32487#issuecomment-2908845905)
review ACK 8117c16fd7a0a5334fe63efaff94ea4e1d3cf851 🌋
<details><summary>Show signature</summary>
Signature:
```
untrusted comment: signature from minisign secret key on empty file; verify via: minisign -Vm "${path_to_any_empty_file}" -P RWTRmVTMeKV5noAMqVlsMugDDCyyTSbA3Re5AkUrhvLVln0tSaFWglOw -x "${path_to_this_whole_four_line_signature_blob}"
RUTRmVTMeKV5npGrKx1nqXCw5zeVHdtdYURB/KlyA/LMFgpNCs+SkW9a8N95d+U4AP1RJMi+krxU1A3Yux4bpwZNLvVBKy0wLgM=
trusted comment: review ACK 8117c16fd7a0
...
(https://github.com/bitcoin/bitcoin/pull/32487#issuecomment-2908845905)
review ACK 8117c16fd7a0a5334fe63efaff94ea4e1d3cf851 🌋
<details><summary>Show signature</summary>
Signature:
```
untrusted comment: signature from minisign secret key on empty file; verify via: minisign -Vm "${path_to_any_empty_file}" -P RWTRmVTMeKV5noAMqVlsMugDDCyyTSbA3Re5AkUrhvLVln0tSaFWglOw -x "${path_to_this_whole_four_line_signature_blob}"
RUTRmVTMeKV5npGrKx1nqXCw5zeVHdtdYURB/KlyA/LMFgpNCs+SkW9a8N95d+U4AP1RJMi+krxU1A3Yux4bpwZNLvVBKy0wLgM=
trusted comment: review ACK 8117c16fd7a0
...
💬 maflcko commented on pull request "index: Fix coinstats overflow and introduce index versioning":
(https://github.com/bitcoin/bitcoin/pull/30469#discussion_r2106750204)
It is "just" 20kB, but I think we'd want to avoid adding binary blobs to the repo at this point. At a minimum, it would be good to have a reason to do this.
The alternative of just using a previous release to create it on-demand has many benefits:
* It works on Windows as well
* It doesn't bloat the git history by 20+ kB forever
* It is easier to review and easier to adapt
(https://github.com/bitcoin/bitcoin/pull/30469#discussion_r2106750204)
It is "just" 20kB, but I think we'd want to avoid adding binary blobs to the repo at this point. At a minimum, it would be good to have a reason to do this.
The alternative of just using a previous release to create it on-demand has many benefits:
* It works on Windows as well
* It doesn't bloat the git history by 20+ kB forever
* It is easier to review and easier to adapt
💬 maflcko commented on pull request "test: fix and augment block tests of invalid_txs":
(https://github.com/bitcoin/bitcoin/pull/32591#issuecomment-2908905046)
review ACK 8fcd6845052354fad80ae7e5feda3f6a2e441e12 🔶
<details><summary>Show signature</summary>
Signature:
```
untrusted comment: signature from minisign secret key on empty file; verify via: minisign -Vm "${path_to_any_empty_file}" -P RWTRmVTMeKV5noAMqVlsMugDDCyyTSbA3Re5AkUrhvLVln0tSaFWglOw -x "${path_to_this_whole_four_line_signature_blob}"
RUTRmVTMeKV5npGrKx1nqXCw5zeVHdtdYURB/KlyA/LMFgpNCs+SkW9a8N95d+U4AP1RJMi+krxU1A3Yux4bpwZNLvVBKy0wLgM=
trusted comment: review ACK 8fcd68450523
...
(https://github.com/bitcoin/bitcoin/pull/32591#issuecomment-2908905046)
review ACK 8fcd6845052354fad80ae7e5feda3f6a2e441e12 🔶
<details><summary>Show signature</summary>
Signature:
```
untrusted comment: signature from minisign secret key on empty file; verify via: minisign -Vm "${path_to_any_empty_file}" -P RWTRmVTMeKV5noAMqVlsMugDDCyyTSbA3Re5AkUrhvLVln0tSaFWglOw -x "${path_to_this_whole_four_line_signature_blob}"
RUTRmVTMeKV5npGrKx1nqXCw5zeVHdtdYURB/KlyA/LMFgpNCs+SkW9a8N95d+U4AP1RJMi+krxU1A3Yux4bpwZNLvVBKy0wLgM=
trusted comment: review ACK 8fcd68450523
...
📝 w0xlt opened a pull request: "[Draft/POC] Add secp256k1-based HPKE (Hybrid Public Key Encryption) For Payjoin v2"
(https://github.com/bitcoin/bitcoin/pull/32617)
This PR introduces an implementation of Hybrid Public Key Encryption (HPKE) using a secp256k1-based Diffie-Hellman KEM (per RFC 9180 and "secp256k1-based DHKEM for HPKE" specification). It provides the core cryptographic component needed to enable the Payjoin v2 protocol.
This is an exploratory PR intended to kickstart discussion on adding Payjoin v2 support to Bitcoin Core – feedback and reviews are very welcome.
Payjoin v2 makes use of a protocol called Oblivious HTTP (OHTTP) to strip cl
...
(https://github.com/bitcoin/bitcoin/pull/32617)
This PR introduces an implementation of Hybrid Public Key Encryption (HPKE) using a secp256k1-based Diffie-Hellman KEM (per RFC 9180 and "secp256k1-based DHKEM for HPKE" specification). It provides the core cryptographic component needed to enable the Payjoin v2 protocol.
This is an exploratory PR intended to kickstart discussion on adding Payjoin v2 support to Bitcoin Core – feedback and reviews are very welcome.
Payjoin v2 makes use of a protocol called Oblivious HTTP (OHTTP) to strip cl
...
📝 w0xlt converted_to_draft a pull request: "[Draft/POC] Add secp256k1-based HPKE (Hybrid Public Key Encryption) For Payjoin v2"
(https://github.com/bitcoin/bitcoin/pull/32617)
This PR introduces an implementation of Hybrid Public Key Encryption (HPKE) using a secp256k1-based Diffie-Hellman KEM (per RFC 9180 and "secp256k1-based DHKEM for HPKE" specification). It provides the core cryptographic component needed to enable the Payjoin v2 protocol.
This is an exploratory PR intended to kickstart discussion on adding Payjoin v2 support to Bitcoin Core – feedback and reviews are very welcome.
Payjoin v2 makes use of a protocol called Oblivious HTTP (OHTTP) to strip cl
...
(https://github.com/bitcoin/bitcoin/pull/32617)
This PR introduces an implementation of Hybrid Public Key Encryption (HPKE) using a secp256k1-based Diffie-Hellman KEM (per RFC 9180 and "secp256k1-based DHKEM for HPKE" specification). It provides the core cryptographic component needed to enable the Payjoin v2 protocol.
This is an exploratory PR intended to kickstart discussion on adding Payjoin v2 support to Bitcoin Core – feedback and reviews are very welcome.
Payjoin v2 makes use of a protocol called Oblivious HTTP (OHTTP) to strip cl
...