💬 MarcoFalke commented on pull request "Add a "tx output spender" index":
(https://github.com/bitcoin/bitcoin/pull/24539#issuecomment-1553136911)
(Needs rebase)

💬 MarcoFalke commented on pull request "Improve display address handling for external signer":
(https://github.com/bitcoin/bitcoin/pull/24313#issuecomment-1553138296)
Needs rebase

💬 fanquake commented on pull request "build: Bump minimum supported GCC to g++-9":
(https://github.com/bitcoin/bitcoin/pull/27662#issuecomment-1553152251)
Guix Build:
```bash
eebee5018a0bfa5e6de1ebb58522457f0f35f5636e71990af35d5b10c9ebb296 guix-build-fa953f15bfcf/output/aarch64-linux-gnu/SHA256SUMS.part
7c7a69bb6cce74a31cd747f4234332de83d201d0b6426aac3095a16b9eb09e33 guix-build-fa953f15bfcf/output/aarch64-linux-gnu/bitcoin-fa953f15bfcf-aarch64-linux-gnu-debug.tar.gz
869ae0cd106fc82ed075f1efa50993dbe588aad9316579397de594e46f18155e guix-build-fa953f15bfcf/output/aarch64-linux-gnu/bitcoin-fa953f15bfcf-aarch64-linux-gnu.tar.gz
61764214a68b0602
...

📝 fanquake opened a pull request: "doc: add historical release notes for 24.1 & 23.2"
(https://github.com/bitcoin/bitcoin/pull/27698)
Also for linking to from `Releases`.

💬 achow101 commented on pull request "doc: add historical release notes for 24.1 & 23.2":
(https://github.com/bitcoin/bitcoin/pull/27698#issuecomment-1553174256)
ACK e0f69a708154c41a34ea72ae2ae730fca7407cda

🚀 achow101 merged a pull request: "doc: add historical release notes for 24.1 & 23.2"
(https://github.com/bitcoin/bitcoin/pull/27698)

💬 sdaftuar commented on pull request "Parallel compact block downloads, take 3":
(https://github.com/bitcoin/bitcoin/pull/27626#issuecomment-1553177921)
ACK 42c2696ae58e07de005edf1dda952761f8c9008e

💬 achow101 commented on issue "bitcoin-qt generates bad psbt":
(https://github.com/bitcoin/bitcoin/issues/27697#issuecomment-1553178396)
I think https://github.com/bitcoin-core/gui/pull/687 was the fix.

💬 fanquake commented on issue "bitcoin-qt generates bad psbt":
(https://github.com/bitcoin/bitcoin/issues/27697#issuecomment-1553183578)
> I think https://github.com/bitcoin-core/gui/pull/687 was the fix.

Right. So fixed in 24.1 as well.

💬 MarcoFalke commented on issue "bitcoin-qt generates bad psbt":
(https://github.com/bitcoin/bitcoin/issues/27697#issuecomment-1553192600)
What was the backport commit?

💬 MarcoFalke commented on issue "bitcoin-qt generates bad psbt":
(https://github.com/bitcoin/bitcoin/issues/27697#issuecomment-1553194643)
Backported in 0da38b6b0e74ee4479553d2bf611593fa51d54b3

💬 fanquake commented on issue "bitcoin-qt generates bad psbt":
(https://github.com/bitcoin/bitcoin/issues/27697#issuecomment-1553195015)
https://github.com/bitcoin/bitcoin/commit/0662105e884dce3eae9d3eb0b0d49600c1260b90

💬 fanquake commented on pull request "Load PSBTs using istreambuf_iterator rather than istream_iterator":
(https://github.com/bitcoin-core/gui/pull/687#issuecomment-1553195889)
Removing label as this was backported: https://github.com/bitcoin/bitcoin/commit/0662105e884dce3eae9d3eb0b0d49600c1260b90.

💬 achow101 commented on pull request "wallet: fix deadlock in bdb read write operation":
(https://github.com/bitcoin/bitcoin/pull/27556#issuecomment-1553197160)
ACK 69d43905b7f1d4849dfaea1b5744ee473ccc8744

💬 sdaftuar commented on pull request "test: Add test to check tx in the last block can be downloaded":
(https://github.com/bitcoin/bitcoin/pull/27695#issuecomment-1553197793)
ACK fa4c16b186a34f4172deda617166813c8cb92c59

💬 kallerosenbaum commented on issue "bitcoin-qt fails to parse binary psbt file":
(https://github.com/bitcoin/bitcoin/issues/27697#issuecomment-1553202155)
Thanks for you quick responses. Will use 25rc2 instead then.

🚀 achow101 merged a pull request: "wallet: fix deadlock in bdb read write operation"
(https://github.com/bitcoin/bitcoin/pull/27556)

💬 sdaftuar commented on pull request "p2p: Stop relaying non-mempool txs":
(https://github.com/bitcoin/bitcoin/pull/27625#issuecomment-1553225738)
> I think it would also be good to continue serving txs from vExtraTxnForCompact (and to use them for resolving orphans?) to help address the https://github.com/bitcoin/bitcoin/pull/17303#issuecomment-550460346, but I don't think that needs to be a prerequisite for dropping mapRelay.

I don't think the privacy issues raised by not relaying replaced transactions are significant at all. There are many ways to use transaction relay behavior to infer the network topology, and I think there are do
...

💬 fanquake commented on pull request "net, refactor: net_processing, add `ProcessCompactBlockTxns`":
(https://github.com/bitcoin/bitcoin/pull/26969#issuecomment-1553226812)
@instagibbs this conflicts with #27626, thoughts?

💬 brunoerg commented on pull request "test: fix intermittent issue in `feature_bip68_sequence`":
(https://github.com/bitcoin/bitcoin/pull/27177#issuecomment-1553231704)
Thanks everyone for reviewing! Here's what have changed:

- `get_utxo` will not return immature coinbase utxos anymore
- We won't use the `confirmation` count from utxo object since it may have outdated. We will use current block height + utxo's height for it
- changed `get_utxos` to use current block height to compute the confirmation count instead of using the value from utxo object, same logic from `get_utxo`.