💬 fanquake commented on issue "Mac osx 12.6.5 ":
(https://github.com/bitcoin/bitcoin/issues/27681#issuecomment-1553046960)
> thank u all do I have to forward this or haves it been done
A new issue has been opened, https://github.com/bitcoin-core/gui/issues/731, thanks.
(https://github.com/bitcoin/bitcoin/issues/27681#issuecomment-1553046960)
> thank u all do I have to forward this or haves it been done
A new issue has been opened, https://github.com/bitcoin-core/gui/issues/731, thanks.
🚀 fanquake merged a pull request: "test: Return dict in MiniWallet::send_to"
(https://github.com/bitcoin/bitcoin/pull/27640)
(https://github.com/bitcoin/bitcoin/pull/27640)
👍 fanquake approved a pull request: "build: Bump minimum supported GCC to g++-9"
(https://github.com/bitcoin/bitcoin/pull/27662#pullrequestreview-1432713153)
ACK fa953f15bfcf95df9aa9c91e1c4b56a205f4d1ae
(https://github.com/bitcoin/bitcoin/pull/27662#pullrequestreview-1432713153)
ACK fa953f15bfcf95df9aa9c91e1c4b56a205f4d1ae
💬 sdaftuar commented on pull request "Parallel compact block downloads, take 3":
(https://github.com/bitcoin/bitcoin/pull/27626#issuecomment-1553089898)
ACK 2d12fab42cc0f11d5ede96c7eb71a496931df0b5. I've reviewed the test as well and have been running this branch live, and it looks good to me.
I think it'd be good to merge this sooner than later so we can get some experience running this in master before it appears in a release, so that we can get a sense of whether we want to institute any better bandwidth management before deploying.
(https://github.com/bitcoin/bitcoin/pull/27626#issuecomment-1553089898)
ACK 2d12fab42cc0f11d5ede96c7eb71a496931df0b5. I've reviewed the test as well and have been running this branch live, and it looks good to me.
I think it'd be good to merge this sooner than later so we can get some experience running this in master before it appears in a release, so that we can get a sense of whether we want to institute any better bandwidth management before deploying.
💬 instagibbs commented on pull request "Parallel compact block downloads, take 3":
(https://github.com/bitcoin/bitcoin/pull/27626#issuecomment-1553102278)
"jq: command not found" weird one, probably just restart?
(https://github.com/bitcoin/bitcoin/pull/27626#issuecomment-1553102278)
"jq: command not found" weird one, probably just restart?
💬 fanquake commented on pull request "Parallel compact block downloads, take 3":
(https://github.com/bitcoin/bitcoin/pull/27626#issuecomment-1553108896)
> "jq: command not found" weird one, probably just restart?
Rebase should do it. Added recently for IWYU in the tidy job.
(https://github.com/bitcoin/bitcoin/pull/27626#issuecomment-1553108896)
> "jq: command not found" weird one, probably just restart?
Rebase should do it. Added recently for IWYU in the tidy job.
💬 instagibbs commented on pull request "Parallel compact block downloads, take 3":
(https://github.com/bitcoin/bitcoin/pull/27626#issuecomment-1553109478)
rebased
(https://github.com/bitcoin/bitcoin/pull/27626#issuecomment-1553109478)
rebased
👋 hebasto's pull request is ready for review: "build: Detect USDT the same way how it is used in the code"
(https://github.com/bitcoin/bitcoin/pull/27458)
(https://github.com/bitcoin/bitcoin/pull/27458)
💬 hebasto commented on pull request "build: Detect USDT the same way how it is used in the code":
(https://github.com/bitcoin/bitcoin/pull/27458#issuecomment-1553110399)
> What are we doing here?
Reworked. The PR description has been updated.
(https://github.com/bitcoin/bitcoin/pull/27458#issuecomment-1553110399)
> What are we doing here?
Reworked. The PR description has been updated.
💬 jamesob commented on pull request "assumeutxo (2)":
(https://github.com/bitcoin/bitcoin/pull/27596#issuecomment-1553127188)
Thanks for testing, @theStack!
> So far so good, everything went quite smooth and nothing unexpected happened! The only disappointment was finding that apparently the provided prune target of 800MB was not respected:
Yes, this is unfortunately expected behavior. Since you have `-blockfilterindex` enabled and the background sync hasn't yet completed, prune locks are preventing any pruning from happening on the snapshot chainstate. I mentioned this obliquely here: https://github.com/bitcoin/
...
(https://github.com/bitcoin/bitcoin/pull/27596#issuecomment-1553127188)
Thanks for testing, @theStack!
> So far so good, everything went quite smooth and nothing unexpected happened! The only disappointment was finding that apparently the provided prune target of 800MB was not respected:
Yes, this is unfortunately expected behavior. Since you have `-blockfilterindex` enabled and the background sync hasn't yet completed, prune locks are preventing any pruning from happening on the snapshot chainstate. I mentioned this obliquely here: https://github.com/bitcoin/
...
💬 pinheadmz commented on pull request "net: Allow inbound whitebind connections to more aggressively evict peers when slots are full":
(https://github.com/bitcoin/bitcoin/pull/27600#issuecomment-1553133230)
Thanks @stickies-v nits addressed! 🙏
(https://github.com/bitcoin/bitcoin/pull/27600#issuecomment-1553133230)
Thanks @stickies-v nits addressed! 🙏
💬 MarcoFalke commented on pull request "Enhanced error messages for invalid network prefix during address parsing.":
(https://github.com/bitcoin/bitcoin/pull/27260#issuecomment-1553133965)
Needs rebase on current master, if still relevant
(https://github.com/bitcoin/bitcoin/pull/27260#issuecomment-1553133965)
Needs rebase on current master, if still relevant
💬 MarcoFalke commented on pull request "Add a "tx output spender" index":
(https://github.com/bitcoin/bitcoin/pull/24539#issuecomment-1553136911)
(Needs rebase)
(https://github.com/bitcoin/bitcoin/pull/24539#issuecomment-1553136911)
(Needs rebase)
💬 MarcoFalke commented on pull request "Improve display address handling for external signer":
(https://github.com/bitcoin/bitcoin/pull/24313#issuecomment-1553138296)
Needs rebase
(https://github.com/bitcoin/bitcoin/pull/24313#issuecomment-1553138296)
Needs rebase
💬 fanquake commented on pull request "build: Bump minimum supported GCC to g++-9":
(https://github.com/bitcoin/bitcoin/pull/27662#issuecomment-1553152251)
Guix Build:
```bash
eebee5018a0bfa5e6de1ebb58522457f0f35f5636e71990af35d5b10c9ebb296 guix-build-fa953f15bfcf/output/aarch64-linux-gnu/SHA256SUMS.part
7c7a69bb6cce74a31cd747f4234332de83d201d0b6426aac3095a16b9eb09e33 guix-build-fa953f15bfcf/output/aarch64-linux-gnu/bitcoin-fa953f15bfcf-aarch64-linux-gnu-debug.tar.gz
869ae0cd106fc82ed075f1efa50993dbe588aad9316579397de594e46f18155e guix-build-fa953f15bfcf/output/aarch64-linux-gnu/bitcoin-fa953f15bfcf-aarch64-linux-gnu.tar.gz
61764214a68b0602
...
(https://github.com/bitcoin/bitcoin/pull/27662#issuecomment-1553152251)
Guix Build:
```bash
eebee5018a0bfa5e6de1ebb58522457f0f35f5636e71990af35d5b10c9ebb296 guix-build-fa953f15bfcf/output/aarch64-linux-gnu/SHA256SUMS.part
7c7a69bb6cce74a31cd747f4234332de83d201d0b6426aac3095a16b9eb09e33 guix-build-fa953f15bfcf/output/aarch64-linux-gnu/bitcoin-fa953f15bfcf-aarch64-linux-gnu-debug.tar.gz
869ae0cd106fc82ed075f1efa50993dbe588aad9316579397de594e46f18155e guix-build-fa953f15bfcf/output/aarch64-linux-gnu/bitcoin-fa953f15bfcf-aarch64-linux-gnu.tar.gz
61764214a68b0602
...
📝 fanquake opened a pull request: "doc: add historical release notes for 24.1 & 23.2"
(https://github.com/bitcoin/bitcoin/pull/27698)
Also for linking to from `Releases`.
(https://github.com/bitcoin/bitcoin/pull/27698)
Also for linking to from `Releases`.
💬 achow101 commented on pull request "doc: add historical release notes for 24.1 & 23.2":
(https://github.com/bitcoin/bitcoin/pull/27698#issuecomment-1553174256)
ACK e0f69a708154c41a34ea72ae2ae730fca7407cda
(https://github.com/bitcoin/bitcoin/pull/27698#issuecomment-1553174256)
ACK e0f69a708154c41a34ea72ae2ae730fca7407cda
🚀 achow101 merged a pull request: "doc: add historical release notes for 24.1 & 23.2"
(https://github.com/bitcoin/bitcoin/pull/27698)
(https://github.com/bitcoin/bitcoin/pull/27698)
💬 sdaftuar commented on pull request "Parallel compact block downloads, take 3":
(https://github.com/bitcoin/bitcoin/pull/27626#issuecomment-1553177921)
ACK 42c2696ae58e07de005edf1dda952761f8c9008e
(https://github.com/bitcoin/bitcoin/pull/27626#issuecomment-1553177921)
ACK 42c2696ae58e07de005edf1dda952761f8c9008e
💬 achow101 commented on issue "bitcoin-qt generates bad psbt":
(https://github.com/bitcoin/bitcoin/issues/27697#issuecomment-1553178396)
I think https://github.com/bitcoin-core/gui/pull/687 was the fix.
(https://github.com/bitcoin/bitcoin/issues/27697#issuecomment-1553178396)
I think https://github.com/bitcoin-core/gui/pull/687 was the fix.