💬 achow101 commented on pull request "psbt: add non-default sighash types to PSBTs and unify sighash type match checking":
(https://github.com/bitcoin/bitcoin/pull/31622#discussion_r2098527513)
Will leave for a followup

💬 achow101 commented on pull request "psbt: add non-default sighash types to PSBTs and unify sighash type match checking":
(https://github.com/bitcoin/bitcoin/pull/31622#discussion_r2098527629)
Will leave for a followup

🤔 1440000bytes reviewed a pull request: "doc: Remove stale sections in dev notes"
(https://github.com/bitcoin/bitcoin/pull/32572#pullrequestreview-2855148437)
ACK https://github.com/bitcoin/bitcoin/pull/32572/commits/fa2482adf5d2df2192e882dc9ca817056ea52087

<details>
<summary>Signature</summary>

<pre>
-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA512

ACK fa2482adf5d2df2192e882dc9ca817056ea52087
-----BEGIN PGP SIGNATURE-----

iHUEARYKAB0WIQSSUwYqT5LWNFkIXKYtIwUgISpZAQUCaCzEGQAKCRAtIwUgISpZ
AbhcAP9ygFAp7qD4fcUKOAg6ZSm16COjkWKxafquCHUkmqn8MQD/Ve6fkUMINSW4
sodJPMcTbr55vrJoR7G4KLtRoLs+ogg=
=9NNA
-----END PGP SIGNATURE-----
</pre>
</detai
...

💬 luke-jr commented on pull request "index: store per-block transaction locations for efficient lookups":
(https://github.com/bitcoin/bitcoin/pull/32541#issuecomment-2895395162)
How does this compare to `getrawtransaction <txid> 0 <blockhash>` without a txindex?

💬 murchandamus commented on issue "Coin Selection tracepoint overreports use of APS":
(https://github.com/bitcoin/bitcoin/issues/25150#issuecomment-2895404858)
Maybe this issue would be more relevant if we renamed it to "Only run APS if the original solution would spend a subset of UTXOs sharing the same output script". cc: @achow101

💬 luke-jr commented on pull request "doc: add alpine build instructions":
(https://github.com/bitcoin/bitcoin/pull/32559#discussion_r2098610613)
Why?

💬 fanquake commented on pull request "doc: add alpine build instructions":
(https://github.com/bitcoin/bitcoin/pull/32559#discussion_r2098613366)
Can be dropped after #32568.

💬 achow101 commented on pull request "descriptors: MuSig2":
(https://github.com/bitcoin/bitcoin/pull/31244#discussion_r2098613575)
Done, with `Assume`. It's occurred to me that `Assert` in descriptor code is probably not the way to go, so I've changed the couple other `Assert` to `Assume`.

💬 achow101 commented on pull request "descriptors: MuSig2":
(https://github.com/bitcoin/bitcoin/pull/31244#discussion_r2098614758)
It looks like `_hex_u8` can be used directly in uin256's constructor with normal byte order, so used that.

💬 mzumsande commented on pull request "test: allow all functional tests to be run or skipped with --usecli":
(https://github.com/bitcoin/bitcoin/pull/32290#discussion_r2098623556)
This is only correct for `hash_or_height`, which because of its dual use is defined as a numeric, non-string parameter and is therefore converted from json. It would be incorrect for actual string args:
You can see it directly using `bitcoin-cli` in the console:
You can do
`bitcoin-cli -regtest getblockstats '"3520a1e79bd3df078c762693b5c113469e267176aefca0d3c1dac29b8db6dd33"'`
but
`bitcoin-cli -regtest getblockstats "3520a1e79bd3df078c762693b5c113469e267176aefca0d3c1dac29b8db6dd33"` fails w
...

💬 theuni commented on pull request "checkqueue: make the queue non-optional for CCheckQueueControl and drop legacy locking macro usage":
(https://github.com/bitcoin/bitcoin/pull/32467#discussion_r2098623686)
Ok, yes, thank you for walking through that. I agree. Pushed with a slight change (only adding to the queue if tx_ok).

💬 theuni commented on pull request "threading: drop CSemaphore in favor of c++20 std::counting_semaphore":
(https://github.com/bitcoin/bitcoin/pull/32466#discussion_r2098634952)
Correct. This is just for symmetry with [std::binary_semaphore](https://en.cppreference.com/w/cpp/thread/counting_semaphore)

💬 davidgumberg commented on pull request "deps: Bump lief to 0.16.4":
(https://github.com/bitcoin/bitcoin/pull/32431#issuecomment-2895455313)
>I think it'd be worth investigating any issues with 0.16.5, rather than deferring.

Sounds good, marking the PR as draft again while I investigate.

I've bisected to this commit in `lief`: https://github.com/lief-project/LIEF/commit/f23ced2f4ffc170d0a6f40ff4a1bee575e3447cf

Seems related to scikit-build 0.10 [changing](https://iscinumpy.dev/post/scikit-build-core-0-10/#other-changes) `cmake.targets` to `build.targets`, and defining `build.targets` explains why `build` is defined in [`conf
...

📝 davidgumberg converted_to_draft a pull request: "deps: Bump lief to 0.16.4"
(https://github.com/bitcoin/bitcoin/pull/32431)
Partially resolves https://github.com/bitcoin/bitcoin/issues/30520, updating to `lief` 0.16.4.

💬 willcl-ark commented on pull request "doc: add alpine build instructions":
(https://github.com/bitcoin/bitcoin/pull/32559#discussion_r2098640978)
Verified correct. thanks

💬 mzumsande commented on pull request "test: allow all functional tests to be run or skipped with --usecli":
(https://github.com/bitcoin/bitcoin/pull/32290#issuecomment-2895462729)
[7c13240](https://github.com/bitcoin/bitcoin/commit/7c13240d7b9a03b77ad84460e80007063367e05a) to [2bf3f90](https://github.com/bitcoin/bitcoin/commit/2bf3f907ff54efd4fa22930a81269d568e29274e): rebased - as a side effect, the legacy wallet removal made `wallet_labels.py --usecli` work on master, so no longer mentioned here.

💬 achow101 commented on pull request "wallet: `addhdkey` RPC to add just keys to wallets via new `unused(KEY)` descriptor":
(https://github.com/bitcoin/bitcoin/pull/29136#discussion_r2098653255)
Done

💬 achow101 commented on pull request "wallet: `addhdkey` RPC to add just keys to wallets via new `unused(KEY)` descriptor":
(https://github.com/bitcoin/bitcoin/pull/29136#discussion_r2098653374)
Done

💬 achow101 commented on pull request "wallet: `addhdkey` RPC to add just keys to wallets via new `unused(KEY)` descriptor":
(https://github.com/bitcoin/bitcoin/pull/29136#discussion_r2098653469)
Done

💬 achow101 commented on pull request "wallet: `addhdkey` RPC to add just keys to wallets via new `unused(KEY)` descriptor":
(https://github.com/bitcoin/bitcoin/pull/29136#discussion_r2098653553)
Done