✅ fanquake closed an issue: "bitcoin-qt generates bad psbt"
(https://github.com/bitcoin/bitcoin/issues/27697)

💬 kallerosenbaum commented on issue "bitcoin-qt generates bad psbt":
(https://github.com/bitcoin/bitcoin/issues/27697#issuecomment-1552978120)
A psbt file that's saved in 24.0.1 and that failed to open in 24.0.1, could successfully be opened in 25.0rc2. I guess this means that the saved psbt file is valid and that it's the parsing of the psbt file that is buggy.

💬 kallerosenbaum commented on issue "bitcoin-qt generates bad psbt":
(https://github.com/bitcoin/bitcoin/issues/27697#issuecomment-1552982794)
However, I'm not sure https://github.com/bitcoin-core/gui/pull/469 fixed it, because the saved psbt is binary. Attaching my psbt file (renamed to *.txt to circumvent upload restrictions)
[test3.psbt.txt](https://github.com/bitcoin/bitcoin/files/11507730/test3.psbt.txt)

👍 stickies-v approved a pull request: "test: Return dict in MiniWallet::send_to"
(https://github.com/bitcoin/bitcoin/pull/27640#pullrequestreview-1432623162)
Code review ACK faf4315c88d8c81c2ff84870bc81aef3cf719816

I'd have preferred doing things a bit differently but I think as per the PRs rationale, it's better to move away from the tuple return type quickly to avoid larger refactorings in the future. My comments can easily be implemented in follow-ups, if people want them.

---

> The idea is to use the same return type as the other MiniWallet methods.

Fair enough, I hadn't considered that.

> If you want compile-time type checks <...>
...

💬 kallerosenbaum commented on issue "bitcoin-qt generates bad psbt":
(https://github.com/bitcoin/bitcoin/issues/27697#issuecomment-1553009843)
If I convert the test3.psbt.txt (binary) file to a base64 file, I can then read the base64 into bitcoin core.
```
$ cat test3.psbt.txt|base64 -w0 > test3.psbt
```

⚠️ fanquake opened an issue: "crash on macOS 12.6.5"
(https://github.com/bitcoin-core/gui/issues/731)
Moved from https://github.com/bitcoin/bitcoin/issues/27681.


### What version of Bitcoin Core are you using?

V22.0.0 and 24.0.1.

### Operating system and version

Mac osx 12.6.5

### Machine specifications

2.8 dual core i5 8 gb ram high speed internet
1tb drive

```bash
Translated Report (Full Report Below)
-------------------------------------

Process: Bitcoin-Qt [844]
Path: /Applications/Bitcoin-Qt.app/Contents/MacOS/Bitcoin-Qt
Ident
...

💬 fanquake commented on issue "Mac osx 12.6.5 ":
(https://github.com/bitcoin/bitcoin/issues/27681#issuecomment-1553024681)
Moved over to https://github.com/bitcoin-core/gui/issues/731.

✅ fanquake closed an issue: "Mac osx 12.6.5 "
(https://github.com/bitcoin/bitcoin/issues/27681)

💬 fanquake commented on issue "bitcoin-qt generates bad psbt":
(https://github.com/bitcoin/bitcoin/issues/27697#issuecomment-1553027002)
Ok. Could continue discussion with an issue in https://github.com/bitcoin-core/gui if still relevant?

cc @achow101

💬 ddykeman1 commented on issue "Mac osx 12.6.5 ":
(https://github.com/bitcoin/bitcoin/issues/27681#issuecomment-1553045708)
thank u all do I have to forward this or haves it been done

💬 fanquake commented on issue "Mac osx 12.6.5 ":
(https://github.com/bitcoin/bitcoin/issues/27681#issuecomment-1553046960)
> thank u all do I have to forward this or haves it been done

A new issue has been opened, https://github.com/bitcoin-core/gui/issues/731, thanks.

🚀 fanquake merged a pull request: "test: Return dict in MiniWallet::send_to"
(https://github.com/bitcoin/bitcoin/pull/27640)

👍 fanquake approved a pull request: "build: Bump minimum supported GCC to g++-9"
(https://github.com/bitcoin/bitcoin/pull/27662#pullrequestreview-1432713153)
ACK fa953f15bfcf95df9aa9c91e1c4b56a205f4d1ae

💬 sdaftuar commented on pull request "Parallel compact block downloads, take 3":
(https://github.com/bitcoin/bitcoin/pull/27626#issuecomment-1553089898)
ACK 2d12fab42cc0f11d5ede96c7eb71a496931df0b5. I've reviewed the test as well and have been running this branch live, and it looks good to me.

I think it'd be good to merge this sooner than later so we can get some experience running this in master before it appears in a release, so that we can get a sense of whether we want to institute any better bandwidth management before deploying.

💬 instagibbs commented on pull request "Parallel compact block downloads, take 3":
(https://github.com/bitcoin/bitcoin/pull/27626#issuecomment-1553102278)
"jq: command not found" weird one, probably just restart?

💬 fanquake commented on pull request "Parallel compact block downloads, take 3":
(https://github.com/bitcoin/bitcoin/pull/27626#issuecomment-1553108896)
> "jq: command not found" weird one, probably just restart?

Rebase should do it. Added recently for IWYU in the tidy job.

💬 instagibbs commented on pull request "Parallel compact block downloads, take 3":
(https://github.com/bitcoin/bitcoin/pull/27626#issuecomment-1553109478)
rebased

👋 hebasto's pull request is ready for review: "build: Detect USDT the same way how it is used in the code"
(https://github.com/bitcoin/bitcoin/pull/27458)

💬 hebasto commented on pull request "build: Detect USDT the same way how it is used in the code":
(https://github.com/bitcoin/bitcoin/pull/27458#issuecomment-1553110399)
> What are we doing here?

Reworked. The PR description has been updated.

💬 jamesob commented on pull request "assumeutxo (2)":
(https://github.com/bitcoin/bitcoin/pull/27596#issuecomment-1553127188)
Thanks for testing, @theStack!

> So far so good, everything went quite smooth and nothing unexpected happened! The only disappointment was finding that apparently the provided prune target of 800MB was not respected:

Yes, this is unfortunately expected behavior. Since you have `-blockfilterindex` enabled and the background sync hasn't yet completed, prune locks are preventing any pruning from happening on the snapshot chainstate. I mentioned this obliquely here: https://github.com/bitcoin/
...