💬 hebasto commented on pull request "bench: Add SHA256 implementation specific benchmarks":
(https://github.com/bitcoin/bitcoin/pull/27598#issuecomment-1552896322)
Rebased on top of the merged #27615 as it was [relevant](https://github.com/bitcoin/bitcoin/pull/24773#issuecomment-1541888040).

💬 fanquake commented on pull request "build: Check usages of #if defined(...)":
(https://github.com/bitcoin/bitcoin/pull/25302#issuecomment-1552896958)
Going to close for now. We can continue any discussion in #16419.

✅ fanquake closed a pull request: "build: Check usages of #if defined(...)"
(https://github.com/bitcoin/bitcoin/pull/25302)

🚀 fanquake merged a pull request: "doc: Rework build-unix.md"
(https://github.com/bitcoin/bitcoin/pull/27685)

💬 fanquake commented on pull request "test: Return dict in MiniWallet::send_to":
(https://github.com/bitcoin/bitcoin/pull/27640#issuecomment-1552900340)
@stickies-v want to take a final look?

💬 ismaelsadeeq commented on pull request "Fee estimation: avoid serving stale fee estimate":
(https://github.com/bitcoin/bitcoin/pull/27622#discussion_r1197688535)
Yes thanks for pointing this out, I added the check.
Thank you.

💬 ismaelsadeeq commented on pull request "Fee estimation: avoid serving stale fee estimate":
(https://github.com/bitcoin/bitcoin/pull/27622#discussion_r1197693333)
Yeah, to enhance flexibility, I can create a follow-up PR to introduce a configuration variable for MAX_FILE_AGE, This way users can specify the maximum age of estimates they do not want to accept?

💬 ismaelsadeeq commented on pull request "Fee estimation: avoid serving stale fee estimate":
(https://github.com/bitcoin/bitcoin/pull/27622#discussion_r1197686957)
Yes, fixed thank you.

💬 fanquake commented on issue "Option to prevent sleep":
(https://github.com/bitcoin/bitcoin/issues/27692#issuecomment-1552909089)
Thanks. We've had similar proposals in the past, i.e #16145, and it's unlikely we are going to implement this kind of functionality. You can use your own scripts / external tools etc to acheive what you need.

✅ fanquake closed an issue: "Option to prevent sleep"
(https://github.com/bitcoin/bitcoin/issues/27692)

👍 hebasto approved a pull request: "build: Bump minimum supported GCC to g++-9"
(https://github.com/bitcoin/bitcoin/pull/27662#pullrequestreview-1432518265)
ACK fa953f15bfcf95df9aa9c91e1c4b56a205f4d1ae

💬 fanquake commented on issue "Mac osx 12.6.5 ":
(https://github.com/bitcoin/bitcoin/issues/27681#issuecomment-1552912525)
Thanks for the additional info. This is clearly a macOS, GUI-specific, issue, so I think this bug report can be moved to the GUI repo: https://github.com/bitcoin-core/gui, and someone there might be able to follow up?

💬 fanquake commented on issue "Can't start bitcoin-qt by double-click on Debian 11":
(https://github.com/bitcoin/bitcoin/issues/27655#issuecomment-1552913425)
Not sure what else we can do here? I think this should be moved over to the GUI repo: https://github.com/bitcoin-core/gui, in any case, and maybe someone can follow up there?

💬 MarcoFalke commented on issue "Mac osx 12.6.5 ":
(https://github.com/bitcoin/bitcoin/issues/27681#issuecomment-1552916702)
Is it confirmed that the daemon `bitcoind` is running successfully?

⚠️ hebasto opened an issue: "Can't start bitcoin-qt by double-click on Debian 11"
(https://github.com/bitcoin-core/gui/issues/730)
Moved from https://github.com/bitcoin/bitcoin/issues/27655.

### Is there an existing issue for this?

- [X] I have searched the existing issues

### Current behaviour

When I double-click the bitcoin-qt executable file in the graphical file manager, Bitcoin Core doesn't start and this message pops up:


I think this issue is the same as described at https://
...

⚠️ kallerosenbaum opened an issue: "bitcoin-qt generates bad psbt"
(https://github.com/bitcoin/bitcoin/issues/27697)
### Is there an existing issue for this?

- [X] I have searched the existing issues

### Current behaviour

I run bitcoin-qt in regtest mode. The wallet is created blank and I've imported descriptors to it. I have a total of 30 BTC in two outputs. I create a new transaction and save it as a PSBT for offline signing. When I try to read this file into bitcoin-qt again, it shows an error dialog with the message:

```
Unable to decode PSBT
CDataStream::read(): end of data: iostream error
```

...

💬 hebasto commented on issue "Can't start bitcoin-qt by double-click on Debian 11":
(https://github.com/bitcoin/bitcoin/issues/27655#issuecomment-1552919155)
Moved to https://github.com/bitcoin-core/gui/issues/730.

✅ hebasto closed an issue: "Can't start bitcoin-qt by double-click on Debian 11"
(https://github.com/bitcoin/bitcoin/issues/27655)

💬 fanquake commented on issue "Mac osx 12.6.5 ":
(https://github.com/bitcoin/bitcoin/issues/27681#issuecomment-1552920830)
I can't see a reason that it wouldn't be (absent a new report), and the crash here is coming from objective C code that isn't part of bitcoind.

💬 ajtowns commented on pull request "p2p: Stop relaying non-mempool txs":
(https://github.com/bitcoin/bitcoin/pull/27625#issuecomment-1552923162)
> > I think it would also be good to continue serving txs from `vExtraTxnForCompact`
>
> I wasn't sure how to do this, given the planned removal of `m_recently_announced_invs` in #27675 . Otherwise we may relay invalid/non-standard transactions that were injected into us by a spy node.

I guess a straightforward approach would be to have the mempool separately keep track of the last ~700 txs removed, as well as their entry time and removal time. Then they could be relayed to a node (under #
...