🚀 fanquake merged a pull request: "msvc: Rename `libbitcoinconsensus` to `libbitcoin_consensus` and other adjustments"
(https://github.com/bitcoin/bitcoin/pull/27615)

💬 hebasto commented on issue "Check usages of `#if defined(...)`":
(https://github.com/bitcoin/bitcoin/issues/16419#issuecomment-1552877492)
On the master branch @ 4e8a7654f623fc0dad933b3d93dc54d8206c605d plus https://github.com/bitcoin/bitcoin/pull/27696, there are only two cases in our build system of explicit unconditional usage of the `AC_DEFINE` and `AC_DEFINE_UNQUOTED` macros (except for one which define string literals like `COPYRIGHT_YEAR`):

- https://github.com/bitcoin/bitcoin/blob/4e8a7654f623fc0dad933b3d93dc54d8206c605d/configure.ac#L1230
- https://github.com/bitcoin/bitcoin/blob/4e8a7654f623fc0dad933b3d93dc54d8206c605
...

💬 hebasto commented on pull request "build: Check usages of #if defined(...)":
(https://github.com/bitcoin/bitcoin/pull/25302#issuecomment-1552880786)
I've re-reviewed this PR and none of the suggested changes seem required to me.

More details see in https://github.com/bitcoin/bitcoin/issues/16419#issuecomment-1552877492.

💬 MarcoFalke commented on issue "Can't compile v24.0.1":
(https://github.com/bitcoin/bitcoin/issues/27680#issuecomment-1552885846)
> Also I didn't quite understand the note and how to specify the absolute path ...

Thanks, I agree that the section about absolute folders is confusing. So I removed it in https://github.com/bitcoin/bitcoin/pull/27685

👋 MarcoFalke's pull request is ready for review: "build: Bump minimum supported GCC to g++-9"
(https://github.com/bitcoin/bitcoin/pull/27662)

💬 MarcoFalke commented on pull request "test: Return dict in MiniWallet::send_to":
(https://github.com/bitcoin/bitcoin/pull/27640#issuecomment-1552892950)
Anything left to do here?

💬 fanquake commented on pull request "build: Fix USDT detection on FreeBSD":
(https://github.com/bitcoin/bitcoin/pull/27458#issuecomment-1552895961)
What are we doing here?

If we aren't doing this yet, I think it can just be closed and/or combined in #26593. Otherwise,
> Maybe adjust the PR title/OP and the commit message.

?

💬 hebasto commented on pull request "bench: Add SHA256 implementation specific benchmarks":
(https://github.com/bitcoin/bitcoin/pull/27598#issuecomment-1552896322)
Rebased on top of the merged #27615 as it was [relevant](https://github.com/bitcoin/bitcoin/pull/24773#issuecomment-1541888040).

💬 fanquake commented on pull request "build: Check usages of #if defined(...)":
(https://github.com/bitcoin/bitcoin/pull/25302#issuecomment-1552896958)
Going to close for now. We can continue any discussion in #16419.

✅ fanquake closed a pull request: "build: Check usages of #if defined(...)"
(https://github.com/bitcoin/bitcoin/pull/25302)

🚀 fanquake merged a pull request: "doc: Rework build-unix.md"
(https://github.com/bitcoin/bitcoin/pull/27685)

💬 fanquake commented on pull request "test: Return dict in MiniWallet::send_to":
(https://github.com/bitcoin/bitcoin/pull/27640#issuecomment-1552900340)
@stickies-v want to take a final look?

💬 ismaelsadeeq commented on pull request "Fee estimation: avoid serving stale fee estimate":
(https://github.com/bitcoin/bitcoin/pull/27622#discussion_r1197688535)
Yes thanks for pointing this out, I added the check.
Thank you.

💬 ismaelsadeeq commented on pull request "Fee estimation: avoid serving stale fee estimate":
(https://github.com/bitcoin/bitcoin/pull/27622#discussion_r1197693333)
Yeah, to enhance flexibility, I can create a follow-up PR to introduce a configuration variable for MAX_FILE_AGE, This way users can specify the maximum age of estimates they do not want to accept?

💬 ismaelsadeeq commented on pull request "Fee estimation: avoid serving stale fee estimate":
(https://github.com/bitcoin/bitcoin/pull/27622#discussion_r1197686957)
Yes, fixed thank you.

💬 fanquake commented on issue "Option to prevent sleep":
(https://github.com/bitcoin/bitcoin/issues/27692#issuecomment-1552909089)
Thanks. We've had similar proposals in the past, i.e #16145, and it's unlikely we are going to implement this kind of functionality. You can use your own scripts / external tools etc to acheive what you need.

✅ fanquake closed an issue: "Option to prevent sleep"
(https://github.com/bitcoin/bitcoin/issues/27692)

👍 hebasto approved a pull request: "build: Bump minimum supported GCC to g++-9"
(https://github.com/bitcoin/bitcoin/pull/27662#pullrequestreview-1432518265)
ACK fa953f15bfcf95df9aa9c91e1c4b56a205f4d1ae

💬 fanquake commented on issue "Mac osx 12.6.5 ":
(https://github.com/bitcoin/bitcoin/issues/27681#issuecomment-1552912525)
Thanks for the additional info. This is clearly a macOS, GUI-specific, issue, so I think this bug report can be moved to the GUI repo: https://github.com/bitcoin-core/gui, and someone there might be able to follow up?

💬 fanquake commented on issue "Can't start bitcoin-qt by double-click on Debian 11":
(https://github.com/bitcoin/bitcoin/issues/27655#issuecomment-1552913425)
Not sure what else we can do here? I think this should be moved over to the GUI repo: https://github.com/bitcoin-core/gui, in any case, and maybe someone can follow up there?