💬 achow101 commented on pull request "wallet: Fix logging of wallet version":
(https://github.com/bitcoin/bitcoin/pull/32553#issuecomment-2889277192)
> It would also be worth testing this in the compat test — mainly to create a wallet on a previous release and verify that their version and last client are properly reported when opened by the latest release.

With legacy wallets removed, this wouldn't really be possible to test as descriptor wallets all are version 169900.

💬 fjahr commented on pull request "[EXPERIMENTAL] Schnorr batch verification for blocks":
(https://github.com/bitcoin/bitcoin/pull/29491#issuecomment-2889288127)
> It seems you were referring to the command I ran. I used ConnectBlockAllSchnorr microbenchmark. Run it with build/bin/bench_bitcoin -filter=ConnectBlockAllSchnorr . For IBD benchmarking, I'm doing bitcoind -assumevalid=0 -par={par} -stopatheight=880000(I'm testing 1, 2, 4, 6, 8, 12 threads) with Benchkit.

I couldn't figure out how to test the different thread configurations for the microbench with Benchkit. Are you using Benchkit there as well or are you just setting `worker_threads_num` in
...

🤔 algreenofficial reviewed a pull request: "net: Replace libnatpmp with built-in PCP+NATPMP implementation"
(https://github.com/bitcoin/bitcoin/pull/30043#pullrequestreview-2849264922)
Support deposit payment

💬 bitcoin31888 commented on pull request "correct wrong assumptions in the contrib linearize data script":
(https://github.com/bitcoin/bitcoin/pull/31888#issuecomment-2889473592)
Consider the following bash script

`while true;do ./linearize-hashes.py linearize.cfg > hashlist.txt; ./linearize-data.py linearize.cfg; sleep 120; done`

This will continuously write out the bootstrap files, without this patch the files will continuously be truncated to zero length and then overwritten, that behavior is undesirable.

💬 jasonribble commented on pull request "rpc: Undeprecate rpcuser/rpcpassword, store all credentials hashed in memory":
(https://github.com/bitcoin/bitcoin/pull/32423#discussion_r2094833979)
Concept ACK

Introduced d52fbf00e32fb0565652c9a62cdaf2bc1e2dddf0

📝 meghasurya07 opened a pull request: "Comment Changes"
(https://github.com/bitcoin/bitcoin/pull/32555)
The Comments which have been added/changed in the file can be very helpful for understanding for fellow developers and community

💬 romanz commented on pull request "rest: fetch spent transaction outputs by blockhash":
(https://github.com/bitcoin/bitcoin/pull/32540#discussion_r2094845671)
> So perhaps a different name would help make that more clear? Perhaps rest/spenttxouts?

Sounds good, fixed in 8cb0465def.

✅ maflcko closed a pull request: "Comment Changes"
(https://github.com/bitcoin/bitcoin/pull/32555)

💬 maflcko commented on pull request "Comment Changes":
(https://github.com/bitcoin/bitcoin/pull/32555#issuecomment-2889687264)
Thanks for your interest in contributing! However, since there are hundreds of pending pull requests, I am closing this to focus review on the others. If you wish to contribute in the future, please focus on creating high-quality, original content that demonstrates a clear understanding of the project's requirements and goals. Also, see the [contributing guidelines](https://github.com/bitcoin/bitcoin/blob/master/CONTRIBUTING.md#refactoring).

💬 maflcko commented on pull request "RFC: script: short-circuit `GetLegacySigOpCount` for known scripts":
(https://github.com/bitcoin/bitcoin/pull/32532#issuecomment-2889730573)
I can't tell from the pull description, but is there a end-user visible performance difference? If yes, how much?

💬 maflcko commented on pull request "refactor: Remove workaround for resolved MSVC bug":
(https://github.com/bitcoin/bitcoin/pull/32552#issuecomment-2889757878)
It would be good to adjust the URL to avoid confusion and duplicate work and pull requests

💬 maflcko commented on issue "intermittent issue in rpc_signer.py (enumeratesigners timeout)":
(https://github.com/bitcoin/bitcoin/issues/32524#issuecomment-2889766830)
Whatever the issue is, it may be fixed in gcc-14. At least https://cirrus-ci.com/task/5477938151292928 passed 25 times. (The prior commit failed at least once: https://cirrus-ci.com/task/5645419964792832?logs=ci#L4122)

📝 meghasurya07 opened a pull request: "bench: Add WalletMigration benchmark for legacy-to-descriptor wallet upgrade"
(https://github.com/bitcoin/bitcoin/pull/32556)

Adds a benchmark to measure performance of migrating a legacy wallet
with multiple watch-only and key entries to the descriptor wallet format.

✅ meghasurya07 closed a pull request: "bench: Add WalletMigration benchmark for legacy-to-descriptor wallet upgrade"
(https://github.com/bitcoin/bitcoin/pull/32556)

📝 meghasurya07 opened a pull request: "bench: Add WalletMigration benchmark for legacy-to-descriptor wallet upgrade"
(https://github.com/bitcoin/bitcoin/pull/32557)
Adds a benchmark to measure performance of migrating a legacy wallet
with multiple watch-only and key entries to the descriptor wallet format.

✅ achow101 closed a pull request: "bench: Add WalletMigration benchmark for legacy-to-descriptor wallet upgrade"
(https://github.com/bitcoin/bitcoin/pull/32557)

💬 Sjors commented on pull request "descriptors: MuSig2":
(https://github.com/bitcoin/bitcoin/pull/31244#discussion_r2095000787)
Ah, it's a verb, then it makes sense.

💬 Sjors commented on pull request "descriptors: MuSig2":
(https://github.com/bitcoin/bitcoin/pull/31244#discussion_r2095003386)
In that case it's less confusing if you don't pass this argument (as the default is false).

💬 hebasto commented on pull request "refactor: Remove workaround for resolved MSVC bug":
(https://github.com/bitcoin/bitcoin/pull/32552#issuecomment-2889886048)
> It would be good to adjust the URL to avoid confusion and duplicate work and pull requests

Sure. I'll wait until it's been properly triaged.

💬 maflcko commented on issue "intermittent issue in rpc_signer.py (enumeratesigners timeout)":
(https://github.com/bitcoin/bitcoin/issues/32524#issuecomment-2889893521)
Backtrace with file names and lines:

```
Thread 33 (Thread 0x7f9d93e006c0 (LWP 18294) "b-httpworker.2"):
#0 0x00007f9da1dfca9a in read () from /lib/x86_64-linux-gnu/libc.so.6
#1 0x000055f3d4633e22 in read (__nbytes=1024, __buf=0x7f9d93dfb030, __fd=30) at /usr/include/x86_64-linux-gnu/bits/unistd.h:28
#2 subprocess::util::read_atmost_n (read_upto=1024, buf=0x7f9d93dfb030 "", fp=0x7f9d8c0036c0) at ./util/subprocess.h:437
#3 subprocess::Popen::execute_process (this=this@entry=0x7f9d93dfb8b0) a
...