🤔 tapcrafter reviewed a pull request: "rest: fetch spent transaction outputs by blockhash"
(https://github.com/bitcoin/bitcoin/pull/32540#pullrequestreview-2848945630)
tACK ffe571f461930b7a05a3cf9f7128e843ea9f7e2d

<details>

<summary>Test protocol</summary>

Running ffe571f461930b7a05a3cf9f7128e843ea9f7e2d:

```shell
$ ./build/bin/bitcoind -regtest -rpcallowip=::1 -rpcuser=u -rpcpassword=p -rest -txindex

# Invalid extension:

$ curl -v -g 'u:p@localhost:18443/rest/spentoutputs/4376e2f945afef224981b665778ec45ebe64745e7d768c2937a8e271b69d708a.json'

* Host localhost:18443 was resolved.
...
< HTTP/1.1 404 Not Found
< Content-Type: text/plain

...

💬 tapcrafter commented on pull request "rest: fetch spent transaction outputs by blockhash":
(https://github.com/bitcoin/bitcoin/pull/32540#discussion_r2094516153)
Is there a way to document the output of this REST method?
From the name alone I would've expected it to return a list of outpoints.
But it seems to return a list of transaction outputs (`CTxOut` or `Coin` depending on the context).
Which absolutely makes sense given the use case.
So perhaps a different name would help make that more clear? Perhaps `rest/spenttxouts`?

💬 Ashkar776 commented on pull request "rest: fetch spent transaction outputs by blockhash":
(https://github.com/bitcoin/bitcoin/pull/32540#issuecomment-2888998449)
Idoknow

On Sun, 18 May, 2025, 5:05 pm tapcrafter, ***@***.***> wrote:

> ***@***.**** commented on this pull request.
>
> tACK ffe571f
> <https://github.com/bitcoin/bitcoin/commit/ffe571f461930b7a05a3cf9f7128e843ea9f7e2d>
> Test protocol
>
> Running ffe571f
> <https://github.com/bitcoin/bitcoin/commit/ffe571f461930b7a05a3cf9f7128e843ea9f7e2d>
> :
>
> $ ./build/bin/bitcoind -regtest -rpcallowip=::1 -rpcuser=u -rpcpassword=p -rest -txindex
> # Invalid extension:
>
> $ curl -v -g
...

📝 hebasto opened a pull request: "cmake: Add missed `SSE41_CXXFLAGS`"
(https://github.com/bitcoin/bitcoin/pull/32550)
The missed flags were noticed when building with clang-cl on Windows.

💬 yancyribbens commented on pull request "rest: fetch spent transaction outputs by blockhash":
(https://github.com/bitcoin/bitcoin/pull/32540#issuecomment-2889002779)
> Good idea - would it be OK to implement it in a separate PR?

Sure, as you wish. I'm no authority :)

💬 furszy commented on issue "Unusual "Wallet requires newer version" Error with wallet.dat on macOS, Even with Older Client":
(https://github.com/bitcoin/bitcoin/issues/32548#issuecomment-2889007547)
Try sharing your debug.log file when loading v29. It will provide further information to debug your issue.
Also, please avoid pasting LLM-generated text. It adds unnecessary unhelpful noise.

💬 pinheadmz commented on pull request "Replace libevent with our own HTTP and socket-handling implementation":
(https://github.com/bitcoin/bitcoin/pull/32061#discussion_r2094541457)
I should have mentioned the initial test commits have been split off into https://github.com/bitcoin/bitcoin/pull/32408 and the test as written here failed CI, so has been modified with `rpcservertimeout=2` and then expects a timeout between 1 and 4 seconds

💬 sipa commented on issue "Unusual "Wallet requires newer version" Error with wallet.dat on macOS, Even with Older Client":
(https://github.com/bitcoin/bitcoin/issues/32548#issuecomment-2889032183)
> last client version = 210201

This indicates that you need at least Bitcoin Core 0.21.2, but you're trying with Bitcoin Core 0.21.0.

📝 hebasto converted_to_draft a pull request: "cmake: Add missed `SSE41_CXXFLAGS`"
(https://github.com/bitcoin/bitcoin/pull/32550)
The missed flags were noticed when building with clang-cl on Windows.

💬 andrewtoth commented on pull request "contrib: add xor-blocks tool to obfuscate blocks directory":
(https://github.com/bitcoin/bitcoin/pull/32451#discussion_r2094547839)
Unfortunately it does not. I fixed with `writer.into_inner()?.sync_data()?;`. The `into_inner` will flush the writer before returning.

💬 maflcko commented on pull request "contrib: add xor-blocks tool to obfuscate blocks directory":
(https://github.com/bitcoin/bitcoin/pull/32451#discussion_r2094550287)
are you sure this is always safe from an alignment perspective? (IIUC bytes don't have to be aligned, but u128 may have to). So it seems safer to make the storage u128 and then cast the other way (to u8)?

📝 hebasto opened a pull request: "cmake: Remove `ENABLE_{SSE41,AVX2,X86_SHANI,ARM_SHANI}` from `bitcoin-build-config.h`"
(https://github.com/bitcoin/bitcoin/pull/32551)
`ENABLE_{SSE41,AVX2,X86_SHANI,ARM_SHANI}` are already conditionally defined for the [`bitcoin_crypto`](https://github.com/bitcoin/bitcoin/blob/master/src/crypto/CMakeLists.txt) target, so defining them in `bitcoin-build-config.h` is redundant.

💬 l3x3l commented on issue "Unusual "Wallet requires newer version" Error with wallet.dat on macOS, Even with Older Client":
(https://github.com/bitcoin/bitcoin/issues/32548#issuecomment-2889058033)
I am running on v 29.0

Debug.log


0000036781cb1d4bf34243ea67e83890d5195e750e5a0b756 height=896702
version=0x2000e000 log2_work=95.608193 tx=1190303817
date='2025-05-14T17:33:55Z' progress=0.999321 cache=131.9MiB(930821txo)

2025-05-16T18:12:31Z UpdateTip: new
best=000000000000000000021a5d9bd590b972464287a60646800ba8d12def9a86dd
height=896703 version=0x32a70000 log2_work=95.608205 tx=1190307478
date='2025-05-14T17:55:27Z' progress=0.999326 cache=133.2MiB(940110txo)

2025-05-16T18:
...

💬 l3x3l commented on issue "Unusual "Wallet requires newer version" Error with wallet.dat on macOS, Even with Older Client":
(https://github.com/bitcoin/bitcoin/issues/32548#issuecomment-2889059597)
Debug.log

https://pastebin.com/xPDJUepN

💬 sipa commented on issue "Unusual "Wallet requires newer version" Error with wallet.dat on macOS, Even with Older Client":
(https://github.com/bitcoin/bitcoin/issues/32548#issuecomment-2889060955)
Ok, now I understand. It is Bitcoin Core 29.0 which complains that the wallet requires a newer version, even though the wallet file indicates a version of 210201.

💬 l3x3l commented on issue "Unusual "Wallet requires newer version" Error with wallet.dat on macOS, Even with Older Client":
(https://github.com/bitcoin/bitcoin/issues/32548#issuecomment-2889064710)
Yes. Is this something that can has happened in the past?
On Sun, May 18, 2025 at 9:40 AM Pieter Wuille ***@***.***>
wrote:

> *sipa* left a comment (bitcoin/bitcoin#32548)
> <https://github.com/bitcoin/bitcoin/issues/32548#issuecomment-2889060955>
>
> Ok, now I understand. It is Bitcoin Core 29.0 which complains that the
> wallet requires a newer version, even though the wallet file indicates a
> version of 210201.
>
> —
> Reply to this email directly, view it on GitHub
> <https:/
...

💬 maflcko commented on issue "Unusual "Wallet requires newer version" Error with wallet.dat on macOS, Even with Older Client":
(https://github.com/bitcoin/bitcoin/issues/32548#issuecomment-2889074717)
> * The user (me) does not have any backups of the wallet.dat file

My recommendation would be to start doing that, before you proceed further.

> -salvagewallet command was attempted

`salvagewallet` should create backups for you beside the original wallet dat file. My recommendation would be to not use salvagewallet, unless you know you have no backups and you know that the wallet file is corrupt. Otherwise, it can create more issues than it fixes.

Generally, BDB wallets are deprecated anywa
...

💬 l3x3l commented on issue "Unusual "Wallet requires newer version" Error with wallet.dat on macOS, Even with Older Client":
(https://github.com/bitcoin/bitcoin/issues/32548#issuecomment-2889079869)
I have all of my wallets backed up.

What steps should I take on migrating the wallet that gives the error it needs a newer version of bitcoin core?

💬 andrewtoth commented on pull request "contrib: add xor-blocks tool to obfuscate blocks directory":
(https://github.com/bitcoin/bitcoin/pull/32451#discussion_r2094569036)
Right, a byte array is alignment of 1, u128 is 16. I removed the unsafe cast for the key, but we still use unsafe for casting the buffer. It seems to always be at an address aligned to 16, but not sure how we can guarantee that.

💬 l3x3l commented on issue "Unusual "Wallet requires newer version" Error with wallet.dat on macOS, Even with Older Client":
(https://github.com/bitcoin/bitcoin/issues/32548#issuecomment-2889083038)
When I attempt to migrate the wallet I receive the same error asking for a newer version of bitcoin core.