💬 l0rinc commented on pull request "Update leveldb subtree to latest upstream":
(https://github.com/bitcoin/bitcoin/pull/32534#issuecomment-2887030315)
utACK 7015052eba23368539dcd1a9b4217ce1cacd2999

For the record, there are other `LevelDB` changes that could use some reviews: https://github.com/bitcoin-core/leveldb-subtree/pulls

💬 furszy commented on pull request "wallet: init, don't error out when loading legacy wallets":
(https://github.com/bitcoin/bitcoin/pull/32449#issuecomment-2887030525)
The issue is caused by the stderr warning message not being consumed. The framework expects stderr to be empty at the end of the test, without accounting for warning messages. Will update the test to clear the buffer after startup.

💬 mzumsande commented on pull request "validation: ensure assumevalid is always used during reindex":
(https://github.com/bitcoin/bitcoin/pull/31615#discussion_r2093270847)
I meant the 2100 (two weeks) of of blocks. I didn't test this, but is there a reason this couldn't just be a few blocks (plus a few more that aren't sent to the node)?

💬 maflcko commented on pull request "[28.x] build: suppress `-Wunterminated-string-initialization` in secp256k1":
(https://github.com/bitcoin/bitcoin/pull/32484#issuecomment-2887069576)
An alternative would be to just ignore the warning? CI on 28.x isn't using gcc 15 and users aren't really expected to compile with werror?

🤔 darosior reviewed a pull request: "test: properly check for per-tx sigops limit"
(https://github.com/bitcoin/bitcoin/pull/32533#pullrequestreview-2847007268)
Concept ACK

💬 fanquake commented on pull request "[28.x] build: suppress `-Wunterminated-string-initialization` in secp256k1":
(https://github.com/bitcoin/bitcoin/pull/32484#issuecomment-2887084027)
We could also do that. I guess it depends where we expect this branch to be compiled. Any downstream CIs, build systems, packagers etc may be turning warnings into errors. It doesn't seem bad for us to suppress known non-issues.

📝 maflcko opened a pull request: "rev_32343_wip_nomerge_ci"
(https://github.com/bitcoin/bitcoin/pull/32535)
pls ignore this is just a #32524 playground

💬 fanquake commented on pull request "build: Introduce internal kernel library":
(https://github.com/bitcoin/bitcoin/pull/28690#discussion_r2093340350)
Should also be easy to get `bitcoin_clientversion` out of here.

⚠️ hebasto opened an issue: "cmake: Cannot find Qt 6 on SunOS / illumos (OpenIndiana Distribution)"
(https://github.com/bitcoin/bitcoin/issues/32536)
Qt 6 was installed as follows:
```
$ sudo pkg install library/qt6
```

As a workaround, the `Qt6_DIR` CMake variable can be set manually:
```
$ cmake -B build -DBUILD_GUI=ON -DQt6_DIR=/usr/lib/qt/6.6/lib/amd64/cmake/Qt6
```

Alternatively, the [`Qt6_ROOT`](https://cmake.org/cmake/help/latest/variable/PackageName_ROOT.html) CMake or [environment](https://cmake.org/cmake/help/latest/envvar/PackageName_ROOT.html) variable can be used:
```
$ env Qt6_DIR=/usr/lib/qt/6.6/lib/amd64 cmake -B build -DBUI
...

💬 furszy commented on pull request "wallet: init, don't error out when loading legacy wallets":
(https://github.com/bitcoin/bitcoin/pull/32449#discussion_r2093346688)
sure, updated.

💬 furszy commented on pull request "wallet: init, don't error out when loading legacy wallets":
(https://github.com/bitcoin/bitcoin/pull/32449#discussion_r2093349150)
Would have liked to do this, but it's not enough. The stderr pipe still needs to be cleared before the test finishes, or the framework will treat the warning message as an error during cleanup.

📝 hebasto opened a pull request: "250516 win min ver"
(https://github.com/bitcoin/bitcoin/pull/32537)
Set minimum supported Windows version to 1903 (May 2019 Update).

This version is the minimum [required](https://learn.microsoft.com/en-us/windows/apps/design/globalizing/use-utf8-code-page#set-a-process-code-page-to-utf-8) to support the UTF-8 code page (CP_UTF8), which is necessary for https://github.com/bitcoin/bitcoin/pull/32380.

Additionally, the `symbol-check.py` script has been amended to verify application manifests for supported OS value.

💬 hebasto commented on pull request "Set minimum supported Windows version to 1903 (May 2019 Update)":
(https://github.com/bitcoin/bitcoin/pull/32537#issuecomment-2887193874)
My Guix build:
```
aarch64
db31eebbbd5ed99567eea6d1e692130815e0b6e6c7041e8fe20918eb743ce3db guix-build-4748c63c1d0f/output/aarch64-linux-gnu/SHA256SUMS.part
05ad41b64f57a027124138e3e5baf3325e4bcb433c851e9086526568068694f2 guix-build-4748c63c1d0f/output/aarch64-linux-gnu/bitcoin-4748c63c1d0f-aarch64-linux-gnu-debug.tar.gz
f230295bc79a313acaa16090609b28c6df6021213b8bd8dea9938b8e48037f17 guix-build-4748c63c1d0f/output/aarch64-linux-gnu/bitcoin-4748c63c1d0f-aarch64-linux-gnu.tar.gz
acc5897b
...

💬 hebasto commented on pull request "Modernize use of UTF-8 in Windows code":
(https://github.com/bitcoin/bitcoin/pull/32380#issuecomment-2887196672)
Rebased on https://github.com/bitcoin/bitcoin/pull/32537.

💬 TheCharlatan commented on pull request "build: Introduce internal kernel library":
(https://github.com/bitcoin/bitcoin/pull/28690#discussion_r2093366846)
I think it is just used for logging. I could just stub it out, like we do for the translation function, but I am also not as sure how important it really is to be printing the clientversion there for these logs.

💬 fanquake commented on pull request "build: Introduce internal kernel library":
(https://github.com/bitcoin/bitcoin/pull/28690#discussion_r2093371205)
Yea, we could probably drop that. There's also `CLIENT_VERSION` fed into the env RNG, which could also likely be dropped.

💬 Eunovo commented on pull request "validation: ensure assumevalid is always used during reindex":
(https://github.com/bitcoin/bitcoin/pull/31615#discussion_r2093372479)
Script checks are only skipped when the current block is roughly 2 weeks away from the tip. See https://github.com/bitcoin/bitcoin/blob/3f83c744ac28b700090e15b5dda2260724a56f49/src/validation.cpp#L2476-L2494

We have to bury the test block 2 weeks deep for script verification to the skipped

👍 fanquake approved a pull request: "ci: Enable feature_init and wallet_reorgsrestore in valgrind task"
(https://github.com/bitcoin/bitcoin/pull/32519#pullrequestreview-2847192390)
ACK fa2be605fee42c1286de2ddefbec976dde2c35ba - x86_64, aarch64

🚀 fanquake merged a pull request: "ci: Enable feature_init and wallet_reorgsrestore in valgrind task"
(https://github.com/bitcoin/bitcoin/pull/32519)

👍 fanquake approved a pull request: "scripted-diff: Remove unused leading newline in RPC docs"
(https://github.com/bitcoin/bitcoin/pull/32514#pullrequestreview-2847195929)
ACK fa1f10a49e7c4f6377fbc7ae2f1520b38c86e5fa