💬 davidgumberg commented on pull request "build: Revert "Temporarily disable compiling `fuzz/utxo_snapshot.cpp` with MSVC":
(https://github.com/bitcoin/bitcoin/pull/32525#issuecomment-2885854792)
reACK https://github.com/bitcoin/bitcoin/commit/fa0a4473a88017e525829ecd3db47f536c35fb62

📝 maflcko opened a pull request: "fuzz: Delete wallet_notifications"
(https://github.com/bitcoin/bitcoin/pull/32526)
The fuzz target has many issues:

* I has never found a meaningful issue.
* It is still slow, despite https://github.com/bitcoin/bitcoin/pull/28933 and https://github.com/bitcoin/bitcoin/pull/31238.
* It is unmaintained, see https://github.com/bitcoin/bitcoin/pull/28882#issuecomment-1814654792 (missing meaningful coverage) or https://github.com/bitcoin/bitcoin/pull/31238#issuecomment-2460821784 (unstable) or https://github.com/bitcoin/bitcoin/pull/31467#issuecomment-2672649759 (fix slowness)
...

💬 hodlinator commented on pull request "qa: feature_framework_startup_failures.py fixes & improvements (#30660 follow-up)":
(https://github.com/bitcoin/bitcoin/pull/32509#discussion_r2092465291)
> whats the rationale behind multiplying by factor of 60?

Default timeout-factor is 1, so we get 60 seconds.

Here's a similar pre-existing example:

https://github.com/bitcoin/bitcoin/blob/c47f634718d4248fd2a30e51a57944f89da72a64/test/functional/test_framework/test_framework.py#L765-L773

> on master I dont think running the functional test with timeout-factor=99998 will trigger any failure.

99998 does fail feature_framework_startup_failures.py on master, but skipping back before th
...

✅ maflcko closed an issue: "wallet: Data race in GetOrCreateLegacyScriptPubKeyMan vs IsMine"
(https://github.com/bitcoin/bitcoin/issues/27354)

💬 maflcko commented on issue "wallet: Data race in GetOrCreateLegacyScriptPubKeyMan vs IsMine":
(https://github.com/bitcoin/bitcoin/issues/27354#issuecomment-2885915250)
closing for now. unless there are steps to reproduce how a real user can be affected by this, it may be best to postpone this for now.

👍 hodlinator approved a pull request: "build: Revert "Temporarily disable compiling `fuzz/utxo_snapshot.cpp` with MSVC"
(https://github.com/bitcoin/bitcoin/pull/32525#pullrequestreview-2845791215)
ACK fa2c6623626719b338880f7bb097b902019d5956

Confirmed at least later patch-versions of 17.13 work here: https://github.com/bitcoin/bitcoin/pull/32499#issuecomment-2883487720

It's possible that the regression in 17.12 never made it to any of the patch-versions of 17.13.

🚀 fanquake merged a pull request: "build: Revert "Temporarily disable compiling `fuzz/utxo_snapshot.cpp` with MSVC"
(https://github.com/bitcoin/bitcoin/pull/32525)

💬 ajtowns commented on pull request "policy: uncap datacarrier by default":
(https://github.com/bitcoin/bitcoin/pull/32406#issuecomment-2885938653)
ACK 35bcd8eed38130445aef5ebe217ab42248fa6f18 -- only minor tweaks since previous review

[I wrote](https://github.com/bitcoin/bitcoin/pull/32406#pullrequestreview-2832143503):

> I don't think this PR will have any impact on fee estimation (the only way that would occur is if a large majority of the mempool were transactions with multiple OP_RETURN outputs or an OP_RETURN output larger than 83 bytes, and that's not the case).

[gmaxwell wrote](https://github.com/bitcoin/bitcoin/pull/32406#
...

🚀 fanquake merged a pull request: "qt, wallet: Convert uint256 to Txid"
(https://github.com/bitcoin/bitcoin/pull/32238)

💬 fanquake commented on issue "test: failure in `mining_basic.py` AssertionError: not(4.656542373906924E-10 == 4.656542373906925E-10)":
(https://github.com/bitcoin/bitcoin/issues/32515#issuecomment-2885964963)
Yea. Have only seen it under Valgrind.

💬 Eunovo commented on pull request "validation: ensure assumevalid is always used during reindex":
(https://github.com/bitcoin/bitcoin/pull/31615#discussion_r2092562248)
Will do

🚀 fanquake merged a pull request: "cmake: Add application manifests when cross-compiling for Windows"
(https://github.com/bitcoin/bitcoin/pull/32396)

💬 maflcko commented on pull request "ci: Enable feature_init and wallet_reorgsrestore in valgrind task":
(https://github.com/bitcoin/bitcoin/pull/32519#issuecomment-2886010555)
If someone wants to quickly test this outside the CI system a minimal reproducer would be:

```
───────┬────────────────────────────────────────────────────────────────────────
│ File: /tmp/a.py
───────┼────────────────────────────────────────────────────────────────────────
1 │ import subprocess
2 │ import time
3 │
4 │ process = subprocess.Popen(["bash", "/tmp/a.sh"])
5 │ print("Wait for the first print to happen ...")
6 │ time.sleep(0.1)
7
...

💬 fanquake commented on pull request "depends: bump to latest config.guess and config.sub":
(https://github.com/bitcoin/bitcoin/pull/32505#discussion_r2092584341)
I guess this will allow someone to try and build depends with an LLVM libc target. i.e:
```bash
# master
make -C depends/ HOST=aarch64-unknown-linux-llvm
make: Entering directory '/root/ci_scratch/depends'
Invalid configuration 'aarch64-unknown-linux-llvm': OS 'llvm' not recognized
```
```bash
# this branch
make -C depends/ HOST=aarch64-unknown-linux-llvm
make: Entering directory '/root/ci_scratch/depends'
Extracting native_qt..
```

👍 fanquake approved a pull request: "depends: bump to latest config.guess and config.sub"
(https://github.com/bitcoin/bitcoin/pull/32505#pullrequestreview-2845902109)
ACK 486bc91790721a37047762c1ea893c29746b4358

💬 davidgumberg commented on issue "Restrict RPCs that make server-side files":
(https://github.com/bitcoin/bitcoin/issues/20866#issuecomment-2886024029)
Related: https://github.com/bitcoin/bitcoin/issues/32274

💬 Eunovo commented on pull request "validation: ensure assumevalid is always used during reindex":
(https://github.com/bitcoin/bitcoin/pull/31615#discussion_r2092592761)
Are you referring to the 100 blocks mined after the first 2100 blocks?

🚀 fanquake merged a pull request: "init: drop `-upnp`"
(https://github.com/bitcoin/bitcoin/pull/32500)

🚀 fanquake merged a pull request: "depends: bump to latest config.guess and config.sub"
(https://github.com/bitcoin/bitcoin/pull/32505)

💬 vasild commented on pull request "net: improve the interface around FindNode() and avoid a recursive mutex lock":
(https://github.com/bitcoin/bitcoin/pull/32326#issuecomment-2886037713)
`4f635d100d...8668b0c64d`: address https://github.com/bitcoin/bitcoin/pull/32326#discussion_r2072443916