💬 DanM3rcurius commented on issue "Can't compile v24.0.1":
(https://github.com/bitcoin/bitcoin/issues/27680#issuecomment-1552379839)
It's building now! I used default parameters and left the GUI ins this time, so its taking quite a while ^^

The documentation in the github was absolutely fine. I added the BDB as I might need to access legacy wallets, for RasPi OS I had to add the `--build=aarch64-unknown-linux-gnu ` to the `./configure` command before building the DB.

For a noob like me it's important to know that the ./autogen.sh script and configure command are run after all dependencies have been installed. When I fir
...

💬 ajtowns commented on pull request "p2p: Stop relaying non-mempool txs":
(https://github.com/bitcoin/bitcoin/pull/27625#issuecomment-1552435967)
Concept ACK

The original use of `mapRelay` was that if a tx wasn't in `mapRelay` it wouldn't be relayed at all. That resulted in problems with child transactions -- if we relay a recent child to a peer that doesn't have the parent, the parent may have expired from `mapRelay` and thus the peer wouldn't be able to accept the child at all.

We fixed that with #16851 so that we'd relay txs from the mempool if they'd been in the mempool long enough to expire from `mapRelay` (ie, 15 minutes). Tha
...

💬 MarcoFalke commented on issue "test: use-of-uninitialized-value in sqlite3Strlen30":
(https://github.com/bitcoin/bitcoin/issues/27222#issuecomment-1552453177)
Ok, thanks for taking a look. If there is a reduced test case, it could make sense to report something upstream.

⚠️ faca5 opened an issue: "dumpprivkey - This type of wallet does not support this command (code -4)"
(https://github.com/bitcoin/bitcoin/issues/27693)
### Is there an existing issue for this?

- [X] I have searched the existing issues

### Current behaviour

Hello.

When I try export private key for bitcoin address i got:
This type of wallet does not support this command (code -4)

I tried on all 4 types of bitcoin address base58 and bech32 (legacy, segwit...).

I'm using ZIP version of Bitcoin Core v23.1.0 downloaded from:
https://bitcoincore.org/bin/bitcoin-core-23.1/bitcoin-23.1-win64.zip

### Expected behaviour

It should display p
...

💬 willcl-ark commented on issue "dumpprivkey - This type of wallet does not support this command (code -4)":
(https://github.com/bitcoin/bitcoin/issues/27693#issuecomment-1552647611)
Are you using a descriptor wallet? If so see conversation here: https://github.com/bitcoin/bitcoin/issues/26046

💬 MarcoFalke commented on pull request "p2p: Stop relaying non-mempool txs":
(https://github.com/bitcoin/bitcoin/pull/27625#issuecomment-1552665725)
> I think it would also be good to continue serving txs from `vExtraTxnForCompact`

I wasn't sure how to do this, given the planned removal of `m_recently_announced_invs` in https://github.com/bitcoin/bitcoin/pull/27675 . Otherwise we may relay invalid/non-standard transactions that were injected into us by a spy node.

Maybe a flag on each transaction in `vExtraTxnForCompact` could be set to indicate if it ever was in the mempool. Though that would still leave the fingerprint vector if the
...

💬 faca5 commented on issue "dumpprivkey - This type of wallet does not support this command (code -4)":
(https://github.com/bitcoin/bitcoin/issues/27693#issuecomment-1552682174)
Looks like.

I just downloaded latest version for Windows, created Bitcoin address and like to export private keys.

None of bitcoin address types any more works to export private keys:
Base58 (Legacy)
Base58 (P2SH-SegWit)
Bech32 (SegWit)
Back32m (Taproot)

When you are owner of bitcoin address you expect to get PRIVATE and PUBLIC keys.

In latest version of Bitcoin core I haven't found any settings to set bitcoin address as descriptor or normal one.

Any idea how to create bitcoin
...

💬 faca5 commented on issue "dumpprivkey - This type of wallet does not support this command (code -4)":
(https://github.com/bitcoin/bitcoin/issues/27693#issuecomment-1552693835)
On Bitcoin Core version v0.14.2 works without problem.

💬 dergoegge commented on pull request "fuzz: net, add `recv_flood_size`, `prefer_evict` in `ConsumeNode`":
(https://github.com/bitcoin/bitcoin/pull/27678#issuecomment-1552706486)
I think this would be a good thing to do if our current targets would be fuzzing the logic that these params are influencing (afaict this is not the case right now) but without that it unfortunately just invalidates our input corpora.

* `prefer_evict` is only used in `CConnman::AttemptToEvictConnection` which is currently not being fuzzed.
* `recv_flood_size` is used to set the value of `CNode::fPauseRecv` which is used to determine if we should stop reading from the socket in `CConnman::Gen
...

💬 GregTonoski commented on issue "dumpprivkey - This type of wallet does not support this command (code -4)":
(https://github.com/bitcoin/bitcoin/issues/27693#issuecomment-1552706536)
> I have already found issue #26046 but there is not any solution on how to export private keys for my own bitcoin address.

Does the RPC `listdescriptors true ` instead of `dumpprivkey` gives you the information, perhaps?

💬 faca5 commented on issue "dumpprivkey - This type of wallet does not support this command (code -4)":
(https://github.com/bitcoin/bitcoin/issues/27693#issuecomment-1552713353)
Yes. It show list of descriptors.

⚠️ GregTonoski opened an issue: "QStandardPaths: runtime directory '/mnt/wslg/runtime-dir' is not owned by UID 0"
(https://github.com/bitcoin/bitcoin/issues/27694)
### Is there an existing issue for this?

- [X] I have searched the existing issues

### Current behaviour

There is the message after launching bitcoin-qt in Windows Subsystem for Linux:
```
# /usr/local/bin/b25/bitcoin-qt
QStandardPaths: runtime directory '/mnt/wslg/runtime-dir' is not owned by UID 0, but a directory permissions 0700 owned by UID 1000 GID 1000
```

Bitcoin-qt is launched successfully and runs smoothly despite the message.

### Expected behaviour

There isn't the unexpect
...

🤔 dergoegge reviewed a pull request: "fuzz: Print error message when FUZZ is missing"
(https://github.com/bitcoin/bitcoin/pull/27672#pullrequestreview-1432271319)
Concept ACK

💬 dergoegge commented on pull request "fuzz: Print error message when FUZZ is missing":
(https://github.com/bitcoin/bitcoin/pull/27672#discussion_r1197545568)
nit: Would it be good to hint at `PRINT_ALL_FUZZ_TARGETS_AND_ABORT=1` in the message?

💬 ajtowns commented on pull request "p2p: Stop relaying non-mempool txs":
(https://github.com/bitcoin/bitcoin/pull/27625#issuecomment-1552718608)
> How would you judge "relevant"? I presume you are looking for rbf'd transactions that were requested from mapRelay and ended up in a block, but the block was not yet available to you?

I'm still tweaking the logging, but so far what I'm seeing seems like roughly:

* 95% relay from the mempool
* of the 5% that don't:
* 87% are recent txs included in the most recent block (so would also be available via mapRelay)
* 12% are recent txs not in the most recent block, so only via mapRe
...

💬 GregTonoski commented on issue "dumpprivkey - This type of wallet does not support this command (code -4)":
(https://github.com/bitcoin/bitcoin/issues/27693#issuecomment-1552718812)
You will find the information about how to use the command at https://bitcoin.stackexchange.com/ and https://github.com/bitcoin/bitcoin/blob/master/doc/descriptors.md
It is not simple enough to summarize in a sentence or two here.

💬 faca5 commented on issue "dumpprivkey - This type of wallet does not support this command (code -4)":
(https://github.com/bitcoin/bitcoin/issues/27693#issuecomment-1552722538)
Thank you.

✅ faca5 closed an issue: "dumpprivkey - This type of wallet does not support this command (code -4)"
(https://github.com/bitcoin/bitcoin/issues/27693)

💬 MarcoFalke commented on issue "QStandardPaths: runtime directory '/mnt/wslg/runtime-dir' is not owned by UID 0":
(https://github.com/bitcoin/bitcoin/issues/27694#issuecomment-1552733362)
https://stackoverflow.com/questions/72733724/qstandardpaths-runtime-directory-run-user-1000-is-not-owned-by-uid-0-but-a#comment131102495_72733724

💬 fanquake commented on issue "QStandardPaths: runtime directory '/mnt/wslg/runtime-dir' is not owned by UID 0":
(https://github.com/bitcoin/bitcoin/issues/27694#issuecomment-1552735362)
Should also be moved to the GUI repo.