💬 stringintech commented on pull request "Add checkBlock() to Mining interface":
(https://github.com/bitcoin/bitcoin/pull/31981#discussion_r2091754628)
Thank you for the clarification.

✅ pinheadmz closed an issue: "Open Alias support?"
(https://github.com/bitcoin/bitcoin/issues/32284)

💬 pinheadmz commented on issue "Open Alias support?":
(https://github.com/bitcoin/bitcoin/issues/32284#issuecomment-2884725663)
Closing this as not planned for now, thanks.

🤔 w0xlt reviewed a pull request: "wallet: Use `util::Error` throughout `AddWalletDescriptor` instead of returning `nullptr` for some errors"
(https://github.com/bitcoin/bitcoin/pull/32475#pullrequestreview-2844660917)
ACK https://github.com/bitcoin/bitcoin/pull/32475/commits/f17945b347f6a46dee3b56f86a557eaccec1bc72

💬 theStack commented on pull request "descriptors: MuSig2":
(https://github.com/bitcoin/bitcoin/pull/31244#discussion_r2091162026)
nit: could add a comment where this constant is coming from (https://github.com/bitcoin/bips/blob/master/bip-0328.mediawiki#cite_note-1)

💬 theStack commented on pull request "descriptors: MuSig2":
(https://github.com/bitcoin/bitcoin/pull/31244#discussion_r2091770520)
note for other reviewers that might wonder: these two functions and the involved `secp256k1_musig_keyagg_cache` instance are not publicly used within this PR yet, but they will be in #29675 (or any other future PRs that get split up from that one)

💬 pinheadmz commented on issue "Migrate from BTC/kvB to sat/vB on RPC and startup options":
(https://github.com/bitcoin/bitcoin/issues/32093#issuecomment-2884755244)
Don't forget that `fundrawtransaction` accepts two different units, depending on snake case / camel case (!)

```
"fee_rate": amount, Specify fee rate in sat/vB.
"feeRate": amount, Specify fee rate in BTC/kvB.
```

I wonder if we could even handle complete strings so users can just do whatever they need, i.e. correctly parse strings like `100s/B` vs `0.00001 BTC/kb`

👍 willcl-ark approved a pull request: "[28.x] 28.2rc1"
(https://github.com/bitcoin/bitcoin/pull/32480#pullrequestreview-2844686716)
ACK 186e3f1fb65bb693154c0b63b690bea1d279f089

`git grep v28` doesn't show any un-bumped versions.

✅ pinheadmz closed an issue: "TSan warning with legacy wallet on macos ("too long mutex cycle found")"
(https://github.com/bitcoin/bitcoin/issues/31986)

💬 pinheadmz commented on issue "TSan warning with legacy wallet on macos ("too long mutex cycle found")":
(https://github.com/bitcoin/bitcoin/issues/31986#issuecomment-2884764494)
Fixed by removing legacy wallet https://github.com/bitcoin/bitcoin/pull/28710

👋 instagibbs's pull request is ready for review: "test: add MAX_DISCONNECTED_TX_POOL_BYTES coverage"
(https://github.com/bitcoin/bitcoin/pull/32516)

💬 pinheadmz commented on issue "Running out of memory on a 2GB box - Initializing chainstate Chainstate [ibd] @ height -1 (null)":
(https://github.com/bitcoin/bitcoin/issues/31573#issuecomment-2884794681)
Any updates on this issue? I'll also point out that 2 GB is the [bare minimum](https://bitcoin.org/en/full-node#minimum-requirements).

💬 hodlinator commented on pull request "qa: Verify clean shutdown on startup failure":
(https://github.com/bitcoin/bitcoin/pull/30660#issuecomment-2884807855)
@ryanofsky & @ismaelsadeeq some of your remaining comments are addressed and ready for review in follow-up PR #32509. (Happy to get review from others as well of course).

💬 pinheadmz commented on issue "getblockchaininfo `verificationprogress` never reaches 1.0":
(https://github.com/bitcoin/bitcoin/issues/31127#issuecomment-2884833770)
This is a FAQ but is always closed as not planned. In my opinion, `progress` is only useful the first day you start a node to get some idea how long it'll take to be useable. I believe `lnd` returns `synced: true` whenever the tip timestamp is within two hours of now. I don't think bitcoind should "round up" the progress to 1 for UX reasons, the user or api consumer should decide on their own how risky their use case is it has been more than 0 seconds since receiving a new block.

🤔 furszy reviewed a pull request: "wallet: init, don't error out when loading legacy wallets"
(https://github.com/bitcoin/bitcoin/pull/32449#pullrequestreview-2844762782)
Updated per feedback. Additional test coverage included.

💬 pinheadmz commented on issue "Distribute darknet node addresses via DNS seeds using AAAA records":
(https://github.com/bitcoin/bitcoin/issues/31062#issuecomment-2884851261)
Do we need to hack DNS records for this? We have [BIP155](https://github.com/bitcoin/bips/blob/master/bip-0155.mediawiki) addrv2 messages to relay onion peers, all you need is one bitcoin peer to collect those.

The hard coded seeds list also provides onion, CJDNS, and i2p addresses.

💬 jonatack commented on issue "getblockchaininfo `verificationprogress` never reaches 1.0":
(https://github.com/bitcoin/bitcoin/issues/31127#issuecomment-2884853355)
I think it's also useful when your node comes back online after a shutdown or an outage (I have -getinfo along with -netinfo running as live `watch` dashboards, along with the debug log).

> the first day you start a node

One day to sync 😍 last 3 times I synced a node, it took between 10 days and 5 weeks depending on internet bandwidth + reliability.

That said, I agree this pull wasn't the best possible approach.

💬 pablomartin4btc commented on pull request "wallet: init, don't error out when loading legacy wallets":
(https://github.com/bitcoin/bitcoin/pull/32449#discussion_r2091843907)
I think similar to this one "assert_start_raises_init_error"... no?

✅ pinheadmz closed an issue: "Blockchain fully synced, but `bitcoin-cli -getinfo` shows `verification progress: 99.9999%`"
(https://github.com/bitcoin/bitcoin/issues/28847)

💬 pinheadmz commented on issue "Blockchain fully synced, but `bitcoin-cli -getinfo` shows `verification progress: 99.9999%`":
(https://github.com/bitcoin/bitcoin/issues/28847#issuecomment-2884884698)
Closing as duplicate of #31127 also #30293 and many others