💬 achow101 commented on pull request "wallet: Ensure best block matches wallet scan state":
(https://github.com/bitcoin/bitcoin/pull/30221#discussion_r2089478709)
Indeed, done.

💬 pinheadmz commented on pull request "Replace libevent with our own HTTP and socket-handling implementation":
(https://github.com/bitcoin/bitcoin/pull/32061#discussion_r2089484885)
Happy to change the names, I just needed to separate the old libevent server from the new one in the PR in the series of commits where each namespace has classes like `HTTPRequest`

💬 maflcko commented on issue "test: wallet_reorgsrestore.py failure under valgrind":
(https://github.com/bitcoin/bitcoin/issues/32493#issuecomment-2881115243)
Ubuntu Archives were down today, so I applied some patches before reproducing:

```diff
diff --git a/ci/test/01_base_install.sh b/ci/test/01_base_install.sh
index 1344563268..49aeeacf53 100755
--- a/ci/test/01_base_install.sh
+++ b/ci/test/01_base_install.sh
@@ -21,6 +21,9 @@ if [ -n "$DPKG_ADD_ARCH" ]; then
dpkg --add-architecture "$DPKG_ADD_ARCH"
fi

+apt update && apt install ca-certificates -y
+echo -e "# Packages and Updates from the Hetzner Ubuntu Mirror\ndeb https://mirror.hetzner.co
...

📝 davidgumberg opened a pull request: "wallet: Drop unused fFromMe from CWalletTx"
(https://github.com/bitcoin/bitcoin/pull/32502)
This has been unused since commit fe52346, this is a re-opening of #9351 by @ryanofsky.

💬 mzumsande commented on pull request "wallet: Ensure best block matches wallet scan state":
(https://github.com/bitcoin/bitcoin/pull/30221#discussion_r2089511246)
Also just mentioning that `rescanblockchain` can be used with ranges (`start_height` / `stop_height`). If `stop_height` is set to some past block, setting the best block back to that old block would be incorrect and lead to wrong balances etc.

💬 achow101 commented on pull request "rpc: Undeprecate rpcuser/rpcpassword, store all credentials hashed in memory":
(https://github.com/bitcoin/bitcoin/pull/32423#discussion_r2089511624)
In 98ff38a6f1a8a1e214bd3905a2dcac31ae6c2f52 "rpc: Perform HTTP user:pass split once in `RPCAuthorized`"

Could use `util::Split` instead of reimplementing split

💬 maflcko commented on pull request "wallet: Drop unused fFromMe from CWalletTx":
(https://github.com/bitcoin/bitcoin/pull/32502#issuecomment-2881173072)
lgtm ACK 5bf91ba8800d23402536d758f02198eac0fd7d61

💬 maflcko commented on pull request "wallet: Drop unused fFromMe from CWalletTx":
(https://github.com/bitcoin/bitcoin/pull/32502#issuecomment-2881175789)
(please no `@` in the pull description, otherwise people will get pinged for every cherry-pick of the merge commit, which includes this)

💬 davidgumberg commented on pull request "wallet: Drop unused fFromMe from CWalletTx":
(https://github.com/bitcoin/bitcoin/pull/32502#issuecomment-2881180201)
> (please no `@` in the pull description, otherwise people will get pinged for every cherry-pick of the merge commit, which includes this)

Fixed, thanks.

💬 maflcko commented on issue "test: wallet_reorgsrestore.py failure under valgrind":
(https://github.com/bitcoin/bitcoin/issues/32493#issuecomment-2881185001)
It is a bit confusing, because it passes fine outside of the CI system.

⚠️ SignalMQ opened an issue: "Dark Mode for users"
(https://github.com/bitcoin/bitcoin/issues/32503)
### Please describe the feature you'd like to see added.

Hello everyone!

It would be nice to see a dark mode in this app because everything on my computer is in dark mode and one Core application is in native mode.

### Is your feature related to a problem, if so please describe it.

Visual contrast in light theme

### Describe the solution you'd like

Make an Dark theme for this application.

### Describe any alternatives you've considered

- Windows 11
- Visual Studio Code
- Docker CE
- DBea
...

💬 hebasto commented on issue "Dark Mode for users":
(https://github.com/bitcoin/bitcoin/issues/32503#issuecomment-2881356552)
Duplicate of https://github.com/bitcoin-core/gui/issues/378.

✅ hebasto closed an issue: "Dark Mode for users"
(https://github.com/bitcoin/bitcoin/issues/32503)

💬 achow101 commented on pull request "interfaces: refactor: move `Mining` and `BlockTemplate` implementation to miner":
(https://github.com/bitcoin/bitcoin/pull/32378#issuecomment-2881360377)
ACK 62fc42d475df4f23bd93313f95ee7b7eb0d4683f

🚀 achow101 merged a pull request: "interfaces: refactor: move `Mining` and `BlockTemplate` implementation to miner"
(https://github.com/bitcoin/bitcoin/pull/32378)

💬 sipsorcery commented on pull request "cmake: Restrict MSVC-specific workaround to affected versions":
(https://github.com/bitcoin/bitcoin/pull/32499#issuecomment-2881408178)
utACK 677943032785253ab268e51c9d37fbacc1483568.

17.14 is still in preview so can't test yet (would rather avoid the >10GB download and install for the sake of a week or two).

🚀 achow101 merged a pull request: "test: add test for decoding PSBT with MuSig2 PSBT key types (BIP 373)"
(https://github.com/bitcoin/bitcoin/pull/32305)

📝 brunoerg opened a pull request: "test: descriptor: cover invalid multi/multi_a cases"
(https://github.com/bitcoin/bitcoin/pull/32504)
This PR adds test coverage for invalid `multi()` and `multi_a()` cases, see:

1. https://github.com/bitcoin/bitcoin/blob/53eb5593f0a1a8ae5cf0fabea58e2f22193a5c55/src/script/descriptor.cpp#L1819-L1821

2. https://github.com/bitcoin/bitcoin/blob/53eb5593f0a1a8ae5cf0fabea58e2f22193a5c55/src/script/descriptor.cpp#L1835-L1837

3. https://github.com/bitcoin/bitcoin/blob/53eb5593f0a1a8ae5cf0fabea58e2f22193a5c55/src/script/descriptor.cpp#L1838-L1840


We could also exercise to exceed the numbe
...

💬 l0rinc commented on pull request "(RFC) kernel: Replace leveldb-based BlockTreeDB with flat-file based store":
(https://github.com/bitcoin/bitcoin/pull/32427#issuecomment-2881521463)
I didn't have time to review this in detail - nor to form a detailed concept/approach feedback, but I ran a few reindexes to see if it affects performance because somebody was referring to this as an optimization and wanted to understand if that's indeed the case.

I ran a `reindex` until 888,888 comparing the speed against master.

<details>
<summary>Details</summary>

```bash
COMMITS="14b8dfb2bd5e2ca2b7c0c9a7f7d50e1e60adf75c fabd3ab615a7c718f37a60298a125864edb6106b"; \
STOP_HEIGHT=888
...

💬 stickies-v commented on pull request "RPC: removeprunedfunds should take an array of txids":
(https://github.com/bitcoin/bitcoin/pull/32501#issuecomment-2881554859)
This seems very similar to the approach taken in https://github.com/bitcoin/bitcoin/pull/29468. There were a couple of unaddressed review comments that seem to apply here too, so I think it would be good to list and address them. Furthermore, it might be appropriate to credit the original author?