💬 laanwj commented on pull request "lint: Check for missing trailing newline":
(https://github.com/bitcoin/bitcoin/pull/32477#issuecomment-2876400295)
Concept ACK it makes sense to be consistent on this, it's kind of annoying if commit A adds a newline at the end, B removes it again, C adds it again etc. On the other hand i hope we can trust (especially random contributors) to know how their editors work and not have to explain it.

💬 theStack commented on pull request "test: add test for malleated transaction with valid witness":
(https://github.com/bitcoin/bitcoin/pull/32385#issuecomment-2876406989)
Concept ACK

Seems useful to create a pair of valid "same-txid-different-wtxid" transactions for testing purposes.

Didn't try that yet, but I think another possibility to create these without having to involve signatures at all would be a "trivial math puzzle"-like locking script of e.g. "OP_ADD OP_EQUAL 5" (in a p2wsh or p2tr script-path) and swapped witness data elements ([1,4] and [4,1]) in the spending txs.

🚀 fanquake merged a pull request: "[28.x] Backports"
(https://github.com/bitcoin/bitcoin/pull/32299)

💬 Sjors commented on pull request "signet: omit commitment for some trivial challenges":
(https://github.com/bitcoin/bitcoin/pull/29032#issuecomment-2876437307)
> I was wondering whether OP_2...OP_16 should also be treated as trivial,

It may be useful to have multiple public signets out there and avoid them accidentally reorging each other.

💬 instagibbs commented on pull request "cluster mempool: add txgraph diagrams/mining/eviction":
(https://github.com/bitcoin/bitcoin/pull/31444#issuecomment-2876491745)
reACK 8673e8f01917b48a5f5476792f759f44ea49d5a5

`git range-diff master 7208ec2f1f0b9d72e1b4248dae9adbcc5ab625f7 8673e8f01917b48a5f5476792f759f44ea49d5a5`

Consolidated main ordering checks, added explicit variable for tracking end of cluster in blockbuilder, Hand-checked that `m_known_end_of_cluster` is set anytime it is read from, LGTM.

💬 fanquake commented on pull request "doc: document workaround and fallback for macOS fuzzing":
(https://github.com/bitcoin/bitcoin/pull/32084#discussion_r2086824216)
I don't think we are going to merge changes here in regards to setting architectures etc.

💬 stickies-v commented on pull request "lint: Check for missing trailing newline":
(https://github.com/bitcoin/bitcoin/pull/32477#discussion_r2086831091)
You should only be counting files tracked by git: `git ls-files | sed -n 's/.*\.//p' | sort | uniq -c | sort -rn`

👍 hodlinator approved a pull request: "cmake: Add application manifests when cross-compiling for Windows"
(https://github.com/bitcoin/bitcoin/pull/32396#pullrequestreview-2836787793)
re-ACK c0f41523973e33a8cd104a8ebf4906a4d99f3eed

Changes since [initial ACK](https://github.com/bitcoin/bitcoin/pull/32396#pullrequestreview-2826464805):
* Rebased to handle file move: contrib/devtools/symbol-check.py -> contrib/guix/symbol-check.py

📝 fanquake opened a pull request: "[27.x] Backports"
(https://github.com/bitcoin/bitcoin/pull/32479)
Backports
- #32070
- #32187
- #32286

📝 fanquake opened a pull request: "[28.x] 28.2rc1"
(https://github.com/bitcoin/bitcoin/pull/32480)
Final changes for `v28.2rc1`.

💬 vasild commented on pull request "rpc: add cpu_load to getpeerinfo":
(https://github.com/bitcoin/bitcoin/pull/31672#issuecomment-2876588108)
`19c8336d97...8b8b854346`: address suggestions

💬 juanitoddd commented on pull request "policy: uncap datacarrier by default":
(https://github.com/bitcoin/bitcoin/pull/32406#issuecomment-2876596959)
Concept NACK

There should be freedom and sovereignty on what users relay on their nodes mempool. To marked them as deprecated sets the precedent that in the future node runners wont be able to configure this.

💬 vasild commented on pull request "rpc: add cpu_load to getpeerinfo":
(https://github.com/bitcoin/bitcoin/pull/31672#discussion_r2086877583)
Took some, thanks!

💬 maflcko commented on pull request "lint: Check for missing trailing newline":
(https://github.com/bitcoin/bitcoin/pull/32477#discussion_r2086882108)
Happy to add any, if you see one and a reason to add it and no reason against adding it.

👍 pinheadmz approved a pull request: "config: allow setting -proxy per network"
(https://github.com/bitcoin/bitcoin/pull/32425#pullrequestreview-2836872116)
ACK e98c51fcce9ae3f441a416cab32a5c85756c6c64

Trivial changes since last ACK. Built and tested again on mainnet, this time added i2p as well, connected to peers on every network we support. Tried various proxy settings.

The code change is small and mostly just contained in `init.cpp`. We used to call `SetProxy()` on every network type with the same proxy endpoint, this new code parses more fine-grained config options and sets separate proxies based on the options.

<details><summary>Show
...

💬 maflcko commented on pull request "lint: Check for missing trailing newline":
(https://github.com/bitcoin/bitcoin/pull/32477#discussion_r2086887015)
Not sure. This will make compile time and runtime slower. I don't see the point?

💬 maflcko commented on pull request "lint: Check for missing trailing newline":
(https://github.com/bitcoin/bitcoin/pull/32477#discussion_r2086887675)
thx, done

👋 fanquake's pull request is ready for review: "[29.x] Backports"
(https://github.com/bitcoin/bitcoin/pull/32292)

💬 instagibbs commented on pull request "policy: uncap datacarrier by default":
(https://github.com/bitcoin/bitcoin/pull/32406#discussion_r2086911846)
that's not the same behavior IIUC

```
diff --git a/test/functional/mempool_datacarrier.py b/test/functional/mempool_datacarrier.py
index 6347215b86..ce1d65a9ed 100755
--- a/test/functional/mempool_datacarrier.py
+++ b/test/functional/mempool_datacarrier.py
@@ -20,16 +20,17 @@ from random import randbytes
# The historical maximum, now used to test coverage
CUSTOM_DATACARRIER_ARG = 83

class DataCarrierTest(BitcoinTestFramework):
def set_test_params(self):
- self.num_
...

💬 edilmedeiros commented on pull request "signet: omit commitment for some trivial challenges":
(https://github.com/bitcoin/bitcoin/pull/29032#issuecomment-2876659639)
> > I was wondering whether OP_2...OP_16 should also be treated as trivial,
>
> It may be useful to have multiple public signets out there and avoid them accidentally reorging each other.

It would be useful indeed.

[BIP325](https://github.com/bitcoin/bips/blob/master/bip-0325.mediawiki) specifies a behavior that's impossible to detect in the general case, though:

> There is one other acceptable special case: if a block's challenge is e.g. `OP_TRUE` (`0x51`), where an empty solution w
...