🚀 fanquake merged a pull request: "guix: move `*-check.py` scripts under contrib/guix/"
(https://github.com/bitcoin/bitcoin/pull/32458)

💬 copy2018 commented on pull request "policy: uncap datacarrier by default":
(https://github.com/bitcoin/bitcoin/pull/32406#issuecomment-2873664099)
> These two statements are incongruent with each other, as out-of-band services directly undermine the decentralization and accessibility of the network by eroding the transparency of the fee market as well as miner rewards.

It’s true that out-of-band services introduce inefficiencies or opacity, but they do not fundamentally undermine Bitcoin’s decentralization in the same way that relaxing the datacarriersize limit would. Out-of-band services operate as opt-in, market-driven solutions tailo
...

👋 fanquake's pull request is ready for review: "[28.x] Backports"
(https://github.com/bitcoin/bitcoin/pull/32299)

🤔 hebasto reviewed a pull request: "guix: move `*-check.py` scripts under contrib/guix/"
(https://github.com/bitcoin/bitcoin/pull/32458#pullrequestreview-2834190263)
My Guix build:
```
aarch64
f15ff81485789fe4fa22c3ecf887cfbfa0b3ae8620fd8c8926deb257ef19cff9 guix-build-415650cea94f/output/aarch64-linux-gnu/SHA256SUMS.part
7320f11f0ff5005d841dc2d854f46c5d317df077dae41b4631493f090b34875c guix-build-415650cea94f/output/aarch64-linux-gnu/bitcoin-415650cea94f-aarch64-linux-gnu-debug.tar.gz
af696399978c60a9517006c8435d8053b541b3dcfec49dacaa46932404d22b7b guix-build-415650cea94f/output/aarch64-linux-gnu/bitcoin-415650cea94f-aarch64-linux-gnu.tar.gz
6da90889
...

💬 jesterhodl commented on pull request "doc: Fix typo":
(https://github.com/bitcoin/bitcoin/pull/32472#issuecomment-2873670146)
Thanks :-)

🤔 hebasto reviewed a pull request: "guix: move `*-check.py` scripts under contrib/guix/"
(https://github.com/bitcoin/bitcoin/pull/32458#pullrequestreview-2834192070)
Post-merge ACK 415650cea94f5050d7c368fdf9fd9878809957e1.

💬 polespinasa commented on pull request "rpc: generatetomany":
(https://github.com/bitcoin/bitcoin/pull/32468#issuecomment-2873672475)
> * `generateblock` is much more flexible than `generatetoaddress` (or `generatetodescriptor`), since it takes the txs to include as the second argument. For advanced test cases, it is likely that users would want this functionality to test multiple output coinbases with blocks that mine non-standard txs or otherwise don't mine the entire mempool. They would not have this capability with `generatetomany` as implemented here, but would have that for free with `generateblock`.

This is a fair po
...

💬 moth-oss commented on pull request "policy: uncap datacarrier by default":
(https://github.com/bitcoin/bitcoin/pull/32406#issuecomment-2873678445)
> @moth-oss config options are not removed in this pull request.

It is deprecating the option though. I don't think deprecating it now is the right move. Increase the default (ideally not disabled/max) and see how things go before making the decision to deprecate it.

🤔 glozow reviewed a pull request: "cluster mempool: add txgraph diagrams/mining/eviction"
(https://github.com/bitcoin/bitcoin/pull/31444#pullrequestreview-2834208934)
ACK 7208ec2f1f0

Light code review + tested by [implementing](https://github.com/glozow/bitcoin/commits/2025-04-package-validation/) a package linearizer + chunker on top of `TxGraph` and running #26711 unit tests. It is linearizing and chunking the transactions as I expect, which is great (it still has trouble with cases like RBF, chunks not fitting, and skipping non-descendants, but definitely out of scope for this PR).

💬 darosior commented on pull request "Introduce per-txin sighash midstate cache for legacy/p2sh/segwitv0 scripts":
(https://github.com/bitcoin/bitcoin/pull/32473#discussion_r2085282675)
It did, legacy skips `OP_CODESEPARATOR`s in the suffix (i.e. "upcoming `CODESEP`s") whereas Segwit v0 doesn't.

💬 willcl-ark commented on pull request "policy: uncap datacarrier by default":
(https://github.com/bitcoin/bitcoin/pull/32406#issuecomment-2873707039)
Reminder that this project's current [moderation guidelines](https://github.com/bitcoin-core/meta/blob/main/MODERATION-GUIDELINES.md) describe what we expect of contributors to this repository.

To keep it productive, especially on threads like these please:

- Stay on-topic: discuss the patch, not Bitcoin in general.
- Critique ideas, not motives.
- Contribute new signal: avoid repeating arguments already made earlier (these will start being marked as duplicate, to make the thread easier
...

💬 sipa commented on pull request "Introduce per-txin sighash midstate cache for legacy/p2sh/segwitv0 scripts":
(https://github.com/bitcoin/bitcoin/pull/32473#discussion_r2085298526)
Ah, yes, but this all happens before the call to `LegacySignatureMsg()`, which filters out the `OP_CODESEPARATOR`s that remain. In either case, this function `default_scriptcode_suffix` is exercised for both p2wsh and p2sh, so the fact that the test works should mean something...

💬 1440000bytes commented on pull request "policy: uncap datacarrier by default":
(https://github.com/bitcoin/bitcoin/pull/32406#issuecomment-2873734612)
> > @moth-oss config options are not removed in this pull request.
>
> It is deprecating the option though. I don't think deprecating it now is the right move. Increase the default (ideally not disabled/max) and see how things go before making the decision to deprecate it.

Deprecation notice can last for years: https://github.com/bitcoin/bitcoin/pull/32406#issuecomment-2861778194

🤔 BootsStribling reviewed a pull request: "policy: uncap datacarrier by default"
(https://github.com/bitcoin/bitcoin/pull/32406#pullrequestreview-2834259644)
Concept NACK.

While appearing to be a compromise, this PR uniquely does not achieve the desired outcomes of either faction as stated in [#32359]( https://github.com/bitcoin/bitcoin/pull/32359) and as such is ineffective.

You might say this is the nature of a compromise, but I find this "splitting the difference" strategy to be uniquely harmful in its result.

This PR achieves none of the stated benefits of #32359 which were:
* better fee estimation/ unification of mempool state
* redu
...

💬 bigshiny90 commented on pull request "policy: uncap datacarrier by default":
(https://github.com/bitcoin/bitcoin/pull/32406#issuecomment-2873751241)
> > > @moth-oss config options are not removed in this pull request.
> >
> >
> > It is deprecating the option though. I don't think deprecating it now is the right move. Increase the default (ideally not disabled/max) and see how things go before making the decision to deprecate it.
>
> Deprecation notice can last for years: [#32406 (comment)](https://github.com/bitcoin/bitcoin/pull/32406#issuecomment-2861778194)

Deprecation is a clear signal that a feature will be removed in the futu
...

💬 n4HeVQSGqDeEu6 commented on pull request "policy: uncap datacarrier by default":
(https://github.com/bitcoin/bitcoin/pull/32406#issuecomment-2873760187)
Concept NACK.

There clearly is no consensus, moving forward now will completely destroy the core reputation.

💬 andrewtoth commented on pull request "rpc: generatetomany":
(https://github.com/bitcoin/bitcoin/pull/32468#issuecomment-2873767514)
Consider if we already had the functionality for this in `generateblock` - what would be the motivation to add a new RPC `generatetomany`?
Note that `sendtoaddress` and `sendmany` have both been superseded by `send`, but the older RPCs can't easily be removed. `sendall` is an interesting case, which we might want to mimic instead of adding a `remainder` field.

💬 0106003 commented on pull request "Introduce per-txin sighash midstate cache for legacy/p2sh/segwitv0 scripts":
(https://github.com/bitcoin/bitcoin/pull/32473#issuecomment-2873770410)



-------- البريد الإلكتروني الأصلي --------
من: Pieter Wuille ***@***.***>
مرسل: ١٢ مايو ٢٠٢٥ ١٠:١٦:٢٢ م GMT+03:00
ل: bitcoin/bitcoin ***@***.***>
نسخة: Subscribed ***@***.***>
موضوع: Re: [bitcoin/bitcoin] Introduce per-txin sighash midstate cache for legacy/p2sh/segwitv0 scripts (PR #32473)

@sipa commented on this pull request.



> @@ -218,6 +222,20 @@ def default_controlblock(ctx):
"""Default expression for "controlblock": combine leafversion, negflag, pubkey_internal,
...

💬 k98kurz commented on pull request "policy: uncap datacarrier by default":
(https://github.com/bitcoin/bitcoin/pull/32406#issuecomment-2873839263)
@BootsStribling
> This PR achieves none of the stated benefits of #32359 which were:
>
> * reduction of harm through the use of OP_RETURN rather than witness storage
>
> The ultimate result of this particular PR will be:
>
> * continued use of witness data field for arbitrary data incentivized by lower cost from witness discount

The harm reduction argument is that OP_RETURN use allows L2 users an alternative to stuffing arbitrary data into non-provably unspendable outputs that bloa
...

💬 fjahr commented on pull request "checkqueue: make the queue non-optional for CCheckQueueControl and drop legacy locking macro usage":
(https://github.com/bitcoin/bitcoin/pull/32467#discussion_r2085377969)
double-nit: maybe `m_queue`