💬 hebasto commented on pull request "test: Add missed header":
(https://github.com/bitcoin-core/gui/pull/729#issuecomment-1551266534)
Observing the same issue -- https://cirrus-ci.com/task/6646912535756800

:(

💬 MarcoFalke commented on pull request "test: Add missed header":
(https://github.com/bitcoin-core/gui/pull/729#issuecomment-1551271233)
Anything holding back https://github.com/bitcoin/bitcoin/pull/27571 ?

💬 fanquake commented on pull request "test: Add missed header":
(https://github.com/bitcoin-core/gui/pull/729#issuecomment-1551273063)
No.

🚀 fanquake merged a pull request: "ci: Run iwyu on all src files"
(https://github.com/bitcoin/bitcoin/pull/27571)

🚀 fanquake merged a pull request: "guix: document when certain patches can be dropped"
(https://github.com/bitcoin/bitcoin/pull/27668)

💬 MarcoFalke commented on pull request "rpc: Add importmempool RPC":
(https://github.com/bitcoin/bitcoin/pull/27460#discussion_r1196407013)
Thanks, rebased and fixed up the nit

💬 kristapsk commented on pull request "rpc: Add importmempool RPC":
(https://github.com/bitcoin/bitcoin/pull/27460#issuecomment-1551280433)
Concept ACK

📝 fanquake opened a pull request: "[25.x] Changes for rc3 || finalize"
(https://github.com/bitcoin/bitcoin/pull/27686)
Any candidates left for backport into `rc3`?

If yes, we can backport and cut a new rc, if not, we are likely at the point of 25.0 final.

🤔 fanquake reviewed a pull request: "doc: Rework build-unix.md"
(https://github.com/bitcoin/bitcoin/pull/27685#pullrequestreview-1430541727)
Concept ACK - build-unix probably a good candidate for being split up further at some point.

💬 fanquake commented on pull request "doc: Rework build-unix.md":
(https://github.com/bitcoin/bitcoin/pull/27685#discussion_r1196422056)
While here, I think you could also remove the `Notes`, as well as the `miniupnpc` and `libnatpmp` sections below. I don't think `Notes` really adds any value, and the `miniupnpc` and `libnatpmp` seem irrelevant here (we also don't have a similar section for all other dependencies (nor do I think we should add one), and listing configure defaults in markdown is mostly pointless, and just duplicates the (always up to date) output of `./configure --help`).

We could also remove the `Security` se
...

💬 MarcoFalke commented on pull request "doc: Rework build-unix.md":
(https://github.com/bitcoin/bitcoin/pull/27685#discussion_r1196444669)
Thx, done

📝 hebasto opened a pull request: "msvc: Provide `ObjectFileName` explicitly"
(https://github.com/bitcoin/bitcoin/pull/27687)
This PR is a follow-up to https://github.com/bitcoin/bitcoin/pull/26715

Should fix intermittent MSVC link [errors](https://cirrus-ci.com/task/6646912535756800).

💬 ddykeman1 commented on issue "Mac osx 12.6.5 ":
(https://github.com/bitcoin/bitcoin/issues/27681#issuecomment-1551327128)
> FWIW, Bitcoin Core v22.0 has reached its EOL (see https://bitcoincore.org/en/lifecycle/).
>
> Suggesting to [download](https://bitcoincore.org/en/download/) a newer supported version.
Thank u I only got the download from the main site

💬 sipa commented on pull request "Avoid lock order inversion in `Chainstate::ConnectTip` function":
(https://github.com/bitcoin/bitcoin/pull/27684#discussion_r1196466088)
I'm surprised this works. The `state` variable may not exist anymore by the time `MaybePunishNodeForBlock` gets called.

💬 MarcoFalke commented on issue "Mac osx 12.6.5 ":
(https://github.com/bitcoin/bitcoin/issues/27681#issuecomment-1551335899)
Ok, let us know if this is still an issue on a more recent version.

On Wed, May 17, 2023 at 2:45 PM ddykeman1 ***@***.***> wrote:

> Thank u I only got the download from the main site
>
> Message ID: ***@***.***>
>

💬 MarcoFalke commented on pull request "build: Bump minimum supported Clang to clang-10":
(https://github.com/bitcoin/bitcoin/pull/27682#issuecomment-1551342007)
For completeness, building with clang-9 is likely still possible, it is just not supported and checked by the CI.

💬 svanstaa commented on pull request "mempool / rpc: add getprioritisedtransactions, delete a mapDeltas entry when delta==0":
(https://github.com/bitcoin/bitcoin/pull/27501#issuecomment-1551353374)
Concept ACK

💬 MarcoFalke commented on issue "Drop support for g++-8?":
(https://github.com/bitcoin/bitcoin/issues/27537#issuecomment-1551363732)
(The gcc bug was just fixed in 13.2)

💬 TheCharlatan commented on pull request "kernel: Remove interface_ui, util/system from kernel library":
(https://github.com/bitcoin/bitcoin/pull/27636#issuecomment-1551363803)
Rebased b29eab3fc68de28fe2aa67700fd99c6744e37f61 -> 0b88c307a8ed81705cf8e6fb6332fdf969eb0e2e ([chainstateRmKernelUiInterface_5](https://github.com/TheCharlatan/bitcoin/commits/chainstateRmKernelUiInterface_5) -> [chainstateRmKernelUiInterface_6](https://github.com/TheCharlatan/bitcoin/commits/chainstateRmKernelUiInterface_6), [compare](https://github.com/TheCharlatan/bitcoin/compare/chainstateRmKernelUiInterface_5..chainstateRmKernelUiInterface_6)).
* Fixed conflict with https://github.com/bitc
...

💬 furszy commented on pull request "Implement Mini version of BlockAssembler to calculate mining scores":
(https://github.com/bitcoin/bitcoin/pull/27021#issuecomment-1551366404)
> > ACK [6b605b9](https://github.com/bitcoin/bitcoin/commit/6b605b91c1faf2c7f7cc0c9d39b4fcfd66dc2965) modulo `miniminer_overlap` test.
> > Not really blocking, I'm planning to go deeper later. And probably add some explanatory comments and code simplifications. I think that has a readability barrier that will be a maintenance issue moving forward.
>
> Perhaps we can address that in #26152 as well

Absolutely. Loved @theStack diagram.