💬 kevkevinpal commented on pull request "test: added fuzz coverage for consensus/merkle.cpp":
(https://github.com/bitcoin/bitcoin/pull/32243#discussion_r2078329613)
that works with me! updated in [0fe4e7d](https://github.com/bitcoin/bitcoin/pull/32243/commits/0fe4e7d1863afb32608bb0e8ffacffd7e3866f30)

💬 achow101 commented on pull request "wallet: Ensure best block matches wallet scan state":
(https://github.com/bitcoin/bitcoin/pull/30221#discussion_r2078353954)
Done and squashed the commits.

💬 achow101 commented on pull request "wallet: Ensure best block matches wallet scan state":
(https://github.com/bitcoin/bitcoin/pull/30221#discussion_r2078354485)
Moved to the destructor.

💬 achow101 commented on pull request "wallet: Ensure best block matches wallet scan state":
(https://github.com/bitcoin/bitcoin/pull/30221#discussion_r2078354648)
Squashed.

💬 achow101 commented on pull request "wallet: Ensure best block matches wallet scan state":
(https://github.com/bitcoin/bitcoin/pull/30221#discussion_r2078354747)
Done

🤔 caesrcd reviewed a pull request: "config: allow setting -proxy per network"
(https://github.com/bitcoin/bitcoin/pull/32425#pullrequestreview-2823048212)
ACK 4af5b4d4298b4c69cd9131e87fe50e9386def13a

I have tested the code.

💬 stringintech commented on pull request "kernel: Separate UTXO set access from validation functions":
(https://github.com/bitcoin/bitcoin/pull/32317#discussion_r2078426205)
Small nit: I was thinking maybe we could make the template parameter more specific like:

```cpp
template <typename T>
unsigned int GetP2SHSigOpCount(const CTransaction& tx, const std::span<T> coins)
```

This might better align with the "Sorted span" mentioned in the docs, where T would then be either `const Coin` or `std::reference_wrapper<const Coin>`. It might also make the implementation slightly more readable when calling iterator methods like `begin()` and `end()` on the `coins` pa
...

💬 laanwj commented on pull request "Fix broken Kyoto Cabinet link in leveldb benchmark doc":
(https://github.com/bitcoin/bitcoin/pull/32441#issuecomment-2860255728)
You should file this upstream https://github.com/google/leveldb

🤔 mzumsande reviewed a pull request: "(RFC) kernel: Replace leveldb-based BlockTreeDB with flat-file based store"
(https://github.com/bitcoin/bitcoin/pull/32427#pullrequestreview-2823207472)
A full `-reindex` can be necessary for two reasons:
1. corruption in the block tree db
2. corruption in the blk files.

In my personal experience of running a node on crappy hardware a long time ago, it was usually 2. that would happen (I knew that because the reindex wouldn't scan all block files but abort with an error somewhere, and switch to IBD from peers). My suspicion is that while 1. may be the dominant reason in the early years, 2. may be just as important today.

However, if that
...

📝 davidgumberg opened a pull request: "doc: Add troubleshooting note about Guix on SELinux systems"
(https://github.com/bitcoin/bitcoin/pull/32442)
This adds documentation instructions taken from the guix manual (https://guix.gnu.org/manual/devel/en/guix.html#Installing-the-SELinux-policy) for fixing SELinux policy issues.

💬 EthanHeilman commented on pull request "CAT in Tapscript (BIP-347)":
(https://github.com/bitcoin/bitcoin/pull/29247#issuecomment-2860437712)
@AlexSQY That's an interesting question, we are you concerned about here?

Current Bitcoin behavior is `OP_CAT = False` and `DISCOURAGE_OP_CAT = False`. I don't believe we would ever want to set `DISCOURAGE_OP_CAT = False` while `OP_CAT = False` since a disabled opcode should be discouraged.

💬 achow101 commented on pull request "descriptors: MuSig2":
(https://github.com/bitcoin/bitcoin/pull/31244#discussion_r2078526779)
Done

💬 achow101 commented on pull request "descriptors: MuSig2":
(https://github.com/bitcoin/bitcoin/pull/31244#discussion_r2078526898)
Done

💬 achow101 commented on pull request "descriptors: MuSig2":
(https://github.com/bitcoin/bitcoin/pull/31244#discussion_r2078526958)
Done

💬 achow101 commented on pull request "descriptors: MuSig2":
(https://github.com/bitcoin/bitcoin/pull/31244#discussion_r2078526998)
Done

💬 achow101 commented on pull request "descriptors: MuSig2":
(https://github.com/bitcoin/bitcoin/pull/31244#issuecomment-2860444988)
> Seems like the commit message for [2e6dcdb](https://github.com/bitcoin/bitcoin/commit/2e6dcdbc8055660a2e20ba81b62b7d26ae0ccb05) ("Add MuSig2 Keyagg Cache class and functions") is out-of-sync, as there is no such class added and also the mentioned `MuSig2KeyAggCacheImpl` doesn't exist.

Updated the commit message.

💬 achow101 commented on pull request "docs: Improve `keypoolrefill` RPC docs":
(https://github.com/bitcoin/bitcoin/pull/32429#issuecomment-2860463811)
ACK ff35a4b021e12ae33e28c01ffeeb2c1916f7a487

💬 purpleKarrot commented on issue "Depends toolchain doesn't contain enough info to build from depends on a fresh NixOS install":
(https://github.com/bitcoin/bitcoin/issues/32428#issuecomment-2860465704)
> Building our own depends implies that we fully rely on them, ideally skipping all other search paths used by CMake's package, library, and header search mechanisms. Therefore, I believe we should retain as many restrictions as possible.

We may do that with a [dependency provider](https://cmake.org/cmake/help/latest/command/cmake_language.html#set-dependency-provider). This will put `find_package()` completely under our control, so restricting CMake's builtin find logic becomes unnecessary.

💬 achow101 commented on pull request "test: add test for decoding PSBT with MuSig2 PSBT key types (BIP 373)":
(https://github.com/bitcoin/bitcoin/pull/32305#issuecomment-2860468523)
ACK 4b241867567203b204823a4558c2aa5767acf028

✅ achow101 closed an issue: "`keypoolrefill` doesn't fill keypool to specified parameter"
(https://github.com/bitcoin/bitcoin/issues/29924)