💬 kevkevinpal commented on pull request "test: added fuzz coverage for consensus/merkle.cpp":
(https://github.com/bitcoin/bitcoin/pull/32243#discussion_r2078240706)
changed back to just `num_txs` in [7c80dcd](https://github.com/bitcoin/bitcoin/pull/32243/commits/7c80dcd81a844837b5823eb33501e9511cbe3d05)

💬 w0xlt commented on pull request "test: Add and use ElapseTime helper":
(https://github.com/bitcoin/bitcoin/pull/32430#discussion_r2078246201)
Where is this being used ?

👍 theStack approved a pull request: "test: remove bdb assert in tool_wallet.py"
(https://github.com/bitcoin/bitcoin/pull/32440#pullrequestreview-2822805869)
re-ACK e08e6567f2e7e3e3acaa038e3302f069b9a3c54c

💬 TheCharlatan commented on pull request "kernel: Introduce initial C header API":
(https://github.com/bitcoin/bitcoin/pull/30595#issuecomment-2859819482)
Rebased 65fe5d03e7a2d0d00d7d37bd426fd6532fff3c06 -> 65fe5d03e7a2d0d00d7d37bd426fd6532fff3c06 ([kernelApi](https://github.com/TheCharlatan/bitcoin/tree/kernelApi) -> [kernelApi](https://github.com/TheCharlatan/bitcoin/tree/kernelApi), [compare](https://github.com/TheCharlatan/bitcoin/compare/kernelApi..kernelApi))

* Fixed conflict with #28710

💬 l0rinc commented on pull request "test: Add and use ElapseTime helper":
(https://github.com/bitcoin/bitcoin/pull/32430#discussion_r2078260505)
If you remove it and try to compile, you'll notice that Boost requires these for the test to be able to print out the the values when there's a mismatch, see: https://github.com/bitcoin/bitcoin/blob/fae29c5dd71b263fb3bda8d554c9e6a4908175db/src/test/testnet4_miner_tests.cpp#L49

💬 achow101 commented on pull request "test: remove bdb assert in tool_wallet.py":
(https://github.com/bitcoin/bitcoin/pull/32440#issuecomment-2859825354)
ACK 4b6dd9790b667455ad7de58c67b3f7c9bc50657c

🤔 w0xlt reviewed a pull request: "psbt: clarify PSBT, PSBTInput, PSBTOutput unserialization flows"
(https://github.com/bitcoin/bitcoin/pull/32419#pullrequestreview-2822832499)
Concept ACK

Agreed https://github.com/bitcoin/bitcoin/pull/32419#issuecomment-2855291909

💬 l0rinc commented on pull request "[IBD] flush UTXO set in batches proportional to `dbcache` size":
(https://github.com/bitcoin/bitcoin/pull/31645#issuecomment-2859840062)
Now that https://github.com/bitcoin/bitcoin/pull/30611 is merged, I'm drafting this PR until https://github.com/bitcoin/bitcoin/pull/32414 is also merged, since they eliminate the max memory usecase I've been optimizing for - and I have to remeasure the usecases to see if this is still the optimum.

📝 l0rinc converted_to_draft a pull request: "[IBD] flush UTXO set in batches proportional to `dbcache` size"
(https://github.com/bitcoin/bitcoin/pull/31645)
This change is part of [[IBD] - Tracking PR for speeding up Initial Block Download](https://github.com/bitcoin/bitcoin/pull/32043)

### Summary

When the in-memory UTXO set is [flushed](https://github.com/bitcoin/bitcoin/blob/master/src/txdb.cpp#L130-L133) to LevelDB (after IBD or AssumeUTXO load), it does so in batches to manage memory usage during the flush.
While a hidden [`-dbbatchsize`](https://github.com/bitcoin/bitcoin/blob/master/src/init.cpp#L490) config option exists to modify thi
...

🤔 w0xlt reviewed a pull request: "test: Add and use ElapseTime helper"
(https://github.com/bitcoin/bitcoin/pull/32430#pullrequestreview-2822849432)
ACK https://github.com/bitcoin/bitcoin/pull/32430/commits/fae29c5dd71b263fb3bda8d554c9e6a4908175db

💬 TheCharlatan commented on pull request "(RFC) kernel: Replace leveldb-based BlockTreeDB with flat-file based store":
(https://github.com/bitcoin/bitcoin/pull/32427#issuecomment-2859864794)
Re https://github.com/bitcoin/bitcoin/pull/32427#issuecomment-2858637715

> Do you mean compared to the alternative of having a single file for all blocks? I would imagine that would create I/O problems, since the operating system wouldn't know which part of the big file changed. And it can't defragment it.

Yes, that is what I meant. We never change block files, so that is not a problem. I'm also not sure how real this problem actually is. A bunch of databases just maintain one big file and
...

💬 achow101 commented on pull request "refactor: Removals after bdb removal":
(https://github.com/bitcoin/bitcoin/pull/32438#discussion_r2078288424)
In fadaa8baafc27fbe29721300569e58777643bb1f "test: remove unused extra_args"

These args are used as the 28.0 node used in this test needs them to make the legacy wallets for testing.

🚀 achow101 merged a pull request: "test: remove bdb assert in tool_wallet.py"
(https://github.com/bitcoin/bitcoin/pull/32440)

📝 MozirDmitriy opened a pull request: "Fix broken Kyoto Cabinet link in leveldb benchmark doc"
(https://github.com/bitcoin/bitcoin/pull/32441)
Update the broken link to Kyoto Cabinet specifications from http://fallabs.com/kyotocabinet/spex.html to https://dbmx.net/kyotocabinet/spex.html in the leveldb benchmark documentation. The original domain is no longer available, but the documentation is now hosted at dbmx.net.

✅ fanquake closed a pull request: "Fix broken Kyoto Cabinet link in leveldb benchmark doc"
(https://github.com/bitcoin/bitcoin/pull/32441)

💬 achow101 commented on pull request "wallet: `addhdkey` RPC to add just keys to wallets via new `unused(KEY)` descriptor":
(https://github.com/bitcoin/bitcoin/pull/29136#issuecomment-2859906234)
> Quick comment - the PR title and description would now need to be updated to use `unused` instead of `void`

Done

> Also, some documentation in [descriptors.md file](https://github.com/bitcoin/bitcoin/blob/master/doc/descriptors.md) would be nice.

I don't think that `unused()` is really a descriptor that we people should be importing by themselves. I'm not planning on standardizing it with a BIP as I think it's more of an internal implementation detail rather than something that actual
...

💬 achow101 commented on pull request "wallet: Keep track of the wallet's own transaction outputs in memory":
(https://github.com/bitcoin/bitcoin/pull/27286#discussion_r2078307648)
Fixed

💬 TheCharlatan commented on pull request "(RFC) kernel: Replace leveldb-based BlockTreeDB with flat-file based store":
(https://github.com/bitcoin/bitcoin/pull/32427#issuecomment-2859921949)
Re https://github.com/bitcoin/bitcoin/pull/32427#issuecomment-2858716091

> How worried are we about file corruption here?

I was hoping to provoke a discussion about this as I alluded to in the PR description - thanks for providing your thoughts on this. I think the proof of work and integrity checks done on loading the index already provide fairly solid guarantees on load, but agree that we should do better. I have also talked to some other people about it offline, and there seems to be s
...

💬 achow101 commented on pull request "psbt: add non-default sighash types to PSBTs and unify sighash type match checking":
(https://github.com/bitcoin/bitcoin/pull/31622#discussion_r2078319009)
Done

💬 achow101 commented on pull request "psbt: add non-default sighash types to PSBTs and unify sighash type match checking":
(https://github.com/bitcoin/bitcoin/pull/31622#discussion_r2078319098)
Done