💬 willcl-ark commented on issue "Depends toolchain doesn't contain enough info to build from depends on a fresh NixOS install":
(https://github.com/bitcoin/bitcoin/issues/32428#issuecomment-2855759003)
> Also just to be sure another difference isn't glossed over: I think it probably is better to set CMAKE_SYSTEM_PREFIX_PATH instead of CMAKE_PREFIX_PATH since former seems to fix the original problem, while latter is more of a workaround.

That sounds reasonable.

> Also really appreciate you reporting this issue and finding a good workaround. This has been causing me headaches for a long time, and I've only had crappy workarounds and couldn't figure out how this was working at all on other syst
...

💬 maflcko commented on issue "Intermittent timeout in tsan feature_init.py":
(https://github.com/bitcoin/bitcoin/issues/30586#issuecomment-2855818587)
A workaround seems to be:

```diff
diff --git a/test/functional/feature_init.py b/test/functional/feature_init.py
index 15b3e85..1fef8e1 100755
--- a/test/functional/feature_init.py
+++ b/test/functional/feature_init.py
@@ -44,7 +44,7 @@ class InitTest(BitcoinTestFramework):
# bitcoind to perform any shutdown logic.
os.kill(node.process.pid, signal.CTRL_BREAK_EVENT)
else:
- node.process.terminate()
+ node.process.kill()
...

💬 ybaidiuk commented on pull request "Remove arbitrary limits on OP_Return (datacarrier) outputs":
(https://github.com/bitcoin/bitcoin/pull/32359#issuecomment-2855844462)
Why in 5 years btc tx should concur for space inside block with another data? blockchain is about bitcoin not other data, if you people want to store data it should be expensive and hard, or use side chains like liquid etc.

My 7 years old node go down today, and i'm switching to knots.

💬 janb84 commented on pull request "docs: clarify RPC credentials security boundary":
(https://github.com/bitcoin/bitcoin/pull/32424#issuecomment-2855887125)
Please [squash](https://github.com/bitcoin/bitcoin/blob/master/CONTRIBUTING.md#squashing-commits) your commits

💬 maflcko commented on pull request "docs: Improve `keypoolrefill` RPC docs":
(https://github.com/bitcoin/bitcoin/pull/32429#discussion_r2076251627)
Should probably use `DEFAULT_KEYPOOL_SIZE` instead of hardcoded 1000? Same for the `OUTPUT_TYPES`? Also, `ScriptPubKeyManagers` was never used in user-facing docs, except for one error message. Maybe just use "active ranged descriptor" (or similar)?

💬 maflcko commented on pull request "docs: Improve `keypoolrefill` RPC docs":
(https://github.com/bitcoin/bitcoin/pull/32429#discussion_r2076282332)
also, now that bdb was removed, no need to add docs for it?

📝 hebasto opened a pull request: "qt, docs: Unify term "clipboard""
(https://github.com/bitcoin-core/gui/pull/871)
A translator on Transifex noticed:
> The term "system clipboard" appears twice. The term "clipboard" appears 10 times. Perhaps we could standardize on just saying "clipboard"?

This PR addresses this issue.

💬 hebasto commented on pull request "qt, docs: Unify term "clipboard"":
(https://github.com/bitcoin-core/gui/pull/871#issuecomment-2855996352)
> A translator on Transifex noticed:
>
> > The term "system clipboard" appears twice. The term "clipboard" appears 10 times. Perhaps we could standardize on just saying "clipboard"?

Reported by @jesterhodl.

💬 crStiv commented on pull request "docs: clarify RPC credentials security boundary":
(https://github.com/bitcoin/bitcoin/pull/32424#issuecomment-2856003596)
> Please [squash](https://github.com/bitcoin/bitcoin/blob/master/CONTRIBUTING.md#squashing-commits) your commits

@janb84 yeah sure, np

💬 hebasto commented on issue "Depends toolchain doesn't contain enough info to build from depends on a fresh NixOS install":
(https://github.com/bitcoin/bitcoin/issues/32428#issuecomment-2856025715)
> > I added the `if()` guard because I heard from [@hebasto](https://github.com/hebasto) that we call the toolchain multiple times, and the `if` guard therefore avoids adding the path repeatedly.
>
> I think this is half-true. I noticed by adding prints to the cmake file that it was called multiple times, but each time CMAKE_PREFIX_PATH was always set back to the original value, so I don't think the `if` guard did anything.

I'd avoid making assumptions about undocumented `CMAKE_PREFIX_PATH`-re
...

💬 furszy commented on pull request "Remove arbitrary limits on OP_Return (datacarrier) outputs":
(https://github.com/bitcoin/bitcoin/pull/32359#issuecomment-2856093736)
> Why in 5 years btc tx should concur for space inside block with another data? blockchain is about bitcoin not other data, if you people want to store data it should be expensive and hard, or use side chains like liquid etc.

I'm somewhat puzzled by your comment. Storing data on the blockchain in its current form is not particularly difficult—that’s precisely what this discussion is about. It can be done in various ways, some more harmful than others.

As you noted, if the goal is to make d
...

💬 hebasto commented on pull request "depends: Switch from multilib to platform-specific toolchains":
(https://github.com/bitcoin/bitcoin/pull/32162#issuecomment-2856105202)
Rebased due to a conflict with the merged bitcoin/bitcoin#32086.

💬 maflcko commented on pull request "depends: Switch from multilib to platform-specific toolchains":
(https://github.com/bitcoin/bitcoin/pull/32162#discussion_r2076388963)
```suggestion
Please note that package availability might depend on your arch+OS you are building on.
```

💬 achow101 commented on pull request "Refactor BnB tests":
(https://github.com/bitcoin/bitcoin/pull/29532#discussion_r2076408536)
I believe the plan is to rewrite all of the tests into this style over the course of a couple PRs. So this parameter is here to allow for the future testing of SFFO behavior.

> Also, you are expecting group.GetSelectionAmount() to be equal to tx.vout[0].nValue with this parameter right?

Only when it is false. The purpose is to have `group.GetSelectionAmount()` be eqaul to `amount`, so `nValue` is increased by the amount in fees so that they match after fees are deducted.

💬 hebasto commented on pull request "depends: Switch from multilib to platform-specific toolchains":
(https://github.com/bitcoin/bitcoin/pull/32162#discussion_r2076413998)
Thanks! Fixed.

💬 Craig-k-p commented on pull request "Remove arbitrary limits on OP_Return (datacarrier) outputs":
(https://github.com/bitcoin/bitcoin/pull/32359#issuecomment-2856227822)
RIP core.

💬 w0xlt commented on pull request "Remove the legacy wallet and BDB dependency":
(https://github.com/bitcoin/bitcoin/pull/28710#discussion_r2076416803)
```suggestion
assert(wallet_instance->IsWalletFlagSet(WALLET_FLAG_DESCRIPTORS));
```

💬 achow101 commented on pull request "scripted-diff: adapt script error constant names in feature_taproot.py":
(https://github.com/bitcoin/bitcoin/pull/32415#issuecomment-2856231027)
ACK b5f580c580257d28d295cae3f787b55eb1863f16

🚀 achow101 merged a pull request: "Refactor BnB tests"
(https://github.com/bitcoin/bitcoin/pull/29532)

💬 w0xlt commented on pull request "Remove the legacy wallet and BDB dependency":
(https://github.com/bitcoin/bitcoin/pull/28710#discussion_r2076425739)
I agree.