💬 hebasto commented on pull request "refactor: Add util::Result failure values, multiple error and warning messages":
(https://github.com/bitcoin/bitcoin/pull/25665#issuecomment-1427060487)
It seems the 7cdb7d1e9573ae60e7335af5d3de99191ad68b3f commit adds `src/wallet/test/availablecoins_tests.cpp` by accident, doesn't it?

💬 furszy commented on pull request "test: fix immediate tx relay in wallet_groups.py":
(https://github.com/bitcoin/bitcoin/pull/26970#issuecomment-1427061801)
Seems that what I wrote [above](https://github.com/bitcoin/bitcoin/pull/26970#issuecomment-1404981802) was suggested years ago #9923. Might be a good opportunity to revive the topic.

💬 brunoerg commented on pull request "test: fix immediate tx relay in wallet_groups.py":
(https://github.com/bitcoin/bitcoin/pull/26970#issuecomment-1427064053)
> Seems that what I wrote [above](https://github.com/bitcoin/bitcoin/pull/26970#issuecomment-1404981802) was suggested years ago #9923. Might be a good opportunity to revive the topic.

See #26441

💬 Ayms commented on issue "Allow several OP_RETURN in one tx and no limited size":
(https://github.com/bitcoin/bitcoin/issues/27043#issuecomment-1427069403)
What is the process to have someone do the PR for this? Or I do it and most likely it will be a very shxtty one since I am not a C/C++ expert, then wasting the time of everybody

It's urgently required, I did consider OP_RETURN as a dart in the past but changed my mind, it's adapted to the current evolutions, not flooding bitcoin with 2 txs while only 1 is needed

If not the best 1 tx solution is super simple: store in addresses, and super bad at the end because burning bitcoins, while still
...

📝 hebasto opened a pull request: "refactor: Rename variable to avoid shadowing"
(https://github.com/bitcoin/bitcoin/pull/27087)
This PR is a follow up of https://github.com/bitcoin/bitcoin/pull/26661 that introduced a local variable shadowing which I've noticed while reviewing https://github.com/bitcoin/bitcoin/pull/25665.

💬 hebasto commented on pull request "wallet: Coin Selection, return accurate error messages":
(https://github.com/bitcoin/bitcoin/pull/26661#discussion_r1103836760)
The local variable `res` in here shadows another one: https://github.com/bitcoin/bitcoin/blob/76dc547ee7b05864e7b1b6c55fc0301d47aa3a15/src/wallet/spend.cpp#L658

Fixed in #27087.

💬 hebasto commented on pull request "refactor: Rename variable to avoid shadowing":
(https://github.com/bitcoin/bitcoin/pull/27087#issuecomment-1427080909)
cc @furszy

👍 53jk1 approved a pull request: "refactor: Rename variable to avoid shadowing"
(https://github.com/bitcoin/bitcoin/pull/27087)

💬 MarcoFalke commented on issue "Allow several OP_RETURN in one tx and no limited size":
(https://github.com/bitcoin/bitcoin/issues/27043#issuecomment-1427112143)
See https://github.com/bitcoin/bitcoin/blob/master/CONTRIBUTING.md

⚠️ instagibbs opened an issue: "24.0.1 crash on restart"
(https://github.com/bitcoin/bitcoin/issues/27088)
I've seen this a couple of times in CLN's CI, and thought it was probably worth reporting:

```
2023-02-12T13:39:59.7526313Z ************************
2023-02-12T13:39:59.7526645Z EXCEPTION: NSt10filesystem7__cxx1116filesystem_errorE
2023-02-12T13:39:59.7527060Z filesystem error: cannot get current path: No such file or directory
2023-02-12T13:39:59.7527421Z bitcoin in AppInitRPC()
```
This is on a restart of bitcoind between test runs, seen here: https://pipelines.act
...

📝 martcpp opened a pull request: "correct and error on the read"
(https://github.com/bitcoin/bitcoin/pull/27089)
<!--
*** Please remove the following help text before submitting: ***

Pull requests without a rationale and clear improvement may be closed
immediately.

GUI-related pull requests should be opened against
https://github.com/bitcoin-core/gui
first. See CONTRIBUTING.md
-->

<!--
Please provide clear motivation for your patch and explain how it improves
Bitcoin Core user experience or Bitcoin Core developer experience
significantly:

* Any test improvements or new tests that improv
...

💬 martcpp commented on pull request "correct and error on the read":
(https://github.com/bitcoin/bitcoin/pull/27089#issuecomment-1427124024)
corrected an error on the readme

✅ fanquake closed a pull request: "correct and error on the read"
(https://github.com/bitcoin/bitcoin/pull/27089)

💬 TysonsTech commented on issue "Wallet passphrases silently ignore everything after a null character":
(https://github.com/bitcoin/bitcoin/issues/27067#issuecomment-1427355467)
From what I understand the issue occurs because the string is terminated by a null character and anything after the null character is ignored. This means that if the passphrase is used to secure the wallet and includes a null character, the software may be processing only a portion of the intended passphrase, potentially leading to the wallet being unlocked using an incorrect or malicious passphrase.
I agree using a SecureString can help mitigate the issue of passphrases silently ignoring ever
...

💬 TysonsTech commented on issue "Request support for HRNG on ARM using their new RNDR / RNDRRS instructions.":
(https://github.com/bitcoin/bitcoin/issues/26796#issuecomment-1427377914)
Hope this helps and is a correct example of using the RNDR and RNDRRS instructions in ARM assembly language for bitcoin mining:

mov x0, #0
mrs x1, cntpct_el0
mov x2, #32
rndr x3, x0, x1, x2

; Use the generated random number as a nonce in a hash function
mov x4, x3
bl hash_function

; Compare the resulting hash with the target difficulty
mov x5, TARGET_DIFFICULTY
cmp x4, x5
bgt retry

; If the hash is less than the target, it is a valid soluti
...

💬 S3RK commented on pull request "Wallet: Zero out wallet master key upon locking so it doesn't persist in memory":
(https://github.com/bitcoin/bitcoin/pull/27080#issuecomment-1427481658)
Code review ACK 3a11adc7004d21b3dfe028b190d83add31691c55

💬 johnnypham commented on issue "make check FAIL: qt/test/test_bitcoin-qt.exe WSL":
(https://github.com/bitcoin/bitcoin/issues/22248#issuecomment-1427482030)
Disabling the gui tests works for me in WSL. Thanks!

💬 MarcoFalke commented on issue "24.0.1 crash on restart":
(https://github.com/bitcoin/bitcoin/issues/27088#issuecomment-1427509199)
Maybe upload the full log here?

💬 naumenkogs commented on pull request "[WIP] p2p: Add random txn's from mempool to GETBLOCKTXN":
(https://github.com/bitcoin/bitcoin/pull/27086#issuecomment-1427568262)
I agree with @sipa, with a stronger emphasis that I would probably NACK this change because the cost of this fix is too high, and the privacy gain is too low.

You may be interested in contributing to some SPV client implementation instead :) I'm curious how well they preserve privacy when they request transactions/blocks (that subset which is of interest to them specifically). E.g. whether they ask the same node to provide everything — then the node can correlate.

💬 hebasto commented on pull request "refactor, wallet: Avoid variable shadowing":
(https://github.com/bitcoin/bitcoin/pull/27087#issuecomment-1427632143)
> Could remove the top variable instead of renaming the internal one: [furszy@3fb01a9](https://github.com/furszy/bitcoin-core/commit/3fb01a94aa29dec9c546c0d0e9e54a513b3dee43).

Thanks! Done.