β
Sjors closed an issue: "depends: llvm-ranlib (etc): "No such file or directory" on Intel macOS 15.0"
(https://github.com/bitcoin/bitcoin/issues/30978)
(https://github.com/bitcoin/bitcoin/issues/30978)
π¬ Sjors commented on issue "Having qt(@6) breaks build for qt@5 on macOS 15.0 and 13.7":
(https://github.com/bitcoin/bitcoin/issues/31009#issuecomment-2854374755)
No longer an issue since #30997.
(https://github.com/bitcoin/bitcoin/issues/31009#issuecomment-2854374755)
No longer an issue since #30997.
β
Sjors closed an issue: "Having qt(@6) breaks build for qt@5 on macOS 15.0 and 13.7"
(https://github.com/bitcoin/bitcoin/issues/31009)
(https://github.com/bitcoin/bitcoin/issues/31009)
β οΈ fanquake reopened an issue: "Having qt(@6) breaks build for qt@5 on macOS 15.0 and 13.7"
(https://github.com/bitcoin/bitcoin/issues/31009)
### Is there an existing issue for this?
- [X] I have searched the existing issues
### Current behaviour
Building bitcoin-qt produces a flood of errors:
```
In file included from /Users/sjors/dev/bitcoin/src/qt/csvmodelwriter.cpp:5:
In file included from /Users/sjors/dev/bitcoin/src/qt/csvmodelwriter.h:8:
In file included from /usr/local/opt/qt@5/lib/QtCore.framework/Headers/QList:1:
In file included from /usr/local/opt/qt@5/lib/QtCore.framework/Headers/qlist.h:48:
/usr/local/include/
...
(https://github.com/bitcoin/bitcoin/issues/31009)
### Is there an existing issue for this?
- [X] I have searched the existing issues
### Current behaviour
Building bitcoin-qt produces a flood of errors:
```
In file included from /Users/sjors/dev/bitcoin/src/qt/csvmodelwriter.cpp:5:
In file included from /Users/sjors/dev/bitcoin/src/qt/csvmodelwriter.h:8:
In file included from /usr/local/opt/qt@5/lib/QtCore.framework/Headers/QList:1:
In file included from /usr/local/opt/qt@5/lib/QtCore.framework/Headers/qlist.h:48:
/usr/local/include/
...
π¬ fanquake commented on issue "Having qt(@6) breaks build for qt@5 on macOS 15.0 and 13.7":
(https://github.com/bitcoin/bitcoin/issues/31009#issuecomment-2854377650)
It is still an issue, in the 29.x branch.
(https://github.com/bitcoin/bitcoin/issues/31009#issuecomment-2854377650)
It is still an issue, in the 29.x branch.
π¬ Sjors commented on issue "ARM Windows build and release":
(https://github.com/bitcoin/bitcoin/issues/31388#issuecomment-2854384464)
We're at qt6 since #30997 landed. But it still needs to be natively compiled. I don't know if cross-compilation is a priority for QT? If not, then there's probably no point in keeping this open until the end of time.
(https://github.com/bitcoin/bitcoin/issues/31388#issuecomment-2854384464)
We're at qt6 since #30997 landed. But it still needs to be natively compiled. I don't know if cross-compilation is a priority for QT? If not, then there's probably no point in keeping this open until the end of time.
π¬ polespinasa commented on pull request "policy: uncap datacarrier by default":
(https://github.com/bitcoin/bitcoin/pull/32406#discussion_r2075362265)
I just checked, when is auto-stopped at the end it stop all nodes by calling:
```python
self.log.info("Stopping nodes")
if self.nodes:
self.stop_nodes()
```
It uses `stop_nodes()` which doesn't give any `expected_stderr` value:
```python
def stop_node(self, i, expected_stderr='', wait=0):
"""Stop a bitcoind test node"""
self.nodes[i].stop_node(expected_stderr, wait=wait)
def stop_nodes(self, wait=0):
"""Stop multiple bitco
...
(https://github.com/bitcoin/bitcoin/pull/32406#discussion_r2075362265)
I just checked, when is auto-stopped at the end it stop all nodes by calling:
```python
self.log.info("Stopping nodes")
if self.nodes:
self.stop_nodes()
```
It uses `stop_nodes()` which doesn't give any `expected_stderr` value:
```python
def stop_node(self, i, expected_stderr='', wait=0):
"""Stop a bitcoind test node"""
self.nodes[i].stop_node(expected_stderr, wait=wait)
def stop_nodes(self, wait=0):
"""Stop multiple bitco
...
π¬ Sjors commented on issue "Having qt(@6) breaks build for qt@5 on macOS 15.0 and 13.7":
(https://github.com/bitcoin/bitcoin/issues/31009#issuecomment-2854390811)
@fanquake #32017 documents this in the build instructions. It's included in the v29 branch.
(https://github.com/bitcoin/bitcoin/issues/31009#issuecomment-2854390811)
@fanquake #32017 documents this in the build instructions. It's included in the v29 branch.
π¬ fanquake commented on issue "Having qt(@6) breaks build for qt@5 on macOS 15.0 and 13.7":
(https://github.com/bitcoin/bitcoin/issues/31009#issuecomment-2854392228)
That's fine. It's still a bug that should be fixed. Compiling our software should not be dependant on uninstalling other software.
(https://github.com/bitcoin/bitcoin/issues/31009#issuecomment-2854392228)
That's fine. It's still a bug that should be fixed. Compiling our software should not be dependant on uninstalling other software.
π¬ Sjors commented on issue "RFC: when to drop testnet3":
(https://github.com/bitcoin/bitcoin/issues/31975#issuecomment-2854397425)
So how long should we wait?
My mailinglist post didn't result in very passionate pleas for keeping it. And although some projects do still use it, they haven't demonstrated a serious intention to upgrade anytime soon.
Should we perhaps wait for testnet5 to see if that fixes the issues we see on testnet4? I suppose we have enough ports...
Or should I mark #31974 ready for review and just drop testnet3 in v30?
(https://github.com/bitcoin/bitcoin/issues/31975#issuecomment-2854397425)
So how long should we wait?
My mailinglist post didn't result in very passionate pleas for keeping it. And although some projects do still use it, they haven't demonstrated a serious intention to upgrade anytime soon.
Should we perhaps wait for testnet5 to see if that fixes the issues we see on testnet4? I suppose we have enough ports...
Or should I mark #31974 ready for review and just drop testnet3 in v30?
π¬ laanwj commented on pull request "log: print reason when writing chainstate":
(https://github.com/bitcoin/bitcoin/pull/32404#issuecomment-2854429982)
Concept ACK
(https://github.com/bitcoin/bitcoin/pull/32404#issuecomment-2854429982)
Concept ACK
π¬ maflcko commented on issue "Having qt(@6) breaks build for qt@5 on macOS 15.0 and 13.7":
(https://github.com/bitcoin/bitcoin/issues/31009#issuecomment-2854432627)
Does it work with 28.x? Could add 29.x to the title?
(https://github.com/bitcoin/bitcoin/issues/31009#issuecomment-2854432627)
Does it work with 28.x? Could add 29.x to the title?
π¬ hebasto commented on pull request "cmake: Respect user-provided configuration-specific flags":
(https://github.com/bitcoin/bitcoin/pull/32356#discussion_r2075396465)
> Would it be possible to put `get_directory_property(precious_variables CACHE_VARIABLES)` here inside the function scope?
If you do that, it will collect additional cache variables set by subsequent commands such as `project()` and `enable_language()`. This list will include `CMAKE_CXX_FLAGS_RELEASE`, which breaks the patch.
(https://github.com/bitcoin/bitcoin/pull/32356#discussion_r2075396465)
> Would it be possible to put `get_directory_property(precious_variables CACHE_VARIABLES)` here inside the function scope?
If you do that, it will collect additional cache variables set by subsequent commands such as `project()` and `enable_language()`. This list will include `CMAKE_CXX_FLAGS_RELEASE`, which breaks the patch.
π¬ hebasto commented on pull request "cmake: Respect user-provided configuration-specific flags":
(https://github.com/bitcoin/bitcoin/pull/32356#discussion_r2075399096)
Thanks! Updated.
(https://github.com/bitcoin/bitcoin/pull/32356#discussion_r2075399096)
Thanks! Updated.
π¬ hebasto commented on pull request "cmake: Respect user-provided configuration-specific flags":
(https://github.com/bitcoin/bitcoin/pull/32356#issuecomment-2854447614)
The [feedback](https://github.com/bitcoin/bitcoin/pull/32356#discussion_r2074117354) from @purpleKarrot has been addressed.
(https://github.com/bitcoin/bitcoin/pull/32356#issuecomment-2854447614)
The [feedback](https://github.com/bitcoin/bitcoin/pull/32356#discussion_r2074117354) from @purpleKarrot has been addressed.
π¬ fanquake commented on issue "Having qt(@6) breaks build for qt@5 on macOS 15.0 and 13.7":
(https://github.com/bitcoin/bitcoin/issues/31009#issuecomment-2854449493)
> Does it work with 28.x?
Yea. This is a CMake regression.
(https://github.com/bitcoin/bitcoin/issues/31009#issuecomment-2854449493)
> Does it work with 28.x?
Yea. This is a CMake regression.
π¬ hebasto commented on pull request "cmake: Respect user-provided configuration-specific flags":
(https://github.com/bitcoin/bitcoin/pull/32356#discussion_r2075409377)
The `var_name` contains no spaces, so I'll leave it as is to avoid cluttering the code.
(https://github.com/bitcoin/bitcoin/pull/32356#discussion_r2075409377)
The `var_name` contains no spaces, so I'll leave it as is to avoid cluttering the code.
π¬ hebasto commented on pull request "cmake: Respect user-provided configuration-specific flags":
(https://github.com/bitcoin/bitcoin/pull/32356#discussion_r2075409656)
The `var_name` contains no spaces, so I'll leave it as is to avoid cluttering the code."
(https://github.com/bitcoin/bitcoin/pull/32356#discussion_r2075409656)
The `var_name` contains no spaces, so I'll leave it as is to avoid cluttering the code."
π¬ hebasto commented on issue "ARM Windows build and release":
(https://github.com/bitcoin/bitcoin/issues/31388#issuecomment-2854518383)
> I don't know if cross-compilation is a priority for QT?
As far as I know, the required toolchain isnβt even provided by major distributions.
(https://github.com/bitcoin/bitcoin/issues/31388#issuecomment-2854518383)
> I don't know if cross-compilation is a priority for QT?
As far as I know, the required toolchain isnβt even provided by major distributions.
π vasild opened a pull request: "config: allow setting -proxy per network"
(https://github.com/bitcoin/bitcoin/pull/32425)
`-proxy=addr:port` specifies the proxy for all networks (except I2P). Previously only the Tor proxy could have been specified separately via `-onion=addr:port`.
Make it possible to specify separately the proxy for IPv4, IPv6, Tor and CJDNS by e.g. `-proxy=addr:port=ipv6`. Or remove the proxy for a given network, e.g. `-proxy=0=cjdns`.
Resolves: https://github.com/bitcoin/bitcoin/issues/24450
(https://github.com/bitcoin/bitcoin/pull/32425)
`-proxy=addr:port` specifies the proxy for all networks (except I2P). Previously only the Tor proxy could have been specified separately via `-onion=addr:port`.
Make it possible to specify separately the proxy for IPv4, IPv6, Tor and CJDNS by e.g. `-proxy=addr:port=ipv6`. Or remove the proxy for a given network, e.g. `-proxy=0=cjdns`.
Resolves: https://github.com/bitcoin/bitcoin/issues/24450