📝 hebasto converted_to_draft a pull request: "test: Increase stack size for "Debug" builds with MSVC"
(https://github.com/bitcoin/bitcoin/pull/32349)
This PR accommodates the deep recursion in the `FindChallenges()` function used in `test/miniscript_tests.cpp`.

Fixes https://github.com/bitcoin/bitcoin/issues/32341#issuecomment-2829441596.

CI log: https://github.com/hebasto/bitcoin/actions/runs/14664806617/job/41156972137

💬 laanwj commented on pull request "common: Close non-std fds before exec in RunCommandJSON":
(https://github.com/bitcoin/bitcoin/pull/32343#issuecomment-2830610090)
> I would try something like this to check if /proc/self/fd is available:

Thanks! Tried that, looks like it is:
```
[09:58:29.841] === BEGIN mount info ===
...
+ ls -al /proc/self/fd
[09:58:29.860] total 0
[09:58:29.860] dr-x------ 2 root root 4 Apr 25 09:58 .
[09:58:29.860] dr-xr-xr-x 9 root root 0 Apr 25 09:58 ..
[09:58:29.860] lr-x------ 1 root root 64 Apr 25 09:58 0 -> /dev/null
[09:58:29.860] l-wx------ 1 root root 64 Apr 25 09:58 1 -> pipe:[887125611]
[09:58:29.860] l-wx--
...

💬 jesterhodl commented on issue "gui: translation spam?":
(https://github.com/bitcoin/bitcoin/issues/32295#issuecomment-2830632592)
Nice, I'll rerun @maflcko's rust program. I modified it to just check polish to get this going quicker.

💬 hebasto commented on pull request "[29.x] qt: 29.1 translations update":
(https://github.com/bitcoin/bitcoin/pull/32352#issuecomment-2830660102)
> > Closes #32295.
>
> However, the Polish (pl) translation still have a couple of issues:
>
> 1. String 160: Mismatch between 'S&how' and '%Wyświetl'
>
> 2. String 452: Mismatch between 'Transaction broadcast successfully! Transaction ID: %1' and 'transakcja'

Friendly ping @jesterhodl :)

💬 mzumsande commented on pull request "p2p: Advance pindexLastCommonBlock early after connecting blocks":
(https://github.com/bitcoin/bitcoin/pull/32180#discussion_r2060402198)
Then we would have returned earlier because there are no blocks from this peer that would help us with our IBD:
https://github.com/bitcoin/bitcoin/blob/80e6ad9e3023a57a4ef19b7d0edf9ac5be71a584/src/net_processing.cpp#L1384-L1387 (second condition)

💬 jesterhodl commented on pull request "[29.x] qt: 29.1 translations update":
(https://github.com/bitcoin/bitcoin/pull/32352#issuecomment-2830669886)
> Transaction broadcast successfully

Both fixed in Transifex.

👍 ismaelsadeeq approved a pull request: "test: Add missing check for empty stderr in util tester"
(https://github.com/bitcoin/bitcoin/pull/32327#pullrequestreview-2794431069)


Tested ACK fadf12a56c294696052c4cb6ee5284030ada7498

I verified that with this patch, we now raise an exception whenever a `./bitcoin-util` call returns an error message and the corresponding test case does not specify that call have a corresponding `error_txt`.

For example, by removing the `error_txt` from the `grind` util test:

```diff
diff --git a/test/util/data/bitcoin-util-test.json b/test/util/data/bitcoin-util-test.json
index 83b3c430d53..d840c8fa1fb 100644
--- a/test/uti
...

💬 hebasto commented on pull request "test: avoid stack overflow in `FindChallenges` via manual iteration":
(https://github.com/bitcoin/bitcoin/pull/32351#issuecomment-2830714647)
[Here](https://github.com/hebasto/bitcoin-core-nightly/actions/runs/14667837569/job/41166981753) is a "Windows, Debug" CI job for this branch in https://github.com/hebasto/bitcoin-core-nightly.

💬 hebasto commented on pull request "[29.x] qt: 29.1 translations update":
(https://github.com/bitcoin/bitcoin/pull/32352#issuecomment-2830725738)
> > Transaction broadcast successfully
>
> Both fixed in Transifex.

Thanks! Updated and undrafted.

👋 hebasto's pull request is ready for review: "[29.x] qt: 29.1 translations update"
(https://github.com/bitcoin/bitcoin/pull/32352)

💬 fanquake commented on pull request "build: Fix `macdeployqtplus` after switching to Qt 6":
(https://github.com/bitcoin/bitcoin/pull/32287#discussion_r2060467577)
In f7bd54d5f34361c0c06dc86fbd8e2497e7e4473c: Why are we adding support for 6, while retaining support for 5, if we now require 6?

💬 ismaelsadeeq commented on pull request "Fees: add Fee rate Forecaster Manager":
(https://github.com/bitcoin/bitcoin/pull/31664#discussion_r2060485327)
Even better, I modified `CachedMempoolForecast` to store the last known tip.
Now, the mempool forecaster will only return the cached fee rate if the last known tip matches the current tip.

This also prevents a case where a cache exists but a new block has just been mined and the mempool has been cleared—in such cases, a new block template should be generated instead of using the cache.

Thanks for your review @polespinasa

💬 Chand-ra commented on issue "Bug: Non-Ranged Descriptors with Range [0,0] Trigger Unexpected Wallet Errors in `AddWalletDescriptor`":
(https://github.com/bitcoin/bitcoin/issues/31728#issuecomment-2830788940)
> Opened PR [#32344](https://github.com/bitcoin/bitcoin/pull/32344) to close this. It's been a while since [@Chand-ra](https://github.com/Chand-ra) indicated interest

Yeah, feel free to tackle it, I just couldn't get around to doing it.

💬 achow101 commented on pull request "wallet: Disable creating and loading legacy wallets":
(https://github.com/bitcoin/bitcoin/pull/31250#discussion_r2060500193)
The `importprivkey` overload was kept because several tests still use it.

💬 ismaelsadeeq commented on issue "estimateSmartFee error: "Insufficient data or no feerate found":
(https://github.com/bitcoin/bitcoin/issues/32178#issuecomment-2830820374)
I've seen this type of issue a few times now #32178, #31116, #31032, and recently, a PR to add a startup option for enabling conservative mode by default: #32329, with the aim to address problems like this.

The potential causes are:
1. Low activity on the network.
2. The node is running in `-blocksonly` mode.

As @pinheadmz mentioned, you can solve this by setting a `-fallbackfee`, just make sure it’s above both the node’s minimum relay transaction fee rate and the minimum mempool fee rate both
...

💬 achow101 commented on pull request "wallet: Disable creating and loading legacy wallets":
(https://github.com/bitcoin/bitcoin/pull/31250#discussion_r2060518038)
Added a commit to #28710 changing the comment, and removing `REQUIRE_WALLET_TYPE_SET`.

💬 achow101 commented on pull request "wallet: Disable creating and loading legacy wallets":
(https://github.com/bitcoin/bitcoin/pull/31250#discussion_r2060518265)
Added a commit to #28710 to remove

💬 achow101 commented on pull request "wallet: Disable creating and loading legacy wallets":
(https://github.com/bitcoin/bitcoin/pull/31250#discussion_r2060518464)
Added a commit to #28710 to restore

💬 achow101 commented on pull request "wallet: Disable creating and loading legacy wallets":
(https://github.com/bitcoin/bitcoin/pull/31250#discussion_r2060518571)
Added a commit to #28710 to remove

💬 achow101 commented on pull request "wallet: Disable creating and loading legacy wallets":
(https://github.com/bitcoin/bitcoin/pull/31250#discussion_r2060519263)
I'll let the next person to touch it to change this.