💬 maflcko commented on pull request "qa: Verify clean shutdown on startup failure":
(https://github.com/bitcoin/bitcoin/pull/30660#issuecomment-2829565889)
> Drahtbot's LLM is complaining ... [#30660 (comment)](https://github.com/bitcoin/bitcoin/pull/30660#issuecomment-2291135616)
> ... it's a false positive.

Yes, there are some rare false-positives. However, there are many more true positives, including one logic bug that was already found in a test in another pull, so I think overall it is worth it. Happy to discuss further in https://github.com/maflcko/DrahtBot/issues, or anywhere else.

💬 maflcko commented on issue "test: bip324_tests & net_tests failure with `-O3 -flto`":
(https://github.com/bitcoin/bitcoin/issues/32337#issuecomment-2829568058)
> gcc (Ubuntu 13.3.0-6ubuntu2~24.04) 13.3.0

You can use g++-14 from Ubuntu, which seems to work. Not sure if it was or will be fixed in gcc 13.4 as well (and if Ubuntu/Debian take that point release at all), but for now g++14 is probably your best bet.

I've also checked g++-15 nightly, and it seems to work as well: https://github.com/maflcko/b-c-nightly/actions/runs/14658126783/job/41136699706

I suspect that the issue initially reported here in this thread is musl related?

💬 maflcko commented on pull request "Crash fix, disconnect numBlocksChanged() signal during shutdown":
(https://github.com/bitcoin-core/gui/pull/864#issuecomment-2829592615)
lgtm ACK 71656bdfaa6bfe08ce9651246a3ef606f923351b

I have not reviewed the code, but I tried to reproduce the segfault with my steps to reproduce and it seemed to pass with about 15 restarts.

💬 maflcko commented on pull request "[29.x] Backports":
(https://github.com/bitcoin/bitcoin/pull/32292#issuecomment-2829596228)
Could also include https://github.com/bitcoin-core/gui/pull/864, possibly?

💬 maflcko commented on pull request "wallet: migration, don't create spendable wallet from a watch-only legacy wallet":
(https://github.com/bitcoin/bitcoin/pull/31423#issuecomment-2829614623)
There are some typos reported, which look real: https://github.com/bitcoin/bitcoin/pull/31423#issuecomment-2520009159.

💬 maflcko commented on issue "ctest -C Debug fails on vs2022 (Exit code 0xc0000135)":
(https://github.com/bitcoin/bitcoin/issues/32341#issuecomment-2829642643)
A third question would be, why the fuzz output is https://github.com/hebasto/bitcoin/actions/runs/14650416249/job/41114604643#step:14:60: `subprocess timed out: Currently only libFuzzer is supported`. A timeout should not happen for this process call, and the expected outcome should be an immediate stderr of `test/fuzz/fuzz.cpp:269 main: Assertion 'read_file(input_path, buffer)' failed. Error processing input "-help=1"` and an ignored exit code.

✅ maflcko closed a pull request: "wallet: Disable creating and loading legacy wallets"
(https://github.com/bitcoin/bitcoin/pull/31250)

💬 maflcko commented on pull request "wallet: Disable creating and loading legacy wallets":
(https://github.com/bitcoin/bitcoin/pull/31250#issuecomment-2829667411)
(fresh CI)

📝 maflcko reopened a pull request: "wallet: Disable creating and loading legacy wallets"
(https://github.com/bitcoin/bitcoin/pull/31250)
To prepare for the deletion of legacy wallet code, disable creating or loading new legacy wallets.

Tests for the legacy wallet specifically are deleted.

Split from https://github.com/bitcoin/bitcoin/pull/28710

🤔 pablomartin4btc reviewed a pull request: "fuzz: wallet: add target for spkm migration"
(https://github.com/bitcoin/bitcoin/pull/29694#pullrequestreview-2793362842)
You are skipping the backup restore in commit: "_wallet: skip backup restoration when using in-memory dbs_"; shouldn't the backup itself be skipped too when `in_memory`?

💬 pablomartin4btc commented on pull request "fuzz: wallet: add target for spkm migration":
(https://github.com/bitcoin/bitcoin/pull/29694#discussion_r2059789644)
I think if you add the condition there, there are other stuff that's missing and I think they need to be done which are:
- the for after `// Unload the wallets`;
- the lines after `// Verify that there is no dangling wallet`

💬 fanquake commented on pull request "Fix missing error check in `set_clo_on_exec` for FD_CLOEXEC handling":
(https://github.com/bitcoin/bitcoin/pull/32342#issuecomment-2829768875)
This should probably be going upstream (https://github.com/arun11299/cpp-subprocess). cc @hebasto.

⚠️ fanquake reopened an issue: "ctest -C Debug fails on vs2022 (miniscript_tests (SEGFAULT))"
(https://github.com/bitcoin/bitcoin/issues/32341)
cmd: `ctest --output-on-failure --stop-on-failure -j $NUMBER_OF_PROCESSORS -C Debug`

output:

```
88% tests passed, 1 tests failed out of 8

Total Test time (real) = 98.97 sec

The following tests FAILED:
8 - test_bitcoin-qt (Exit code 0xc0000135
)
Errors while running CTest
```

log: https://github.com/bitcoin/bitcoin/actions/runs/14646596997/job/41102269274?pr=32339#step:11:78

ref: https://github.com/bitcoin/bitcoin/pull/32339

💬 fanquake commented on issue "ctest -C Debug fails on vs2022 (miniscript_tests (SEGFAULT))":
(https://github.com/bitcoin/bitcoin/issues/32341#issuecomment-2829770735)
Re-opening, given it looks like there are at least two cmake/windows bugs here?

👍 fanquake approved a pull request: "depends: Fix cross-compiling on macOS"
(https://github.com/bitcoin/bitcoin/pull/32215#pullrequestreview-2793452071)
ACK d0cce4172c041fc9b2910b360fe496b1102b19d2

💬 fanquake commented on issue "cmake inconsistently overriding `-O3` (sometimes)":
(https://github.com/bitcoin/bitcoin/issues/31491#issuecomment-2829832622)
@hebasto can you followup with all the questions asked in this thread:

https://github.com/bitcoin/bitcoin/issues/31491#issuecomment-2573089576

https://github.com/bitcoin/bitcoin/issues/31491#issuecomment-2573886240

It'd be good to get some clarification on which behaviour is meant to work.

✅ fanquake closed an issue: "build: cross-compiling for `x86_64-apple-darwin` from `arm64-apple-darwin` broken"
(https://github.com/bitcoin/bitcoin/issues/32208)

🚀 fanquake merged a pull request: "depends: Fix cross-compiling on macOS"
(https://github.com/bitcoin/bitcoin/pull/32215)

⚠️ fanquake opened an issue: "build: Windows cross Qt broken on macOS host"
(https://github.com/bitcoin/bitcoin/issues/32346)
```bash
make -C depends HOST=x86_64-w64-mingw32
<snip>
-- Configure summary:

Building for: win32-g++ (x86_64, CPU features: )
Compiler: gcc 14.2.0
Build options:
Mode ................................... release
Optimize release build for size ........ no
Fully optimize release builds (-O3) .... no
Building shared libraries .............. no
Unity Build ............................ no
Relocatable ............................ no
Using precompiled headers .............. yes
Using L
...

💬 fanquake commented on pull request "guix: Remove unused `file` package":
(https://github.com/bitcoin/bitcoin/pull/32242#issuecomment-2829937944)
Guix Build:
```bash
feeb8da87994724878ac8a62a6e9bfb9b1ece855f336327c900214d84d0a2bb9 guix-build-513e2020a9ac/output/aarch64-linux-gnu/SHA256SUMS.part
216b287ffbff054a14e60e14b3376acb8cd41dd224223ecd508bd46efad020ba guix-build-513e2020a9ac/output/aarch64-linux-gnu/bitcoin-513e2020a9ac-aarch64-linux-gnu-debug.tar.gz
3e68be5a329cbf5f389ca0dde51c1b1dd16b63ec26f42b8aa97dbd455ee3f30e guix-build-513e2020a9ac/output/aarch64-linux-gnu/bitcoin-513e2020a9ac-aarch64-linux-gnu.tar.gz
da2d239a78e7ceaa
...