Bitcoin Core Github
44 subscribers
120K links
Download Telegram
📝 Jokacar10 opened a pull request: "Imagens do mcr Microsoft "
(https://github.com/bitcoin/bitcoin/pull/32328)

<!--
*** Please remove the following help text before submitting: ***

Pull requests without a rationale and clear improvement may be closed
immediately.

GUI-related pull requests should be opened against
https://github.com/bitcoin-core/gui
first. See CONTRIBUTING.md
-->

<!--
Please provide clear motivation for your patch and explain how it improves
Bitcoin Core user experience or Bitcoin Core developer experience
significantly:

* Any test improvements or new tests that impr
...
📝 fanquake locked a pull request: "Imagens do mcr Microsoft"
(https://github.com/bitcoin/bitcoin/pull/32328)

<!--
*** Please remove the following help text before submitting: ***

Pull requests without a rationale and clear improvement may be closed
immediately.

GUI-related pull requests should be opened against
https://github.com/bitcoin-core/gui
first. See CONTRIBUTING.md
-->

<!--
Please provide clear motivation for your patch and explain how it improves
Bitcoin Core user experience or Bitcoin Core developer experience
significantly:

* Any test improvements or new tests that impr
...
📝 fanquake locked a pull request: "Update netaddress.cpp"
(https://github.com/bitcoin/bitcoin/pull/32307)
Sets an internal network address based on a user-defined identifier. This approach ensures deterministic internal address generation, while avoiding accidental mismatches due to case or formatting variations.
📝 fanquake locked a pull request: "refactor: sort ubsan suppression values for consistency"
(https://github.com/bitcoin/bitcoin/pull/32298)
💬 vasild commented on pull request "net: improve the interface around FindNode() and avoid a recursive mutex lock":
(https://github.com/bitcoin/bitcoin/pull/32326#discussion_r2054434566)
> I will look into adding a comment to the call sites about this.

Can't come up with a good comment. Leaving it as it is, unless somebody has suggestions.
:lock: fanquake locked an issue: "Better planning"
(https://github.com/bitcoin/bitcoin/issues/32319)
:lock: fanquake locked an issue: "Double Spending and Its Impact on Digital Security"
(https://github.com/bitcoin/bitcoin/issues/32316)
:lock: fanquake locked an issue: "."
(https://github.com/bitcoin/bitcoin/issues/32314)
💬 hebasto commented on pull request "Reintroduce external signer support for Windows":
(https://github.com/bitcoin/bitcoin/pull/29868#issuecomment-2821854910)
Rebased.

Picked @luke-jr's [suggestion](https://github.com/bitcoin/bitcoin/pull/29868#discussion_r1970203305).
💬 hebasto commented on pull request "Reintroduce external signer support for Windows":
(https://github.com/bitcoin/bitcoin/pull/29868#discussion_r2054454737)
Thanks! Your commit has been picked.
💬 hebasto commented on pull request "Reintroduce external signer support for Windows":
(https://github.com/bitcoin/bitcoin/pull/29868#discussion_r2054455626)
Thanks! Dropped.
💬 hebasto commented on pull request "Reintroduce external signer support for Windows":
(https://github.com/bitcoin/bitcoin/pull/29868#discussion_r2054458473)
Reworked.
👋 hebasto's pull request is ready for review: "Reintroduce external signer support for Windows"
(https://github.com/bitcoin/bitcoin/pull/29868)
💬 l0rinc commented on pull request "[IBD] multi-byte block obfuscation":
(https://github.com/bitcoin/bitcoin/pull/31144#discussion_r2054469201)
Done
💬 l0rinc commented on pull request "[IBD] multi-byte block obfuscation":
(https://github.com/bitcoin/bitcoin/pull/31144#discussion_r2054469498)
I've changed it to an assert - if that's what you meant.
💬 l0rinc commented on pull request "[IBD] multi-byte block obfuscation":
(https://github.com/bitcoin/bitcoin/pull/31144#discussion_r2054469693)
Changed anyway
💬 l0rinc commented on pull request "[IBD] multi-byte block obfuscation":
(https://github.com/bitcoin/bitcoin/pull/31144#discussion_r2054469803)
renamed to `m_rotations`
💬 l0rinc commented on pull request "[IBD] multi-byte block obfuscation":
(https://github.com/bitcoin/bitcoin/pull/31144#discussion_r2054469920)
Did something similar (except for cstdint)
💬 l0rinc commented on pull request "[IBD] multi-byte block obfuscation":
(https://github.com/bitcoin/bitcoin/pull/31144#discussion_r2054470025)
Want to avoid this, but I don't actually mind either way - done
💬 l0rinc commented on pull request "[IBD] multi-byte block obfuscation":
(https://github.com/bitcoin/bitcoin/pull/31144#discussion_r2054470143)
Done