💬 vasild commented on pull request "net: improve the interface around FindNode() and avoid a recursive mutex lock":
(https://github.com/bitcoin/bitcoin/pull/32326#discussion_r2054408043)
Hmm, in `CConnman::OpenNetworkConnection()` the code does:

* if `pszDest` is not set then use `AlreadyConnectedToAddress(addrConnect)` which ignores the port
* if `pszDest` is set then `OutboundConnectedToStr(pszDest)` which compares the port as well.

Changing that logic is, I guess, out of the scope of this non-functional refactor PR. If to be done it would better be assessed in isolation in its own PR.

📝 maflcko opened a pull request: "test: Add missing check for empty stderr in util tester"
(https://github.com/bitcoin/bitcoin/pull/32327)
Now that wine support was removed from the CI in 25b56fd9b469f8e5d36f0132c3b79a5214e3372a, it can probably be removed from the util tester as well.

If someone really needs this, they can comment the new check out, or submit a patch to add an option/env var to silence the new check.

👍 fanquake approved a pull request: "ci: Add missing -Wno-error=array-bounds to valgrind fuzz"
(https://github.com/bitcoin/bitcoin/pull/32325#pullrequestreview-2784608357)
ACK fa653cb4169f03e4f327b18a1ff103d72dcc61f7 - checked native fuzz

✅ fanquake closed an issue: "ci: fuzz_with_valgrind job broken"
(https://github.com/bitcoin/bitcoin/issues/32276)

🚀 fanquake merged a pull request: "ci: Add missing -Wno-error=array-bounds to valgrind fuzz"
(https://github.com/bitcoin/bitcoin/pull/32325)

✅ fanquake closed a pull request: "tests: Improve stderr validation in test_runner.py"
(https://github.com/bitcoin/bitcoin/pull/32183)

💬 fanquake commented on pull request "tests: Improve stderr validation in test_runner.py":
(https://github.com/bitcoin/bitcoin/pull/32183#issuecomment-2821799863)
Closing in favour of #32327.

📝 Jokacar10 opened a pull request: "Imagens do mcr Microsoft "
(https://github.com/bitcoin/bitcoin/pull/32328)

<!--
*** Please remove the following help text before submitting: ***

Pull requests without a rationale and clear improvement may be closed
immediately.

GUI-related pull requests should be opened against
https://github.com/bitcoin-core/gui
first. See CONTRIBUTING.md
-->

<!--
Please provide clear motivation for your patch and explain how it improves
Bitcoin Core user experience or Bitcoin Core developer experience
significantly:

* Any test improvements or new tests that impr
...

📝 fanquake locked a pull request: "Imagens do mcr Microsoft"
(https://github.com/bitcoin/bitcoin/pull/32328)

<!--
*** Please remove the following help text before submitting: ***

Pull requests without a rationale and clear improvement may be closed
immediately.

GUI-related pull requests should be opened against
https://github.com/bitcoin-core/gui
first. See CONTRIBUTING.md
-->

<!--
Please provide clear motivation for your patch and explain how it improves
Bitcoin Core user experience or Bitcoin Core developer experience
significantly:

* Any test improvements or new tests that impr
...

📝 fanquake locked a pull request: "Update netaddress.cpp"
(https://github.com/bitcoin/bitcoin/pull/32307)
Sets an internal network address based on a user-defined identifier. This approach ensures deterministic internal address generation, while avoiding accidental mismatches due to case or formatting variations.

📝 fanquake locked a pull request: "refactor: sort ubsan suppression values for consistency"
(https://github.com/bitcoin/bitcoin/pull/32298)

💬 vasild commented on pull request "net: improve the interface around FindNode() and avoid a recursive mutex lock":
(https://github.com/bitcoin/bitcoin/pull/32326#discussion_r2054434566)
> I will look into adding a comment to the call sites about this.

Can't come up with a good comment. Leaving it as it is, unless somebody has suggestions.

:lock: fanquake locked an issue: "Better planning"
(https://github.com/bitcoin/bitcoin/issues/32319)

:lock: fanquake locked an issue: "Double Spending and Its Impact on Digital Security"
(https://github.com/bitcoin/bitcoin/issues/32316)

:lock: fanquake locked an issue: "."
(https://github.com/bitcoin/bitcoin/issues/32314)

💬 hebasto commented on pull request "Reintroduce external signer support for Windows":
(https://github.com/bitcoin/bitcoin/pull/29868#issuecomment-2821854910)
Rebased.

Picked @luke-jr's [suggestion](https://github.com/bitcoin/bitcoin/pull/29868#discussion_r1970203305).

💬 hebasto commented on pull request "Reintroduce external signer support for Windows":
(https://github.com/bitcoin/bitcoin/pull/29868#discussion_r2054454737)
Thanks! Your commit has been picked.

💬 hebasto commented on pull request "Reintroduce external signer support for Windows":
(https://github.com/bitcoin/bitcoin/pull/29868#discussion_r2054455626)
Thanks! Dropped.

💬 hebasto commented on pull request "Reintroduce external signer support for Windows":
(https://github.com/bitcoin/bitcoin/pull/29868#discussion_r2054458473)
Reworked.

👋 hebasto's pull request is ready for review: "Reintroduce external signer support for Windows"
(https://github.com/bitcoin/bitcoin/pull/29868)