💬 fanquake commented on issue "ci: failure in interface_usdt_coinselection.py":
(https://github.com/bitcoin/bitcoin/issues/32322#issuecomment-2820637063)
cc @0xB10C

💬 maflcko commented on issue "ci: failure in interface_usdt_coinselection.py":
(https://github.com/bitcoin/bitcoin/issues/32322#issuecomment-2820656309)
Probably an erroneous kernel that was pushed to GHA by microsoft? Seems fixed by now

💬 maflcko commented on pull request "fuzz: enable running fuzz test cases in Debug mode":
(https://github.com/bitcoin/bitcoin/pull/32113#issuecomment-2820675009)
re-ACK 3669ecd4ccd8e7a1e2b1a9dcbe708c51c78e4d6c 🏉

<details><summary>Show signature</summary>

Signature:

```
untrusted comment: signature from minisign secret key on empty file; verify via: minisign -Vm "${path_to_any_empty_file}" -P RWTRmVTMeKV5noAMqVlsMugDDCyyTSbA3Re5AkUrhvLVln0tSaFWglOw -x "${path_to_this_whole_four_line_signature_blob}"
RUTRmVTMeKV5npGrKx1nqXCw5zeVHdtdYURB/KlyA/LMFgpNCs+SkW9a8N95d+U4AP1RJMi+krxU1A3Yux4bpwZNLvVBKy0wLgM=
trusted comment: re-ACK 3669ecd4ccd8e7a1e2b1
...

💬 hebasto commented on issue "gui: translation spam?":
(https://github.com/bitcoin/bitcoin/issues/32295#issuecomment-2820714655)
I'm on it.

💬 marcofleon commented on pull request "fuzz: enable running fuzz test cases in Debug mode":
(https://github.com/bitcoin/bitcoin/pull/32113#issuecomment-2820825720)
re ACK 3669ecd4ccd8e7a1e2b1a9dcbe708c51c78e4d6c

💬 hebasto commented on issue "PIE+LTO causes Bitcoin-Qt to segfault at startup":
(https://github.com/bitcoin-core/gui/issues/867#issuecomment-2820828813)
1. It seems reasonable to move this issue to the [main](https://github.com/bitcoin/bitcoin/issues) repository to increase its visibility to the build system developers.

2. I can't reproduce the issue on Ubuntu 24.10 using GCC 14.2.0:
```
$ rm -rf build && cmake -B build -DCMAKE_C_FLAGS=-flto -DCMAKE_CXX_FLAGS=-flto -DBUILD_GUI=ON
$ cmake --build build -t bitcoin-qt
$ ./build/bin/bitcoin-qt
```

This suggests the issue may be specific to the default compiler options. If so, please consider updat
...

💬 hebasto commented on pull request "tests: Improve stderr validation in test_runner.py":
(https://github.com/bitcoin/bitcoin/pull/32183#discussion_r2053824868)
This is intended to handle multi-config generator, which create per-config subdirectories:
```
$ cmake -B build-mc -G "Ninja Multi-Config"
$ cmake --build build-mc
$ ctest --test-dir build-mc -R util_test_runner
```

💬 hebasto commented on pull request "cmake: Improve robustness and usability":
(https://github.com/bitcoin/bitcoin/pull/31233#discussion_r2053826793)
Answered in https://github.com/bitcoin/bitcoin/pull/32183#discussion_r2053824868.

👍 TheCharlatan approved a pull request: "rpc: add optional blockhash to waitfornewblock, unhide wait methods in help"
(https://github.com/bitcoin/bitcoin/pull/30635#pullrequestreview-2783648578)
Re-ACK c6e2c31c55123cc97b4400bcbf3c37a39b067a22

💬 thesamesam commented on issue "PIE+LTO causes Bitcoin-Qt to segfault at startup":
(https://github.com/bitcoin-core/gui/issues/867#issuecomment-2820894205)
Ubuntu builds their Qt with "reduce relocations" disabled, so it doesn't hit this (see https://bugs.gentoo.org/933110#c5).

The root cause is a mix between Qt, CMake, and the fact there's no way for the toolchain to communicate a problem. CMake doesn't seem particularly interested in fixing it given https://gitlab.kitware.com/cmake/cmake/-/issues/15570#note_477736. Qt says that the right thing to do is to honour their own recommendation (naturally).

I spent a significant amount of time investig
...

⚠️ fanquake opened an issue: "build: CMake caching failing PIE check"
(https://github.com/bitcoin/bitcoin/issues/32323)
Similar to https://github.com/bitcoin/bitcoin/issues/31942#issuecomment-2703801270, CMake caches the check failure, which leaves the user in a broken state (unless they nuke the build dir):
```bash
cmake -B build -DAPPEND_CXXFLAGS="-ftrivial-auto-var-init"
-- The CXX compiler identification is GNU 14.2.0
-- Detecting CXX compiler ABI info
-- Detecting CXX compiler ABI info - done
-- Check for working CXX compiler: /usr/bin/c++ - skipped
-- Detecting CXX compile features
-- Detecting CXX compile
...

📝 hebasto opened a pull request: "test: Treat executable paths in tests consistently"
(https://github.com/bitcoin/bitcoin/pull/32324)
When using multi-config CMake generators, executable paths include per-config subdirectories, which require special handling in tests. Using dedicated environment variables to specify executable paths works well in such scenarios. However, the `util_test_runner` test sets these variables for the `util/test_runner.py` script unconditionally, which diverges from the approach used when running `functional/test_runner.py`.

This change makes the usage of the aforementioned environment variables un
...

💬 hebasto commented on pull request "tests: Improve stderr validation in test_runner.py":
(https://github.com/bitcoin/bitcoin/pull/32183#discussion_r2053861553)
@maflcko

I believe https://github.com/bitcoin/bitcoin/pull/32324 should address your concerns.

💬 l0rinc commented on pull request "bench: close wallets after migration":
(https://github.com/bitcoin/bitcoin/pull/32309#discussion_r2053864587)
This wasn't needed in the end, removed in latest push

💬 l0rinc commented on pull request "bench: close wallets after migration":
(https://github.com/bitcoin/bitcoin/pull/32309#issuecomment-2820945963)
Thanks for the suggestions @furszy, @achow101 and @maflcko.
Updated the commits to use `MakeWalletLoader` instead of manually closing, and moved the `epochIterations(1)` after the CI change to obviate that the CI already does that.

💬 TheCharlatan commented on pull request "bench: close wallets after migration":
(https://github.com/bitcoin/bitcoin/pull/32309#issuecomment-2820962881)
> I believe we've kept it merely as a sanity check because it's the only test that will survive the annihilation of the legacy wallet code.

Sounds like this should be an actual test then instead of a benchmark, no?

💬 l0rinc commented on pull request "[IBD] prevector: store `P2WSH`/`P2TR`/`P2PK` scripts inline":
(https://github.com/bitcoin/bitcoin/pull/32279#discussion_r2053895857)
Thanks, extracted to a separate commit - as suggested by @luke-jr as well - added you both as co-authors.

💬 l0rinc commented on pull request "[IBD] prevector: store `P2WSH`/`P2TR`/`P2PK` scripts inline":
(https://github.com/bitcoin/bitcoin/pull/32279#discussion_r2053896250)
Done, thanks

💬 l0rinc commented on pull request "bench: close wallets after migration":
(https://github.com/bitcoin/bitcoin/pull/32309#issuecomment-2820998715)
> Sounds like this should be an actual test then instead of a benchmark, no?

I also asked the same.
I suggest we fix and reenable full CI-validation first, and we can create a detailed test with proper asserts separately - since I'm not a wallet expert (yet?)

👍 laanwj approved a pull request: "wallet: Disable creating and loading legacy wallets"
(https://github.com/bitcoin/bitcoin/pull/31250#pullrequestreview-2783785728)
Re-ACK e39118ab0bf08fdaf68b16c86ad304b9133b43c7
git range-diff b8cefeb221490868d62b7a0695f8b5ea392d3654..545a36ae0aa5687366fc4fdd54058072f333e73f b2bb27f40c7ab7b51720e41d136dcc9077a525b3..e39118ab0bf08fdaf68b16c86ad304b9133b43c7 commit
- `test: rpcs disabled for descriptor wallets were removed` was dropped and moved to another PR
- `tests, gui: Use descriptors watchonly wallet for watchonly test` was added
- `test: Remove legacy wallet unit tests`: qt related changes were removed, replaced b
...